trailofbits / manticoreui-ghidra Goto Github PK

MUI-Core should allow users to write custom hooks for more granular control of mcore execution beyond the Find/Avoid address commands. Refer to trailofbits/ManticoreUI#24 and trailofbits/ManticoreUI#49

MUI-Ghidra should also have a new UI component for users to type in the code for these custom hooks

There are warnings thrown by gradle during the build about dependencies not being explicit. I believe this is due to some code-generation for protobuf and/or grpc. I don't know exactly how to fix this, but I think searching would probably yield an answer.

From another project, we have something like the following:

protobuf {
    generatedFilesBaseDir = "$projectDir/src"
    protoc {
        artifact = "com.google.protobuf:protoc:3.17.3"
    }
    generateProtoTasks {
        all().each { task -> task.dependsOn copyDependencies }
    }
}

If possible, there should be a button for the user to press that would follow Manticore's log output in the log window.

Ideally, the log windows default to following, but if the user starts scrolling up in that window, the automatic following is turned off. Then there would be a button to start following again which would also go to the end of the log if it is finished.

currently, some of the RPC calls return a Response object indicating success/failure, while others use non-obvious methods to indicate failure like a log message with an error string or a well-formed response object containing no data.

Instead, we should make use of gRPC status codes https://grpc.github.io/grpc/core/md_doc_statuscodes.html to make error-checking easier for our RPC clients on the frontend plugins.

The MUI setup/logging windows should initially be hidden until the user is ready to use them by clicking through the menu interface.

The workflow for starting MUI should be documented so that users are aware of how to find it.

This should be integrated into the justfile under the format and lint commands

I recommend adding the following tools with specific versions to a requirements-dev.txt file to the MUICore directory:

• black formatter
• mypy for type checking (although I'm not sure how nice this plays with grpc/protobuf, so could be optional for now)

The RPC calls to Find/Avoid hooks should not be "universal to all future instances" as they are currently implemented. They should be instance-specific, and probably passed to the gRPC server only when StartNative is called.

This would also help the storing and reloading of MUI state based on each plugin's implementation of persistence.

Currently, Manticore can be in a non-running / killed state but still be in the midst of the finalize function https://github.com/trailofbits/manticore/blob/9e11bc9ae9cc961d38c2a4932372d89fec2c6b26/manticore/core/manticore.py#L1217

Where test case reports are still being generated and logs are still being output. With frontend clients relying on the CheckManticoreRunning function to determine whether to keep polling for logs, this means that some of the "generated test case x..." logs will not be polled for since CheckManticoreRunning will already return an is_running: False value

It would be nice to have the plugin automatically focus on the log screen when the user presses "Run".