trailofbits / onesixtyone Goto Github PK

Hi,
It would be great if you could make a tagged release.
I would like to update the Debian package (it's still version 0.3.2) and the packaging tools works best with tagged release: we have tools that monitors web pages listing release, and it works well with github pages showing git tags.
Thanks!

In the output is the icmp destination address displayed in the icmp source address column.

Hi,

it will be great if it can display a progress with the ETA, so when scanning networks with several communities, we can know how long it will take to finish.

Thanks in advance

Hi, there are a couple patches Debian is applying to onesixtyone and it would be nice to see them incorporated upstream.
They are:

Description: Add missing flags
Author: Sophie Brun <[email protected]>
Last-Update: 2019-04-02
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,5 @@
 onesixtyone: onesixtyone.c
-	gcc -o onesixtyone onesixtyone.c
+	gcc $(CFLAGS) $(LDFLAGS) $(CPPFLAGS) -o onesixtyone onesixtyone.c
 
 solaris: onesixtyone.c
 	cc -o onesixtyone onesixtyone.c -lsocket -lnsl

and

Description: don't hard codes the build architecture compiler
 onesixtyone fails to cross build from source, because the upstream
 Makefile hard codes the build architecture compiler "gcc". Making it
 substitutable is sufficient for making onesixtyone cross buildable.
Author: Helmut Grohne <[email protected]>
Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930902
Last-Update: 2019-07-08
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,5 @@
 onesixtyone: onesixtyone.c
-	gcc $(CFLAGS) $(LDFLAGS) $(CPPFLAGS) -o onesixtyone onesixtyone.c
+	$(CC) $(CFLAGS) $(LDFLAGS) $(CPPFLAGS) -o onesixtyone onesixtyone.c
 
 solaris: onesixtyone.c
 	cc -o onesixtyone onesixtyone.c -lsocket -lnsl

If you'd like to see them upstreamed, I could open a PR.

Cheers!

I get this error if the input file is 121 lines of strings

Hello,
accidentally the version remained 0.3.3 in the 0.3.4 release.

#28 fixes this.

Please add ability for fetch/display numeric sysObjectID (1.3.6.1.2.1.1.2) together with sysDescr.

Can be optional, with output something like:

192.168.120.92 [1234] {.1.3.6.1.4.1.318.1.3.4.5} HP ETHERNET MULTI-ENVIRONMENT,ROM A.05.03,JETDIRECT,
JD24,EEPROM A.05.05
130.160.108.146 [public] {.1.3.6.1.4.1.318.1.3.4.5} Hardware: x86 Family 15 Model 0 Stepping 10 AT/AT
COMPATIBLE - Software: Windows 2000 Version 5.0 (Build 2195 Uniprocessor Free)

Unfortunately I'm not C guru..

Your tool/software has been inventoried on Rawsec's CyberSecurity Inventory.

onesixtyone : https://inventory.rawsec.ml/tools.html#onesixtyone

What is Rawsec's CyberSecurity Inventory?

An inventory of tools and resources about CyberSecurity. This inventory aims to help people to find everything related to CyberSecurity.

More details about features here.

Note: the inventory is a FLOSS (Free, Libre and Open-Source Software) project.

Why should you care about being inventoried?

Mainly because this is giving visibility to your tool and improve its referencing.

Badges

The badge shows to your community that your are inventoried. It looks good but also shows you care about your project, that your tool is referenced.

Feel free to claim your badge here: http://inventory.rawsec.ml/features.html#badges, it looks like that , but there are several styles available.

Want to thank us?

If you want to thank us, you can help make our open project better known by tweeting about it! For example:

So what?

That's all, this message is just to notify you if you care. Else you can close this issue.

onesixtyone is accounting one more community than it should when the file is '\n' terminated. To solve it, we should see if it's last community read was 0 sized and EOF was reached:

--- a/onesixtyone.c
+++ b/onesixtyone.c
@@ -142,7 +142,11 @@ void read_communities(char* filename)
     printf("MAX_COMMUNITIES (%d) reached. Remaining communities will be skipped \n", i);
   }
 
-  community_count = i;
+  if (c == 0 && ch == -1)
+	  community_count = i - 1;
+  else
+	  community_count = i;
+
   fclose(fd);
 }
 

https://scan.coverity.com/