transloadit / terraform-provider-transloadit Goto Github PK

Hi,
As far as I can tell there's no way to set require_signature_auth in my transloadit_template, right now I need to make an additional API call outside of this provider to require it.

As a side note, I ran into some issues getting the provider to work following using instructions in README.md (with terraform 0.13.3), but adding this makes it so that the provider is automatically installed etc. on terraform init:

terraform {
  required_providers {
    transloadit = {
      source  = "transloadit/transloadit"
      version = "0.2.0"
    }
  }
}

Hi thanks for the provider it is super helpful!

The issue I'm running into is that only steps are included when creating a template with the provider. This means top level fields like notify_url or fields are not included.

I apologise, I'm not a go programmer, but I think I tracked it down to the transloadit go sdk, the template.go file has a struct TemplateContent which only has a single property steps.

Source

When I search for notify_url in the go sdk repo, I can see it is referenced by assembly.go and notification.go only ( Source ).

I'm wondering if it is useful to even define the struct? By simply passing through the raw JSON template from the terraform definition the API itself will validate the format automatically. The type definition in terraform is just a string (source) but the SDK is then eliding valid fields.

The API validation is very good, so I'm wondering if the go sdk should simply pass through the JSON and rely upon server side validation. This would ensure the terraform provider is always in sync with the API. Either that or, have the terraform provider schema definition map perfectly to the current API version which is a bit of maintenance burden but would justify having client verification in the SDK.

If you have any suggestions that would be much appreciated

Appreciate creating transloadit_template_credential for providing template credentials via Terraform. However, I am missing the link between these credentials and the account/app. Should there be a provider param, similar to how transloadit_template works?

See title, would be nice and ease onboarding if there was a copy paste example to get going with the provider for non-go-devs

When attempting to install this provider locally I get the following error:

Error: Incompatible provider version

Provider registry.terraform.io/transloadit/transloadit v0.4.0 does not have a package available for your current platform, darwin_arm64.

I plan to manage transloadit's iam credentials with terraform. As it stands I think that means I'd need to embed the credentials in the template config. It'd be superior if I could create the third-party credentials via terraform so no one needs to know the credentials directly.

• Do we have/want to migrate away from travis CI (due to change in free policy : https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing) to other solution ?
• Which other solution to choose ? Github Actions ?

For Github Actions, we need 2 jobs :

• CI job : test (unit + acceptance) + build providers for different targets : https://github.com/transloadit/terraform-provider-transloadit/blob/master/.github/workflows/ci.yml
• Release Job : Integrate goreleaser and gpg logic in a github action : I think what could be difficult is the integration of GPG key : https://github.com/transloadit/terraform-provider-transloadit/blob/master/.github/workflows/release.yml

Currently for Templates we use this:

resource "transloadit_template" "resize-img" {
	name     = "resize-img"
	template = <<EOT
{
  "steps": {
    "imported": {
      "robot": "/s3/import",
      "credentials": "my_s3_$${assembly.region}",
      "path": "/onthefly/$${fields.input}"
    },
    "resized": {
      "use": "imported",
      "robot": "/image/resize",
      "width": "$${fields.w}",
      "imagemagick_stack": "v2.0.7"
    },
    "served": {
      "use": "resized",
      "robot": "/file/serve"
    }
  }
}
EOT
}

I wonder if it would be possible somehow, to use HCL to write Templates instead, since it can map back to JSON?

Not unlike an iam_policy_document policy document i suppose https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document

Or maybe there is some native way where we can tell Terraform: hey this hcl right here can be turned into a JSON string right there?

Main reason: DX. Examples and config files are going to look prettier, you can comment Templates, no longer have trailing comma issues, nicer syntax highlighting.

Is there a way to mark a template credential's content as sensitive? Or, at least they key/secret pair? Doing a terraform plan will show the values in plain text, which isn't something desired.