travs / dev-tools-themes Goto Github PK

Hi! Atom will soon be upgrading to a new version of Electron, which will cause some APIs to change.

You'll need to change this usage of require('remote').require('browser-window') to require('electron').remote.BrowserWindow.

There may be other similar small changes required. See this post on the electron blog for more information. And let me know if you need any additional help. Thanks!

[Enter steps to reproduce:]

1. Start Atom
2. Enable dev-tools
3. Press F5 within devtools pane for refresh

Atom: 1.45.0 x64
Electron: 4.2.7
OS: Microsoft Windows 10 Enterprise
Thrown From: dev-tools-themes package 0.1.3

Stack Trace

Failed to activate the dev-tools-themes package

At Could not call remote function 'anonymous'. Check that the function signature is correct. Underlying error: Error processing argument at index 0, conversion failure from undefined

Error: Could not call remote function 'anonymous'. Check that the function signature is correct. Underlying error: Error processing argument at index 0, conversion failure from undefined
    at callFunction (~/AppData/Local/atom/app-1.45.0/resources/electron.asar/browser/rpc-server.js:258:17)
    at ~/AppData/Local/atom/app-1.45.0/resources/electron.asar/browser/rpc-server.js:409:10
    at EventEmitter.ipcMain.on.args (~/AppData/Local/atom/app-1.45.0/resources/electron.asar/browser/rpc-server.js:273:21)
    at EventEmitter.emit (events.js:182:13)
    at WebContents.<anonymous> (~/AppData/Local/atom/app-1.45.0/resources/electron.asar/browser/api/web-contents.js:368:21)
    at WebContents.emit (events.js:182:13)

Commands

Non-Core Packages

atom-console 0.4.6 
atom-html-preview 0.2.6 
atom-import-js 1.0.0 
atom-material-syntax 1.0.8 
atom-material-ui 2.1.3 
autocomplete-paths 2.12.2 
browser-plus 0.0.98 
busy-signal 2.0.1 
city-lights-syntax 1.1.8 
city-lights-ui 1.5.3 
debug 0.0.1 
dev-tools-themes 0.1.3 
docblockr 0.13.7 
ide-html 0.6.0 
ide-python 1.5.0 
intentions 1.1.5 
jslint 1.5.1 
linter 2.3.1 
linter-eslint 8.5.5 
linter-ui-default 1.8.1 
native-ui 0.27.0 
nord-atom-syntax 0.10.0 
nord-atom-ui 0.12.0 
preview 0.19.0 
run-in-atom 1.0.5 
teletype 0.13.4 
todo-show 2.3.2 
web-data 0.7.1 

Failed to activate the dev-tools-dark package
Cannot read property 'mainModulePath' of undefined

[Enter steps to reproduce:] 1. ... 2. ... Atom: 1.18.0 x64 Electron: 1.3.15 OS: Ubuntu 16.04.1 Thrown From: dev-tools-dark package 0.5.0 ### Stack Trace Failed to activate the dev-tools-dark package At Cannot read property 'mainModulePath' of undefined TypeError: Cannot read property 'mainModulePath' of undefined at Object.activate (/packages/dev-tools-dark/lib/dev-tools-themes.js:57:69) at Package.module.exports.Package.activateNow (/usr/share/atom/resources/app/src/package.js:253:25) at /usr/share/atom/resources/app/src/package.js:225:38 at Package.module.exports.Package.measure (/usr/share/atom/resources/app/src/package.js:99:21) at /usr/share/atom/resources/app/src/package.js:218:32 at Package.module.exports.Package.activate (/usr/share/atom/resources/app/src/package.js:215:40) at PackageManager.module.exports.PackageManager.activatePackage (/usr/share/atom/resources/app/src/package-manager.js:645:40) at /usr/share/atom/resources/app/node_modules/settings-view/lib/package-manager.js:519:35 at exit (/usr/share/atom/resources/app/node_modules/settings-view/lib/package-manager.js:128:22) at triggerExitCallback (/usr/share/atom/resources/app/src/buffered-process.js:338:17) at /usr/share/atom/resources/app/src/buffered-process.js:359:17 at Socket.<anonymous> (/usr/share/atom/resources/app/src/buffered-process.js:220:15) at emitOne (events.js:101:20) at Socket.emit (events.js:188:7) at Pipe._handle.close [as _onclose] (net.js:493:12) ### Commands 2x -4:13 tree-view:show (atom-workspace.workspace.scrollbars-visible-always) -4:02.3.0 core:paste (input.hidden-input) 2x -3:53.9.0 dev-tools-themes:settingsView (input.hidden-input) -2:56.6.0 window:toggle-dev-tools (div.panels-item) -2:50.5.0 core:confirm (input.hidden-input) -1:05.8.0 dev-tools-themes:settingsView (a.) ### Non-Core Packages atom-autocomplete-php 0.25.6 atom-beautify 0.30.1 atom-runner 2.7.1 atom-shell-commands 1.5.0 dev-tools-dark 0.5.0 file-icons 2.1.7 git-control 0.9.0 language-groovy 0.7.0 node-debugger 1.10.1 php-debug 0.2.4 php-server 0.7.0 script 3.15.0 svn 0.0.13 tabs-to-spaces 1.0.3 trailing-spaces 0.4.0 turbo-javascript 1.4.0 xml-formatter 0.11.0

Use remote.BrowserWindow instead of remote.require("browser-window")

Object.require (/Applications/Atom.app/Contents/Resources/app.asar/src/electron-shims.js:54:12)
Object.<anonymous> (/Users/feroze/.atom/packages/dev-tools-themes/lib/dev-tools-themes.js:3:28)
Module._compile (/Applications/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:109:30)
Object..js (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:216:21)
Module.load (module.js:473:32)
tryModuleLoad (module.js:432:12)

is there any chance you will add other/all themes you linked on http://devthemez.com/themes/chrome-developer-tools ??

this is a great app btw

hope you have a little time to add those!

Any plans on joining PR fixing #5 ?

Should one bother on upload to atom packages with the fix as dev-tools-them-reloaded?

Possibly use Message Passing to send the current UI and Syntax elements of the Atom DOM to the DevTools DOM.

You'd also probably need to str.replace things as the message comes in. For example: atom-workspace to .widget.

Use remote.BrowserWindow instead of remote.require("browser-window")

Object.require (/Applications/Atom.app/Contents/Resources/app.asar/src/electron-shims.js:54:12)
Object.<anonymous> (/Users/jordanklassen/.atom/packages/dev-tools-themes/lib/dev-tools-themes.js:3:28)
Module._compile (/Applications/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:109:30)
Object..js (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:216:21)
Module.load (module.js:473:32)
tryModuleLoad (module.js:432:12)

From deprecation cop. I may write a pr if noone else gets to this.