trecenti / argumenter Goto Github PK

The below code will (perhaps unexpectedly) execute the callback for the Object strategy.

var Foo = function Foo() {
};

function myFunc() {
  argumenter(arguments)
    .when(Object, function(obj) { /* .. */ })
    .when(Foo, function(obj) { /** .. */ });
}

myFunc(new Foo());

The below code will execute the callback for the Foo strategy.

var Foo = function Foo() {
};

function myFunc() {
  argumenter(arguments)
    .when(Foo, function(obj) { /** .. */ })
    .when(Object, function(obj) { /* .. */ });
}

myFunc(new Foo());

Other issues exist too; if your strategy is an array of strategies, then it must be placed before any singular strategies: [Object, String] must come before Object.

Perhaps the, ahem, strategy to deal with this would be to store all of the strategies and determine precedence during the done() function. This could be done by examining constructors and prototypes, then creating some sort of precedence tree... but that sounds like a lot of work.

The type checking is too loose; typeof([]) will return 'object'. This comes into play if the Object strategy comes before the Array one.

example:

function myFunc() {
  return argumenter(arguments)
    .when(Object, function(obj) {
      return 1;
    })
    .when(Array, function(arr) {
      return 2;
    })
    .done();
};

console.log(myFunc([])); // 1

Also, someArray instanceof Object is true. It should only check instanceof if someArray is not an Array.

I've corrected both these issues and will amend my PR.