trelliscommerce / shopify-tailwind-starter-base Goto Github PK

Are package.json and package-lock.json the only things that need to be in there? Should node_modules and anything else related to dev stuff also be included?

Hi there,

I stumbled upon your repo - thank you for making this tailwind integration with Dawn available to us all. I just wanted to check if there are any plans to update the TrellisCommerce/shopify-dawn-tailwind-starter-base with the recent changes Shopify has made to Dawn, releasing version 6. These changes add several improvements, such as the ability to switch the cart functionality to a drawer.

It would be great to know if this repo will follow suit?

Thanks again for the effort you've put into this thus far.

Describe the current behavior

When filtering on a collection page I'm getting the following error on the browser console and the page gets stuck:

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'innerHTML')
    at FacetFiltersForm.renderProductGridContainer (facets.js:97:45)
    at facets.js:78:26

Describe the expected behavior

The collection should be filtered.

Version information (Dawn, browsers and operating systems)

• Dawn Version: 13.0.1
• Latest version of this starter base

Additional context/screenshots

To confirm I've also downloaded this package as zip and installed directly as theme.

After investing many hours getting this theme running, I realised it is 2 major versions behind the current Dawn theme. https://github.com/Shopify/dawn

If it is no longer maintained, please put a warning in the README so that it can be used for reference but not production! Or update it to the latest version of Dawn? 🙏

Describe the current behavior
Tailwind is inheriting the html font-size from Dawn, which is 6.25px by default.

Describe the expected behavior
Ability to set a base font size that works with Tailwind but does not affect Dawn styles.

Version information (Dawn, browsers and operating systems)

• Dawn Version: 1.0.0
• Chrome Version 91.0.4472.114
• macOS Version 11.3.1

Possible solution

Additional context/screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

Describe the current behavior

Files inside the snippets folder, ignore the prettierrc.json settings for some reason. This causes them to fall back to the settings in the npm package. The settings in the npm package have singleQuotes set to true, so every single time you save or format a page in the snippets directory, all the double quotes get changed to single quotes. If you delete the prettier setting in package,json, it works as expected.

Describe the expected behavior

Double quotes should stay double quotes

Version information (Dawn, browsers and operating systems)

Latest version of this theme on dawn 12.