trilbymedia / grav-plugin-login-oauth2-extras Goto Github PK

Hi,

I had an issue with GitlabProvider :

E_COMPILE_ERROR - Declaration of Grav\Plugin\Login\OAuth2\Providers\GitlabProvider::initProvider(array $options) must be compatible with Grav\Plugin\Login\OAuth2\Providers\BaseProvider::initProvider(array $options): void

I fixed the problem by adding void in the function signature :

class GitlabProvider extends ExtraProvider
{
    protected $name = 'Gitlab';
    protected $classname = 'Omines\\OAuth2\\Client\\Provider\\Gitlab';

    public function initProvider(array $options) : void

I don't know if it depends on the version of PHP used. For information i am using PHP Version 8.0.6

Discord SSO Documentation doesn't exist?

https://extrasapp.com/developers/docs/topics/oauth2 is not an active domain also?

Configured the plugin without any issues for the admin. When using OAuth for the admin access, I'm redirected to /1 page (which obviously doesn't exist). When I enter /admin everything I'm logged in.

The same result e.g. with facebook, it is redirecting to /1#=

is there anything more needs to be configured?

The current Twitch provider depotwarehouse/oauth2-twitch is based on the now defunct Kraken API.

There is a new provider vertisan/oauth2-twitch-helix which should be drop in compatible.

Any chance of getting this included?

While using the plugin, I've noticed that once the tokens that this plugin fetches from the AzureAD OAuth endpoint and stores in the users .yaml expire, they will not get refreshed(this is especially annoying when sending the tokens back to the client in the form of cookies, so the client can fetch external APIs)

This results in the end-user needing to log out and log back in in order to manually refresh the tokens.
Is this the intended behavior?