Comments (4)
from trinitycore.
AC fixed this in azerothcore/azerothcore-wotlk@f75aceb
from trinitycore.
we don't really care about trashzerothcore and also this is not a big issue, if you ask me seems much more logically that the skill increase more on gray-level mobs that the other since their level is close to yours, and you also did not provide any proof.
from trinitycore.
their level is close to yours
That's wrong, green-level mobs are closer to the player than gray-level mobs. Also in general the chance decreases the lower the mob-level is (float chance = float(3 * lvldif * skilldif) / plevel;
). It is not logical to then suddenly increase the chance tenfold if the mob-level is below some level. And that is not done explicitly, but implicitly due to an integer underflow.
Some example calculation: Assume a level 60 player, a mob that is 1 level below gray-level, and the player is at 295/300 skill.
With the underflow the chance is calculated as lvldif = 255
, chance = 3 * 255 * 5 / 60 = 63.75
.
If the mob was one level higher, the chance would be calculated as lvldif = 0
, but it has a minimum of 3, so lvldif = 3
, chance = 3 * 3 * 5 / 60 = 0.75
, but it has a minimum of 1%, so chance = 1
.
Doesn't seem very logical to me to have an increase from 1% to over 60% by going down one level.
we don't really care about trashzerothcore
This is not the right place for childish insults.
you also did not provide any proof
In my opinion it is obvious from the code and the changes made in 60311e0, that the underflow is an unintended side-effect that was simply overlooked at that time (I don't blame them). But if you want more proof, I can give the same source as the issue that introduced the underflow:
https://typhoonandrew.wordpress.com/2008/01/08/how-to-raise-your-weapon-skill/ second bullet-point
"If you swing 100 times at a level 1 mob you’ll gain the same amount as swinging at a much higher level mob."
It says you gain the "same amount", not a "much greater amount".
from trinitycore.
Related Issues (20)
- DB/Misc: Update Maraudon Earth Song Falls portal coordinates HOT 1
- DB/Creature: Add missing movement flags to Warsong Cannon HOT 1
- DB/SAI: Sen'jin Village Dancing Trolls HOT 1
- Cata mapextractor won't work HOT 1
- DB/Creature: add mechanic_immune_mask to Franklin the Friendly HOT 1
- DB/Creature: Some demon npc might missing proper charm immunity
- 4.4.0 bug use gameobject start zones
- Error connecting to server - You were disconnected. (BLZ51914001) HOT 1
- DB/Draenor: Initial spawns for Auchindoun instance
- Size-Modifying Auras While Mounted HOT 1
- SMSG_ATTACKER_STATE_UPDATE 10.2.7
- Core/Warlock: Soul Link - wrong targets in combat log
- Core/Warlock: Soul Link shoud be usable on enslaved minion
- School of Fish above water surface HOT 3
- Core: Guild bank tab - "That name is reserved. Enter a new name." HOT 2
- Core/Character: .character changefaction shoud most likely not teleport character if it's DK
- DB/Misc: Fix Maraudon graveyard HOT 2
- Can't extract cata_classic maps. HOT 8
- Core: RemoveMovementImpairingAuras spells doesn't properly work HOT 1
- Core/Warlock: Relog /server restart shoud remove Demonic Circle: Teleport aura HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trinitycore.