Giter VIP home page Giter VIP logo

trinitycore / trinitycore Goto Github PK

View Code? Open in Web Editor NEW
9.1K 9.1K 5.9K 1.15 GB

TrinityCore Open Source MMO Framework (master = 10.2.6.54358, 3.3.5 = 3.3.5a.12340, wotlk_classic = 3.4.3.54261, cata classic = 4.4.0.54027)

Home Page: http://www.trinitycore.org

License: GNU General Public License v2.0

CMake 0.44% C 8.66% Shell 0.01% PHP 0.03% Perl 0.01% C++ 90.65% Objective-C 0.05% Batchfile 0.01% GDB 0.01% TSQL 0.09% Python 0.05% Dockerfile 0.01%
hacktoberfest linux mmorpg multi-platform multiplayer trinitycore wow

trinitycore's Introduction

logo TrinityCore (master)

Average time to resolve an issue Percentage of issues still open


Build Status

master 3.3.5 wotlk_classic
master Build Status 3.3.5 Build Status wotlk_classic Build Status
master Build status Build status Build status
master GCC Build status 3.3.5 GCC Build status wotlk_classic GCC Build status
master macOS arm64 Build status
Coverity Scan Build Status Coverity Scan Build Status

Introduction

TrinityCore is a MMORPG Framework based mostly in C++.

It is derived from MaNGOS, the Massive Network Game Object Server, and is based on the code of that project with extensive changes over time to optimize, improve and cleanup the codebase at the same time as improving the in-game mechanics and functionality.

It is completely open source; community involvement is highly encouraged.

If you wish to contribute ideas or code, please visit our site linked below or make pull requests to our Github repository.

For further information on the TrinityCore project, please visit our project website at TrinityCore.org.

Requirements

Software requirements are available in the wiki for Windows, Linux and macOS.

Install

Detailed installation guides are available in the wiki for Windows, Linux and macOS.

Reporting issues

Issues can be reported via the Github issue tracker.

Please take the time to review existing issues before submitting your own to prevent duplicates.

In addition, thoroughly read through the issue tracker guide to ensure your report contains the required information. Incorrect or poorly formed reports are wasteful and are subject to deletion.

Submitting fixes

C++ fixes are submitted as pull requests via Github. For more information on how to properly submit a pull request, read the how-to: maintain a remote fork. For SQL only fixes, open a ticket; if a bug report exists for the bug, post on an existing ticket.

Copyright

License: GPL 2.0

Read file COPYING.

Authors & Contributors

Read file AUTHORS.

Links

trinitycore's People

Contributors

aokromes avatar ariel- avatar carbenium avatar dduarte avatar dr-j avatar funjoker avatar jackpoz avatar joschiwald avatar kaelima avatar keader avatar killyana avatar machiavell1 avatar malcrom avatar mdx7 avatar meji46 avatar naddley avatar offl avatar qaston avatar runningnak3d avatar rushor avatar shauren avatar shocker avatar snapperry avatar star-lion avatar subv avatar treeston avatar vincent-michael avatar xurxogr avatar zenox92 avatar zxbiohazardzx avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

trinitycore's Issues

[Druid] Rip

Rip is not doing its normal damage.. its low

Version: 10821

Undeads should be immune to fear

What steps will reproduce the problem?

  1. Spec as unholy dk with pet and gargoyle
  2. Duel with lock, priest, warrior etc
  3. Tell them to cast fear on your pets

What is the expected output? What do you see instead?

Dk's pet are undead and undead should be immune to fear/sleep/charm (except fear spells like Turn Evil from paladin etc)

What revision of the Core are you using? On what operating system?

rev: 10868

[Mage] Incanter's Absorption and Chaos Bolt

'''What steps will reproduce the problem?'''

  1. Get a mage with this talent "Incanter's Absorption", and a Warlock with Chaos Bolt.
  2. Cast mana shield
  3. Cast Chaos Bolt on the mage with Mana Shield up.
  4. Watch your spell damage.

'''What is the expected output? What do you see instead?'''
The spell damage increases insanely

'''What revision of the Core are you using? On what operating system?'''
Rev 8ab453b
DB 36

Video: http://www.youtube.com/watch?v=Q6DCuJOEY_0&feature=player_embedded
Screenshot: http://img88.imageshack.us/img88/5436/24919616.jpg

Sorry for bad english.

Update date of some game event for 2011

Update date for some game_event for 2011
Database: TDB 335.11.35

{{{#!sql
-- Update start date of game event for 2011
-- Based on retail IG calendar
UPDATE game_event SET start_time = '2011-06-21 00:01:00' WHERE entry=1; -- Midsummer Fire Festival
UPDATE game_event SET start_time = '2011-12-15 06:00:00' WHERE entry=2; -- Winter Veil
UPDATE game_event SET start_time = '2011-02-06 00:01:00' WHERE entry=3; -- Darkmoon Faire - Terrokkar Forest
UPDATE game_event SET start_time = '2011-03-06 00:01:00' WHERE entry=4; -- Darkmoon Faire - Elwynn Forest
UPDATE game_event SET start_time = '2011-01-02 00:01:00' WHERE entry=5; -- Darkmoon Faire - Mulgore
UPDATE game_event SET start_time = '2011-01-23 00:01:00' WHERE entry=7; -- Lunar Festival
UPDATE game_event SET start_time = '2011-02-06 00:01:00' WHERE entry=8; -- Love is in the Air
UPDATE game_event SET start_time = '2011-04-24 00:01:00' WHERE entry=9; -- Noblegarden
UPDATE game_event SET start_time = '2011-05-01 00:01:00' WHERE entry=10; -- Childrens Week
UPDATE game_event SET start_time = '2011-09-06 00:01:00' WHERE entry=11; -- Harvest Festival
UPDATE game_event SET start_time = '2011-10-18 01:00:00' WHERE entry=12; -- Hallow's End
UPDATE game_event SET start_time = '2011-03-03 00:01:00' WHERE entry=23; -- Darkmoon Faire Building - Elwynn Forest
UPDATE game_event SET start_time = '2011-09-19 00:01:00' WHERE entry=52; -- Pirates Day
}}}

[NPC/Boss] Malygos

DB: TDB UP36

{{{#!sql
UPDATE creature_template SET difficulty_entry_1=31734,lootid=28859,type_flags=8,unit_flags=0,dynamicflags=0,flags_extra=0 WHERE entry=28859;
UPDATE creature_template SET lootid=31734,type_flags=8,unit_flags=0,dynamicflags=0,unit_class=2 WHERE entry=31734;
}}}

[NPC] Flesh Eating Worm

{{{
-- Remove XP at kill from Flesh Eating Worm
UPDATE creature_template SET flags_extra=flags_extra|64 WHERE entry=2462;
}}}

Pets not visible in Arena preperation

What steps will reproduce the problem?

  1. Enter arena with a groupmate who has a pet
  2. Look for the pet

What is the expected output? What do you see instead?
You cant see pets in the preperation phase anymore, this used to work before the new visibility system.

What revision of the Core are you using? On what operating system?
10863 Windows 7 64 bit
DB: UP36

DB - Enhance character_stats Table

The character_stats table will help even more if the following attributes could be added:

Melee Hit
Expertise
Spell Heal
Spell Hit
Spell Haste
Ranged Hit

This could facilitate the creation of web content, making game analysis and finding out faster the stats and how the effect the game and player.

This is not a defect, just some things that will greatly enhance the way we can find the stats.

What revision of the Core are you using? On what operating system?
Core 10800 Ubuntu 10.10 YTDB & TDB

Calendar System

TODO:

Write code for the calendar system; requires handling of several new packets.

  • Keep an eye on the calendar branch of the github repository
  • Invites should have a unique uint64 key; to persist, rekey the table on startup? Though I doubt the core will run out of uint64s to assign...
  • TODO: figure out what the unknown fields in the packets are; ask ralek/Phazerz/Zor? Phazerz did some work on calendar things in WCell, he may know
  • Keep efficiency HIGH. Calendar system should NOT be a drain on anything but memory

NPC transports are gone

  1. Go to any zeppelin and ships

Bug: There are no NPC's onboard!

Database : TDB_335.11.36
Trinity core : Latest
Addon : AH-Bot

Bug with PrevquestID in DB when have negative value

After two fixes for daily/weekly quests and all repeatable quest. I notice that now quests that should start after some other quest is taken dont show up.
To under stand me, i speak for quests that have in DB quest_template - PrevQuestId - If value < 0: Contains the parent quest id, that must be active before this quest can be started.
I think we missed something in core....

[NPC/Boss] Dungeon Boss Immunities [NON-blizzlike]

Wotlk dungeons are missing immunities masks - should be fixing it.

UPDATE `creature_template` SET `mechanic_immune_mask`=`mechanic_immune_mask`|604706780 WHERE `entry` IN (
-- Halls of stone:
27975,-- Maiden of Grief
31384,-- Maiden of Grief (1)
27977,-- Krystallus
31381,-- Krysyallus (1)
27978,-- Sjonnir the Ironshaper
31386,-- Sjonnir the Ironshaper (1)
-- Halls of Lightning:
28586,-- General Bjarngrim
31533,-- General Bjarngrim (1)
28587,-- Volkhan
31536,-- Volkhan (1)
28546,-- Ionar
31537,-- Ionar (1)
28923,-- Loken
31538,-- Loken (1)
-- The Nexus:
26731,-- Grand Magus Telestra
26930,-- Grand Magus Telestra (Blue - Frost)
26929,-- Grand Magus Telestra (Purple)
26928,-- Grand Magus Telestra (Red - Fire)
30510,-- Grand Magus Telestra (1)
30513,-- Grand Magus Telestra (Blue - Frost (1))
30512,-- Grand Magus Telestra (Purple (1))
30511,-- Grand Magus Telestra (Red - Fire (1))
26763,-- Anomalus
30529,-- Anomalus (1)
26974,-- Ormorok the Tree-Shaper
26723,-- Keristrasza
30540,-- Keristrasza (1)
26796,-- Commander Stoutbeard
30398,-- Commander Stoutbeard (1)
26798,-- Commander Kolurg
30397,-- Commander Kolurg (1)
-- The Oculus:
27654,-- Drakos the Interrogator
31558,-- Drakos the Interrogator (1)
27447,-- Varos Cloudstrider
31559,-- Varos Cloudstrider (1)
27655,-- Mage-Lord Urom
31560,-- Mage-Lord Urom (1)
27656,-- Ley-Guardian Eregos
31561,-- Ley-Guardian Eregos (1)
-- Azjol-Nerub:
28684,-- Krik'thir the Gatewatcher
31612,-- Krik'thir the Gatewatcher (1)
28921,-- Hadronox
31611,-- Hadronox (1)
29120,-- Anub'arak
31610,-- Anub'arak (1)
-- Ahn'kahet: The Old Kingdom:
29309,-- Elder Nadox
31456,-- Elder Nadox (1)
29308,-- Prince Taldaram
31469,-- Prince Taldaram (1)
29310,-- Jedoga Shadowseeker
31465,-- Jedoga Shadowseeker (1)
29311,-- Herald Volazj
31464,-- Herald Volazj (1)
30258,-- Amanitar
31463,-- Amanitar (1)
-- Utgarde Pinnacle:
26668,-- Svala Sorrowgrave
31810,-- Svala Sorrowgrave (1)
26687,-- Gortok Palehoof
30774,-- Gortok Palehoof (1)
26693,-- Skadi the Ruthless
30807,-- Skadi the Ruthless (1)
26861,-- King Ymiron
30788,-- King Ymiron (1)
-- Gundrak:
29304,-- Slad'ran
31370,-- Slad'ran (1)
29305,-- Moorabi
30530,-- Moorabi (1)
29307,-- Drakkari Colossus
31365,-- Drakkari Colossus (1)
29537,-- Drakkari Elemental
29306,-- Gal'darah
31368,-- Gal'darah (1)
29932,-- Eck the Ferocious
-- Halls of Reflection:
38112,-- Falric
38599,-- Falric (1)
38113,-- Marwyn
38603,-- Marwyn (1)
37226,-- Wrath of the Lich King
-- Pit of Saron:
36494,-- Forgemaster Garfrost
37613,-- Forgemaster Garfrost (1) 
36476,-- Ick
37627,-- Ick (1)
36477,-- Krick
37629,-- Krick (1)
36658,-- Scourgelord Tyrannus
36938,-- Scourgelord Tyrannus (1)
-- The Forge of Souls:
36497,-- Bronjahm
36498,-- Bronjahm (1)
36502,-- Devourer of Souls
37677);-- Devourer of Souls (1)

Fix players being displayed as offline in group view after being teleported to a different map

Fix players being displayed as offline in group view after being teleported to a different map

Happens due to player not being in world while he is teleported and sObjectMgr->GetPlayer only gets player who are currently in the world. Access like that should be take with caution but it should be safe as long as we only read information out of player. Might be better to create a new function in ObjectAccessor

Ported from OregonCore (TrinityCore 1 continuation)

[Core/Spells] Last T10 fix

CORE revision number : 2b42dca

Possible we forget to add sql?
Like:

{{{
DELETE FROM spell_script_names WHERE spell_id=70769 AND ScriptName='spell_gen_divine_storm_cd_reset';
INSERT INTO spell_script_names (spell_id,ScriptName) VALUES
(70769, 'spell_gen_divine_storm_cd_reset');
}}}

[Battleground] Fix re-enter into battleground after disconnect

Fixes re-entering into battleground after disconnect

Caused due to the line "if (instanceId && !sInstanceSaveMgr->GetInstanceSave(instanceId))" in Player.cpp:LoadFromDB. Got broken in ~4800 when QAston added map managment improvements :P

The reason why it wont ever work is that fact that if player d/c they are in an instance (bg) but there is no instance save because that is only saved for dungeons and raids.

Ported from OregonCore (TrinityCore 1 continuation)

SPELL - Flaming Arrow - 54897

  1. Grab the Quest - http://www.wowhead.com/quest=12851
  2. Try to shoot any of the objectives.

What is the expected output? What do you see instead?
It should make damage to the targets. Instead it just creates fire in a AoE effect. Does not make any damage.

What revision of the Core are you using? On what operating system?
Ubuntu 10.10 With Core 10800

Spell script hooks to be implemented.

This is a list of script hooks planned to be added in future. Feel free to post suggestions about it.
SpellScript:
DoCheckCast - allows to create a custom requirement for spell to be casted
DoCheckTarget - allows to create a custom requirement for targets of a spell
DoEditTargetList - allows to edit already created list, for example to change order of targets
OnPrepare - hook on Spell::Prepare
OnCast - hook on Spell::Cast
OnFinish - hook on Spell::Finish
AuraScript:
DoCheckAreaTarget - allows to create a custom requirement for targets of area auras
OnProc - hook somewhere in ProcDamageAndSpellFor for whole aura object
OnEffectProc - hook somewhere in ProcDamageAndSpellFor, specific for aura effect
OnApply - Hook on Aura::HandleAuraSpecificMods
OnRemove - Hook on Aura::HandleAuraSpecificMods

File descriptor leak on Unix

Follup ticket from http://code.google.com/p/trinitycore/issues/detail?id=3707

TC is known to leak file descriptors, most likely from TCP connections, on several Unix distributions.

Dead sockets can be identified by the lsof tool and present themselves as "can't identify protocol"

{{{

lsof -n | grep worldserv | less

worldserv 28215 wow 777u sock 0,5 0t0 3550789221 can't identify protocol
worldserv 28215 wow 778u sock 0,5 0t0 3550787605 can't identify protocol
worldserv 28215 wow 779u IPv4 3783695856 0t0 TCP 99.99.99.99:8085->99.99.99.99:49198 (ESTABLISHED)
}}}

Counting the dead sockets that piled up during runtime:

{{{
lsof -n | grep worldserv | grep TCP | wc -l
}}}

Only workaround is increasing the fd limit via

{{{
ulimit -n
}}}

Please post your findings about this issue in this ticket.

[10918][Instance] Pit of Saron

{{{#!sql
DELETE FROM creature WHERE id IN (36610,36731,36477,36658,31260); -- Delete Temp Trigger Spawns

-- DB Data (souce: SNIFF)
UPDATE creature_template SET exp=2,minlevel=80,maxlevel=80,unit_flags=0x02008000,faction_A=14,faction_H=14,flags_extra=flags_extra|0x80 WHERE entry=37670; -- Frostblade
UPDATE creature_template SET exp=2,minlevel=80,maxlevel=80,flags_extra=flags_extra|0x80 WHERE entry=36610; -- Exploding Orb
UPDATE creature_template SET exp=2,minlevel=80,maxlevel=80,scale=1.1,flags_extra=flags_extra|0x80 WHERE entry=36731; -- Icy Blast
UPDATE creature_template SET speed_run=1.857143,speed_walk=3.2,unit_flags=0x00000040,faction_A=14,faction_H=14,baseattacktime=2000,equipment_id=1872 WHERE entry IN (36658,36938); -- Scourgelord Tyrannus
UPDATE creature_template SET speed_run=1.5873,speed_walk=2,unit_flags=0x00000040 WHERE entry=36661; -- Rimefang
UPDATE creature_template SET flags_extra=flags_extra|0x80 WHERE entry=36495; -- Forgemaster Putridus Invisible Stalker
UPDATE creature_template SET VehicleId=560 WHERE entry=37626; -- Iceborn Protodrake (1)

-- SAI for Plagueborn Horror
SET @entry := 36879;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,2,5000,5000,10000,10000,11,69581,0,0,0,0,0,5,0,0,0,0,0,0,0, 'Cast Pustulant Flesh on Random Target (Non-Heroic)'),
(@entry,0,1,0,0,0,100,4,5000,5000,10000,10000,11,70273,0,0,0,0,0,5,0,0,0,0,0,0,0, 'Cast Pustulant Flesh on Random Target (Heroic)'),
(@entry,0,2,0,0,0,100,6,8000,8000,8000,8000,11,70274,0,0,0,0,0,5,0,0,0,0,0,0,0, 'Cast Toxic Waste on Random Target'),
(@entry,0,3,0,2,0,100,6,15,15,0,0,11,69582,0,0,0,0,0,1,0,0,0,0,0,0,0, 'Cast Blight Bomb self at 15pct Health');

-- SAI for Hungering Ghoul
SET @entry := 37711;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,6,4000,6000,8000,12000,11,70393,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Devour Flesh on current Target');

-- SAI for Deathwhisper Shadowcaster
SET @entry := 37712;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,2,100,100,3000,3000,11,70386,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Shadow Bolt on current Target (Non-Heroic)'),
(@entry,0,1,0,0,0,100,4,100,100,3000,3000,11,70387,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Shadow Bolt on current Target (Heroic)');

-- SAI for Deathwhisper Torturer
SET @entry := 37713;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,6,10000,10000,10000,10000,11,70392,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Black Brand on current Target'),
(@entry,0,1,0,0,0,100,6,6000,6000,13000,13000,11,70391,0,0,0,0,0,5,0,0,0,0,0,0,0, 'Cast Curse of Agony on Random Target');

-- SAI for Ymirjar Wrathbringer
SET @entry := 36840;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,2,7000,7000,8000,8000,11,69603,0,0,0,0,0,5,0,0,0,0,0,0,0, 'Cast Blight on Random Target (Non-Heroic)'),
(@entry,0,1,0,0,0,100,4,7000,7000,8000,8000,11,70285,0,0,0,0,0,5,0,0,0,0,0,0,0, 'Cast Blight on Random Target (Heroic)');

-- SAI for Stonespine Gargoyle
SET @entry := 36896;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,2,1000,1000,5000,5000,11,69520,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Gargoyle Strike on current Target (Non-Heroic)'),
(@entry,0,1,0,0,0,100,4,1000,1000,5000,5000,11,70275,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Gargoyle Strike on current Target (Heroic)'),
(@entry,0,2,0,2,0,100,6,10,10,0,0,11,69575,0,0,0,0,0,1,0,0,0,0,0,0,0, 'Cast Stoneform self at 10pct Health');

-- SAI for Wrathbone Sorcerer
SET @entry := 37728;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,2,3000,3000,8000,8000,11,75330,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Shadow Bolt on current Target (Non-Heroic)'),
(@entry,0,1,0,0,0,100,4,3000,3000,8000,8000,11,75331,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Shadow Bolt on current Target (Heroic)');

-- SAI for Wrathbone Coldwraith
SET @entry := 36842;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,2,100,100,3000,3000,11,69573,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Frostbolt on current Target (Non-Heroic)'),
(@entry,0,1,0,0,0,100,4,100,100,3000,3000,11,70277,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Frostbolt on current Target (Heroic)'),
(@entry,0,2,0,0,0,100,2,9000,9000,15000,15000,11,69574,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Freezing Circle on current Target (Non-Heroic)'),
(@entry,0,3,0,0,0,100,4,9000,9000,15000,15000,11,70276,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Freezing Circle on current Target (Heroic)');

-- SAI for Deathwhisper Necrolyte
SET @entry := 36788;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,2,100,100,3000,3000,11,69577,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Shadow Bolt on current Target (Non-Heroic)'),
(@entry,0,1,0,0,0,100,4,100,100,3000,3000,11,70270,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Shadow Bolt on current Target (Heroic)'),
(@entry,0,2,0,0,0,100,2,9000,9000,24000,24000,11,69578,0,0,0,0,0,5,0,0,0,0,0,0,0, 'Cast Conversion Beam on Random Target (Non-Heroic)'),
(@entry,0,3,0,0,0,100,4,9000,9000,24000,24000,11,70269,0,0,0,0,0,5,0,0,0,0,0,0,0, 'Cast Conversion Beam on Random Target (Heroic)');

-- SAI for Fallen Warrior
SET @entry := 36841;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,6,5000,5000,7000,8000,11,69579,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Arcing Slice to current Target'),
(@entry,0,1,0,0,0,100,6,15000,15000,22000,22000,11,61044,0,0,0,0,0,1,0,0,0,0,0,0,0, 'Cast Demoralizing Shout'),
(@entry,0,2,0,0,0,100,6,22000,22000,25000,25000,11,69580,0,0,0,0,0,1,0,0,0,0,0,0,0, 'Cast Shield Block');

-- SAI for Fallen Warrior 2
SET @entry := 38487;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,6,5000,5000,7000,8000,11,69579,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Arcing Slice to current Target'),
(@entry,0,1,0,0,0,100,6,15000,15000,22000,22000,11,61044,0,0,0,0,0,1,0,0,0,0,0,0,0, 'Cast Demoralizing Shout'),
(@entry,0,2,0,0,0,100,6,22000,22000,25000,25000,11,69580,0,0,0,0,0,1,0,0,0,0,0,0,0, 'Cast Shield Block');

-- SAI for Ymirjar Skycaller
SET @entry := 31260;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,6,4000,4000,8000,8000,11,70292,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Glacial Strike on current Target'),
(@entry,0,1,0,2,0,100,6,50,50,0,0,11,70291,0,0,0,0,0,5,0,0,0,0,0,0,0, 'Cast Frostblade on Random Target at 50pct Health');

-- SAI for Frostblade
SET @entry := 37670;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,6,1000,1000,0,0,11,70306,0,0,0,0,0,2,0,0,0,0,0,0,0, 'Cast Frostblade self');

-- SAI for Ymirjar Deathbringer
SET @entry := 36892;
UPDATE creature_template SET AIName= 'SmartAI',ScriptName="" WHERE entry=@entry;
DELETE FROM smart_scripts WHERE source_type=0 AND entryorguid=@entry;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(@entry,0,0,0,0,0,100,2,4000,4000,8000,8000,11,69528,0,0,0,0,0,5,0,0,0,0,0,0,0, 'Cast Empowered Shadow Bolt on Random Target (Non-Heroic)'),
(@entry,0,1,0,0,0,100,4,4000,4000,8000,8000,11,70281,0,0,0,0,0,5,0,0,0,0,0,0,0, 'Cast Empowered Shadow Bolt on Random Target (Heroic)');
}}}

[DK] Raise Ally

1.Party up with someone
2.Let him die
3.Cast Raise Ally on him

What is the expected output? What do you see instead?
Dead friendly grouped target is supposed to raise as a kewl and strong
ghoul for 5 minutes under HIS control. Instead, nothing happens. The skill
goes in Cooldown, but the target remains dead and nothing really happens.

http://www.wowhead.com/spell=61999
Raises the corpse of a raid or party member to fight by your side. The
player will have control over the Ghoul for 5 min.

fix Mangos
https://github.com/rsa/mangos/commit/7cbb2fcb3fc0b51139a2cad557ba2d58e4b5d6df
https://github.com/rsa/scriptdev2/commit/ff1db75e8716b04b7aee8b5da807a84919b43569

for part 2
https://github.com/rsa/mangos/commit/96ec786b4071ce1ce6b9415e07aa5c4facd91b11

for part 3
https://github.com/rsa/mangos/commit/3e89e2633b68e39dae9a174d6c7b93e8373ae305

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

world_script_texts.sql

10840 (d1040972f9c0)
''world_script_texts.sql'' file: line 2593 are closed:
''(33271,-1603299,'General Vezax roars and surges with dark might!',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,0,3,0,0,'General Vezax - Emote4');''

'''Fix:'''
''(33271,-1603299,'General Vezax roars and surges with dark might!',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,0,3,0,0,'General Vezax - Emote4'),''

Crucial Global cooldown bug

What steps will reproduce the problem?

  1. Get any class that can "shoot" with a wand
  2. Write a macro with the lines /cast !shoot /cast anyinstantspell (For example Icelance )
  3. Shoot with the wand and at the moment where the missile of the shoot is flying start spamming the macro.

What is the expected output? What do you see instead?
Shoot with the wand and at the moment where the missile of the shoot is flying start spamming the macro.
What revision of the Core are you using? On what operating system?
10863 Windows 7 64 bit
DB 36

[NPC/Boss] Scourgelord Tyrannus is not selectable

Before you engage him, he can be targeted, but no longer after you get aggro, must be a script issue. but I did check others Boss scripts and have the same structure and their can be targeted after you get aggro,

WORKAROUND DB :

-- set FLAG_UNK_6 to Scourgelord Tyrannu

UPDATE creature_template SET unit_flags=64 WHERE entryIN (36658,3665801);

Database : TDB_335.11.36_10818
Trinity core : 10866
Addon : None

Fix Quest "Words of Power"

TDB 335.11.36
Quest "Words of Power" - Npcs cant be target....
UPDATE creature_template SET unit_flags='768' WHERE creature_template.entry=26073;
UPDATE creature_template SET unit_flags='768' WHERE creature_template.entry=26076;

Duplicated Grobbulus

CORE revision number : 10868
Database: TDB 335.11.35
Patches: None

Sometimes Grobbulus (in Naxxramas) appears twice in world, although he is only once in DB. .npc info shows that both copies have same GUID. Problem hadn't occured before pathing for Grobbulus was added in TDB and seems to disappear when I remove the pathing.

Dungeon Finder doesn't work

  1. Open Dungeon Finder
  2. Select role and click "Find group"
  3. Nothing happens

Running TrinityCore Rev: 10937+ Release Hash: 3f0ebd2+ (Unix, little-endian) on Ubuntu.
DB is UP36 clean.

Dungeon Finder doesn't work

  1. Open Dungeon Finder
  2. Select role and click "Find group"
  3. Nothing happens

Running TrinityCore Rev: 10937+ Release Hash: 3f0ebd2+ (Unix, little-endian) on Ubuntu.
DB is UP36 clean.

[Quest/Icecrown/Pit of Saron] The Path to the Citadel

Bug : The NPC alliance/hord slave can't be free to complete the quest "The path to the citadel".
Creature :

Web link :

Database : TDB_335.11.36_10818
Trinity core : 10866
Addon : None

When you clik on their chaines (ball and chain) nothing happens but they should be free and complete the quest

[Event/Winter Veil] Winter Veil mail rewards

DB: TDB 36
Bug: No mail rewards from quest Treats for Greatfather Winter,Stolen Winter Veil Treats(alliance),Metzen the Reindeer
Tested: Yes
Fix:
{{{

!div style="font-size: 80%"

Code highlighting:
{{{#!sql
-- Reward from Treats for Greatfather Winter (horde)
SET @mail:=118; -- Set in DBC
UPDATE quest_template SET RewMailTemplateId=@mail, RewMailDelaySecs=86400 WHERE entry IN (6962); -- Set mail delivery
DELETE FROM mail_loot_template WHERE entry=@mail;
INSERT INTO mail_loot_template (entry,item,ChanceOrQuestChance,lootmode,groupid,mincountOrRef,maxcount) VALUES
(@mail,17685,100,1,0,1,1); -- Attach item to mail

-- Reward from Treats for Greatfather Winter (alliance)
SET @mail:=102; -- Set in DBC
UPDATE quest_template SET RewMailTemplateId=@mail, RewMailDelaySecs=86400 WHERE entry IN (7025); -- Set mail delivery
DELETE FROM mail_loot_template WHERE entry=@mail;
INSERT INTO mail_loot_template (entry,item,ChanceOrQuestChance,lootmode,groupid,mincountOrRef,maxcount) VALUES
(@mail,17685,100,1,0,1,1); -- Attach item to mail

-- Reward from Stolen Winter Veil Treats (alliance)
SET @mail:=117; -- Set in DBC
UPDATE quest_template SET RewMailTemplateId=@mail, RewMailDelaySecs=86400 WHERE entry IN (7042); -- Set mail delivery
DELETE FROM mail_loot_template WHERE entry=@mail;
INSERT INTO mail_loot_template (entry,item,ChanceOrQuestChance,lootmode,groupid,mincountOrRef,maxcount) VALUES
(@mail,17712,100,1,0,1,1); -- Attach item to mail

-- Reward from Metzen the Reindeer (alliance)
SET @mail:=161; -- Set in DBC
UPDATE quest_template SET RewMailTemplateId=@mail, RewMailDelaySecs=86400 WHERE entry IN (8762); -- Set mail delivery
DELETE FROM mail_loot_template WHERE entry=@mail;
INSERT INTO mail_loot_template (entry,item,ChanceOrQuestChance,lootmode,groupid,mincountOrRef,maxcount) VALUES
(@mail,21216,100,1,0,1,1); -- Attach item to mail

-- Reward from Metzen the Reindeer (horde)
SET @mail:=122; -- Set in DBC
UPDATE quest_template SET RewMailTemplateId=@mail, RewMailDelaySecs=86400 WHERE entry IN (8746); -- Set mail delivery
DELETE FROM mail_loot_template WHERE entry=@mail;
INSERT INTO mail_loot_template (entry,item,ChanceOrQuestChance,lootmode,groupid,mincountOrRef,maxcount) VALUES
(@mail,21216,100,1,0,1,1); -- Attach item to mail }}}
}}}

[Item/49278] Goblin Rocket Pack

The item Goblin Rocket Pack (49278 http://www.wowhead.com/item=49278
Is not been removed from inventory in ICC.

Should be removed when:

  1. Go outside of ICC in any way except dead BUT if you revive outside of ICC it is removed.
  2. Finish the Airship Battle

A quote from wowhead is excatly what i tested

"Actually, the ability only works at the Gunship itself.

The item will not disappear while you remain in Icecrown Citadel if you die wearing it and procede to the next boss. Only when you physically walk or port out of the instance will you lose it."

The way is working here is that you CAN get out of ICC and the item still is with you. Users use it in BG or outside in several zones.

What revision of the Core are you using? On what operating system?
Ubuntu 10.10 / Core 10800 / YTDB & TDB /

[Core/Vehicles] fix enter by aura (logic error)

CORE revision number : 957c69d
Database: TDB 335.11.36
Patches: None

diff -r 6bc9dd64c1fd src/server/game/Entities/Vehicle/Vehicle.cpp
--- a/src/server/game/Entities/Vehicle/Vehicle.cpp Sat Jan 01 11:05:33 2011 +0200
+++ b/src/server/game/Entities/Vehicle/Vehicle.cpp Sat Jan 01 19:09:20 2011 +0200
@@ -283,11 +283,15 @@
if (unit->GetVehicle() != this)
return false;

  • //CrashFix. How it happend??
  • if (!me->IsInWorld())
  •    return false;
    
    SeatMap::iterator seat;
    if (seatId < 0) // no specific seat requirement
    {
    for (seat = m_Seats.begin(); seat != m_Seats.end(); ++seat)
  •        if (!seat->second.passenger && (!(byAura && seat->second.seatInfo->CanEnterOrExit()) || (byAura && seat->second.seatInfo->IsUsableByAura())))
    
  •        if (!seat->second.passenger && ((!byAura && seat->second.seatInfo->CanEnterOrExit()) || (byAura && seat->second.seatInfo->IsUsableByAura())))
             break;
    
     if (seat == m_Seats.end()) // no available seat
    

Traps are visible to all classes

What steps will reproduce the problem?
1.Get a hunter and any class except for rogues
2.Put a trap down with the hunter

What is the expected output? What do you see instead?
Only rogues should be able to see traps but now every class sees them.

What revision of the Core are you using? On what operating system?
10863

Please provide any additional information below.
This came up with the new Visibility system.

bugs with ID instance

there are strange bugs in all raids, after restart server ppl said me they go to onyxia lair and kill the main boss and they became ID for TOC 10 or another dungeon or raid, i tested toc 10 normal , i have gained ID for toc and after server crashed, my id for toc has been deleted and i have had id for one dungeon in hellfire citadel

revision 8fc4d7eaac
linux ubuntu 64bit

in server.log i can see some this errors : _LoadBoundInstances: player Nickname(number) has bind to not existed or not dungeon map 0

Thread going into endless loop once the TCP connection limit is reached

Follup ticket from http://code.google.com/p/trinitycore/issues/detail?id=3707

This is a different issue as described in #15, but can be the result of the fd leak.

Once the file descriptor limit for TCP connections is reached one TC thread (most likely networking) starts looping and the server becomes almost inaccessible.

Hooking up strace to the looping thread showed the following:

{{{

strace -p 28226

epoll_wait(15, {{EPOLLIN, {u32=22, u64=22}}}, 1, 0) = 1
accept(22, 0, NULL) = -1 EMFILE (Too many open files)
epoll_ctl(15, EPOLL_CTL_MOD, 22, {EPOLLIN|EPOLLONESHOT, {u32=22, u64=22}}) = 0
epoll_wait(15, {{EPOLLIN, {u32=22, u64=22}}}, 1, 0) = 1
[.. endless spam with the same lines ..]
}}}

How it should work:

Once the limit is reached TC should simply discard the incoming connection until other connections get closed and free up resources below the limit.

[Command/Custom] Modify Scale for Creatures

What steps will reproduce the problem?

  1. select any creature, npc, mob or boss
  2. execute the gm command modify scale 10 for example
  3. the command will not work

What is the expected output? What do you see instead?
Like Mangos, the command should also affect creatures in general. VERY useful for custom fun events which need to adjust just for a moment creature size.

What revision of the Core are you using? On what operating system?
Core 10800 Ubuntu 10.10 YTDB & TDB

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.