not really an issue, just a question....how do i encode a float?

we prefer to use github tarballs in debian

I am writing a lambda function in aws using node.js to ssh to an ec2 instance. I want to use public key private key pairs so I don't have to embed a password in the code. I'm using simple-ssh as a wrapper library to ssh2 which in turn calls asn1 reader.js to parse the private key to verify its validity. There appears to be a problem with indexing through the first 8 bytes of the key which manifests itself in the method readString. The first 8 bytes are as follows: 30 82 04 bd 02 01 00 30. By the time readSting is called, the offset variable is 7 which causes the code to read the 8th byte which is 0x30. readString compares this value with the TAG value which is 0x02 and throws an error stating that the key is invalid because 0x30 doesn't match 0x02. If I load my private key into this website https://lapo.it/asn1js/ it can parse the key without fail. I also found some javascript code that also is consistent with how the first 8 bytes are indexed and successfully parses the key. I think that the offsets are being handled incorrectly in the code.

I'm trying to use a library called node-rsa which uses node-asn1 and it's giving me this error:

Uncaught InvalidAsn1Error: Expected 0x2: got 0x24

I basically have a private key PEM string that works for node-rsa, then I put it in a <textarea>, then I get it back out of the textarea using $('textarea').text() and now it doesn't work with node-rsa, giving me that error.

For example:

      var NodeRSA = require("node-rsa");
      var rsa = new NodeRSA();
      rsa.generateKeyPair(256);
      console.log(rsa.getPrivatePEM())

      $("#public_key").text(rsa.getPrivatePEM());
      console.log($("#public_key").text()); // looks the same as the first output.
      rsa2 = new NodeRSA();
      rsa2.loadFromPEM($("#public_key").text()); // InvalidAsn1Error

What's it mean? Is the new line character format changed or something?

https://github.com/mcavage/node-asn1/blob/master/lib/ber/writer.js#L180

Probably 'octet' instead of 'id'.

How to solve this issue?

{ [InvalidAsn1Error: Expected 0x2: got 0x0] name: 'InvalidAsn1Error', message: 'Expected 0x2: got 0x0' }

/var/www/courious/node_modules/net-snmp/index.js:918
var req = this.unregisterRequest (message.pdu.id);
^
TypeError: Cannot read property 'pdu' of undefined
at Session.onMsg (/var/www/courious/node_modules/net-snmp/index.js:918:43)
at Socket.EventEmitter.emit (events.js:98:17)
at UDP.onMessage (dgram.js:440:8)

This error message is displayed in an attempt to capture SNMP information from a printer. It would be wrong of LIB ASN1 or LIB net-snmp that makes use of this?

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@root/asn1/-/asn1-1.0.0.tgz
npm ERR! 404
npm ERR! 404 '@root/[email protected]' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)

https://www.npmjs.com/package/asn1

The README mentions ftp://ftp.rsa.com/pub/pkcs/ascii/layman.asc
The link seems to be broken.
Please could you indicate another link ?
Thanks.

https://github.com/mcavage/node-asn1/blob/master/lib/ber/reader.js#L187

Because readString() converts the buffer to a UTF-8 string, there is an irreversible corruption, when the string is converted back to a Buffer via Buffer.from(str, 'binary').

It seems that here is a mistype:

  } else {
    throw new InvalidAsn1ERror('Length too long (> 4 bytes)');
  }

InvalidAsn1ERror -> InvalidAsn1Error

Hey from Node.js here!,

Starting on Node 10 this package will emit deprecation warnings. See this guide on what you should do in order to migrate to Buffer.alloc/Buffer.from.

See nodejs/node#19079 for discussion around this change and why we can't make new Buffer work

Hi, want to get confirmation from someone is it true the lib does not support encoding of a bit string? Thanks

In package.json, using

"dependencies": {
    "asn1": "https://github.com/mcavage/node-asn1"
}

results in:

% npm install [email protected]
npm WARN deprecated [email protected]: use uuid module instead
npm ERR! not a package /tmp/npm-9658-QcJxFsXz/github.com/mcavage/node-asn1
npm ERR! Error: ENOENT, open '/tmp/npm-9658-QcJxFsXz/github.com/mcavage/node-asn1-unpack/package.json'

1. when reading Enumeration , it's write
   Catched error: InvalidAsn1Error: Expected 0xa: got 0xa0
   but we know Enumeration != 0xa && Enumeration == 0xa0

2. when reading DER, must read not base64, but decoded base64:

let crtInPemBfr = Buffer.from(crtPem)
let crtInHexBfr = Buffer.from(crtInPemBfr , 'base64')
let reader = new asn1.BerReader(crtInHexBfr )

I am parsing the packets from hex-dump using pcap-parser and passing the packet buffer to asn onMsg()
But this buffer is not valid for processing.

Any help will be appreciated.

The values of identifier octet types GeneralString, UniversalString, CharacterString and BMPString are wrong according to my comparisons with these following sources:
BER encoding
BerTag.java at jASN1

See: https://github.com/digitalbazaar/forge
Specifically: https://github.com/digitalbazaar/forge/blob/master/js/asn1.js

The method readString of ASN1.Reader returns an empty string whenever an empty string is encountered, regardless of whether retbuf is set to true or not, causing unexpected behavior in applications that rely on a Buffer being returned.

Here's a small patch that fixes the issue;

diff --git a/lib/ber/reader.js b/lib/ber/reader.js
index 9745dc3..46fba61 100644
--- a/lib/ber/reader.js
+++ b/lib/ber/reader.js
@@ -171,7 +171,7 @@ Reader.prototype.readString = function(tag, retbuf) {
   this._offset = o;

   if (this.length === 0)
-    return '';
+    return retbuf ? new Buffer(0) : '';

   var str = this._buf.slice(this._offset, this._offset + this.length);
   this._offset += this.length;

Specifying your license in package.json makes it a lot easier for your users to find and comply with GNU Affero licenses.

Also giving licenses (an array of objects with type and url keys) helps users whose legal departments request both the license name and the text. See this example from async:

  "licenses": [{
    "type": "MIT",
    "url": "https://github.com/caolan/async/raw/master/LICENSE"
  }]

Though licenses isn't specified in the npm package.json spec, it is supported by the NPM site, as you'll see if you check async's NPM page.

Thanks!

I think there is a problem in the readOID function when a value in the OID is higher than 2^31. It is returning negative numbers. For example:

var ber = require("asn1").Ber;

// Buffer contains OID 1.3.6.1.4.1.14988.1.1.5.1.1.19.2887117176 
var data = new Buffer([6,18,43,6,1,4,1,245,12,1,1,5,1,1,19,138,224,215,210,120]);
var reader = new ber.Reader (data)
console.log(reader.readOID());
// prints "1.3.6.1.4.1.14988.1.1.5.1.1.19.-1407850120"

A possible fix would be casting each value to unsigned integer before storing. I.e replacing values.push(value) with values.push(value >>> 0)

https://github.com/mcavage/node-asn1/blob/master/lib/ber/writer.js#L239

This line throws "start is not defined"

Currently I have to access underscore-prefixed internals in order to write a pre-asn.1-formatted buffer to an existing asn1 Writer object. It would be nice to have a way to do writer.writeBuffer() without the tag requirement.