Giter VIP home page Giter VIP logo

yame's People

Contributors

snyk-bot avatar trixt0r avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar

Forkers

zjl1985

yame's Issues

Unit Tests

Due to the lack of unit tests and for any component, directive, utility, module, service, etc., the projects has to have a solid unit test base.

No new features or refactorings will be done, until every source file, except interfaces and module declarations, own a *.spec.ts file.

Refactoring

The current implementation has many weakpoints and incomplete/buggy features, especially in terms of map entity data binding and splitting between renderer and main process.
To prevent unnecessary work, which has already been done in other frameworks, the core implementation has to be switched to angular2.

Following steps should be done in a first run:

  • Drop Backbone in favor of TypeScript features and underscore in favor of lodash
  • Drop Semantic UI in favor of bootstrap 4 or metroui
  • Codebase on top of angular2 and pixi.js

Run error in macOS

I deleted the menu part of ElectronModule and no error was reported.
Below is the error message：

Unhandled Promise rejection: Could not call remote method 'setApplicationMenu'. Check that the method signature is correct. Underlying error: Invalid menu
Underlying stack: TypeError: Invalid menu
    at Function.a.setApplicationMenu (node:electron/js2c/browser_init:81:4477)
    at /Users/yuukisyaku/Downloads/yame-master/node_modules/@electron/remote/dist/src/main/server.js:463:71
    at IpcMainImpl.<anonymous> (/Users/yuukisyaku/Downloads/yame-master/node_modules/@electron/remote/dist/src/main/server.js:322:27)
    at IpcMainImpl.emit (node:events:394:28)
    at Object.<anonymous> (node:electron/js2c/browser_init:161:10774)
    at Object.emit (node:events:394:28)
 ; Zone: <root> ; Task: Promise.then ; Value: Error: Could not call remote method 'setApplicationMenu'. Check that the method signature is correct. Underlying error: Invalid menu
Underlying stack: TypeError: Invalid menu
    at Function.a.setApplicationMenu (node:electron/js2c/browser_init:81:4477)
    at /Users/yuukisyaku/Downloads/yame-master/node_modules/@electron/remote/dist/src/main/server.js:463:71
    at IpcMainImpl.<anonymous> (/Users/yuukisyaku/Downloads/yame-master/node_modules/@electron/remote/dist/src/main/server.js:322:27)
    at IpcMainImpl.emit (node:events:394:28)
    at Object.<anonymous> (node:electron/js2c/browser_init:161:10774)
    at Object.emit (node:events:394:28)

    at /Users/yuukisyaku/Downloads/yame-master/node_modules/@electron/remote/dist/src/main/server.js:466:25
    at IpcMainImpl.<anonymous> (/Users/yuukisyaku/Downloads/yame-master/node_modules/@electron/remote/dist/src/main/server.js:322:27)
    at IpcMainImpl.emit (node:events:394:28)
    at Object.<anonymous> (node:electron/js2c/browser_init:161:10774)
    at Object.emit (node:events:394:28) Error: Could not call remote method 'setApplicationMenu'. Check that the method signature is correct. Underlying error: Invalid menu
Underlying stack: TypeError: Invalid menu
    at Function.a.setApplicationMenu (node:electron/js2c/browser_init:81:4477)
    at /Users/yuukisyaku/Downloads/yame-master/node_modules/@electron/remote/dist/src/main/server.js:463:71
    at IpcMainImpl.<anonymous> (/Users/yuukisyaku/Downloads/yame-master/node_modules/@electron/remote/dist/src/main/server.js:322:27)
    at IpcMainImpl.emit (node:events:394:28)
    at Object.<anonymous> (node:electron/js2c/browser_init:161:10774)
    at Object.emit (node:events:394:28)

    at /Users/yuukisyaku/Downloads/yame-master/node_modules/@electron/remote/dist/src/main/server.js:466:25
    at IpcMainImpl.<anonymous> (/Users/yuukisyaku/Downloads/yame-master/node_modules/@electron/remote/dist/src/main/server.js:322:27)
    at IpcMainImpl.emit (node:events:394:28)
    at Object.<anonymous> (node:electron/js2c/browser_init:161:10774)
    at Object.emit (node:events:394:28)
a.onUnhandledError @ zone.js:1063
G @ zone.js:1088
a.microtaskDrainDone @ zone.js:1082
W @ zone.js:589
Promise.then (async)
m @ zone.js:565
J @ zone.js:1229
t @ zone.js:1390
getFiles @ plugin.manager.ts:37
initialize @ plugin.manager.ts:83
6121 @ main.ts:32
r @ bootstrap:19
(anonymous) @ common|sync:9
r.O @ chunk loaded:23
(anonymous) @ common|sync:9
i @ jsonp chunk loading:71
(anonymous) @ main.js:1

Plugin pipeline

A plugin pipeline on the electron as well as in the client part has to be implemented.
Plugins should have access to every part of the application.

More details have to be defined.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.