trolit / patchron Goto Github PK

Case 1

from:

return this.item?.total ? format(this.item.total) : 0;

to:

return format(this.item?.total || 0);

Case 2

from:

var direction;
if(x > 100){
  direction = 1;
} else {
  direction = -1;
}

to:

var direction = (x > 100) ? 1 : -1;

Case 3

from:

if(v){
  var x = v;
} else {
  var x = 10;
}

to:

var x = v || 10;

Use e.g. words collection to suggest words that were potentially misspelled?

⚠️

• Would require ability to store words that should be ignored (via local file or DB)
• What are the odds for custom names?

try to implement rule that enforces to reference element from array via index only once.

var f = document.getElementById('mainform');
var inputs = f.getElementsByTagName('input');

// wrong
for(var i=0,j=inputs.length;i<j;i++){
  if(inputs[i].className === 'mandatory' &&
     inputs[i].value === ''){
    inputs[i].style.borderColor = '#f00';
    inputs[i].style.borderStyle = 'solid';
    inputs[i].style.borderWidth = '1px';
  }
}

// correct
for(var i=0,j=inputs.length;i<j;i++){
  const input = inputs[i];

  if(input.className === 'mandatory' &&
    input.value === ''){
    input.style.borderColor = '#f00';
    input.style.borderStyle = 'solid';
    input.style.borderWidth = '1px';
  }
}

⚠️
Patch limited information problem :(

Extend MarkedComments Rule and implement rule for HTML

or

rework MarkedCommentsRule to accept comment blocks

suggest minimum length for const/let/var variable names

// case1
const [ a, b ] = [ 1, 2 ];

// case1.1
const [ a, b, c, d, e, f ] = [ 
   1,
   2,
   3,
   4,
   ...
]

// case2
const { a, b } = { a: 1, b: 2 };

// case3
const a = 1;
const b = 2;

// case4
const a = 1,
      b = 2;

var cow = new Object();
cow.colour = 'brown';
cow.commonQuestion = 'What now?';
cow.moo = function(){
  console.log('moo');
}
cow.feet = 4;
cow.accordingToLarson = 'will take over the world';

against

var cow = {
  colour:'brown',
  commonQuestion:'What now?',
  moo:function(){
    console.log('moo);
  },
  feet:4,
  accordingToLarson:'will take over the world'
};

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• Update Probot (major) (@probot/adapter-github-actions, probot)
• Update utilities to v3 (major) (cron, node-fetch)
• Update dev dependencies (nock, nodemon, smee-client)
• Update dev dependencies (major) (nodemon, smee-client)
• Update actions/checkout action to v4
• Update docker/login-action action to v3
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency probot to v12.3.4
• Update utilities (cron, dayjs, dotenv, http-status-codes, js-base64, module-alias)

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Configure rule to stick either to .then or await

Implement rule that recommends to import/require functions directly from given packages.

e.g. for uniq from lodash

[1] import _ from 'lodash';

[2] import { uniq } from 'lodash';

[3] import uniq from 'lodash/uniq';

first and second way of importing should be commented out

read more at:
https://www.blazemeter.com/blog/the-correct-way-to-import-lodash-libraries-a-benchmark

configure directories that would require specific file naming convention. For instance,

{
  path: 'backend/controllers',
  filename: /.*Controller.js/
}

Implement rule that allows to set pattern for conditional statements that include only single line

if (...)  // do something...

if (...) 
   // do something...
   
if (...) { 
   // do something...
}

do
    // something
while ();

do {
    // something
}
while ();

do 
{
    // something
}
while ();

Upgrade rule to allow to force position order between different variations of keyword.

For import it would allow to specify order of:

• packages
• components
• helpers

ATM only second layer of ordering is planned.

Currently Probot reviews files by file extension, regardless of their location.

Assume that one repository holds backend and frontend

If backend is not of type module, but frontend is, user should be allowed to map review. E.g.

backend/* -> js
frontend/* -> vue 

env should include property

URL_TO_BOT_CONFIGURATION=

when provided, bot on init fetches config, parses it and uses as active one. If URL is not provided, default (current) config is used.

Add option that restricted number of users (or PR owner) can call !rereview command to re-run bot review

when declaring object, suggest to always use const

Loops can become very slow if you don’t do them right. One of the most common mistake is to read the length attribute of an array at every iteration:

var names = ['George','Ringo','Paul','John'];
for(var i=0;i<names.length;i++){
  doSomeThingWith(names[i]);
}

This means that every time the loop runs, JavaScript needs to read the length of the array. You can avoid that by storing the length value in a different variable:

var names = ['George','Ringo','Paul','John'];
var all = names.length;
for(var i=0;i<all;i++){
  doSomeThingWith(names[i]);
}

Aborted due to insufficient data to determine "extended" mode within patches
e.g. if (something) to comment it and suggest if (something === true) instead.

Instead of Logical Operator Style only simple mode rule will be introduced.

but there is window for that in later version 🤔

Loops can become very slow if you don’t do them right. One of the most common mistake is to read the length attribute of an array at every iteration:

var names = ['George','Ringo','Paul','John'];
for(var i=0;i<names.length;i++){
  doSomeThingWith(names[i]);
}

This means that every time the loop runs, JavaScript needs to read the length of the array. You can avoid that by storing the length value in a different variable:

var names = ['George','Ringo','Paul','John'];
var all = names.length;
for(var i=0;i<all;i++){
  doSomeThingWith(names[i]);
}

Implement rule that allows to set how comparision statements should be expressed

Longhand

if (isValid === true) {
 // do something ...
}

if (isValid === false) {
 // do something ...
}

Shorthand

if (isValid) {
 // do something ...
}

if (!isValid) {
 // do something ...
}

PS: more details about complications in rule's documentation