Giter VIP home page Giter VIP logo

tricorder's People

Contributors

jonnyarnold avatar renovate[bot] avatar timreynolds avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

tricorder's Issues

Maintainer

Hi,

I notice tricorder has some open PRs and issues that haven’t been triaged.

If you’re no longer using this internally and don’t wish to maintain the library I’m happy to either be added as a collaborator or take ownership of the codebase given I authored the code originally.

Would be good to see this actively supported as alternatives to this library aren’t great.

response sizes

Where we send http responses, it'd be great to get all the information we have for requests, but as a response metric too.

Rename

I suggest we rename this to be @trussle/express-prometheus-metrics-command-factory-builder ;)

Node 10 doesn't export GC information

Builds on Node 10 are failing:

  ● index › metrics › third party metrics › Given metrics running, should include gc metrics

    expect(string).toContain(value)

    Expected string:
      "<redacted from this snippet>"
    To contain value:
      "nodejs_gc_runs_total"

It looks like Node 10's internals have been altered not to show this information.

Tricoder not working with Nest.js

Hello,

I'm trying to use this middleware with Nest.js framework (which normally works with Express middlewares as the core of the framework is Express).

Here is sample of my server instance bootstrap file:
`import { NestFactory } from '@nestjs/core';
import { AppModule } from './app/app.module';

// import * as metrics from 'prometheus-api-metrics';
import * as tricorder from '@trussle/tricorder';
import * as logger from 'express-bunyan-logger';

async function bootstrap() {
const app = await NestFactory.create(AppModule);
// app.use(metrics());
app.use(logger());
tricorder.instrument(app as any);
await app.listen(process.env.PORT || 3000);
}
bootstrap();
There is a type conflict as nestJs server instance has a extended Express type, but this can be dealt like this:tricorder.instrument(app as any);`

Then I'm getting this issue:
Screenshot 2019-09-25 at 10 19 07

Which leads me to user your competitor prometheus-api-metrics ... (good place to check how they handling nest?)

I do prefer tricoder because https_total_requests metrics addition which is very useful.

Nest.js is very quickly growing framework so this should be worth attention.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.