trussle / tricorder Goto Github PK

Hello,

I'm trying to use this middleware with Nest.js framework (which normally works with Express middlewares as the core of the framework is Express).

Here is sample of my server instance bootstrap file:
`import { NestFactory } from '@nestjs/core';
import { AppModule } from './app/app.module';

// import * as metrics from 'prometheus-api-metrics';
import * as tricorder from '@trussle/tricorder';
import * as logger from 'express-bunyan-logger';

async function bootstrap() {
const app = await NestFactory.create(AppModule);
// app.use(metrics());
app.use(logger());
tricorder.instrument(app as any);
await app.listen(process.env.PORT || 3000);
}
bootstrap();
There is a type conflict as nestJs server instance has a extended Express type, but this can be dealt like this:tricorder.instrument(app as any);`

Then I'm getting this issue:

Which leads me to user your competitor prometheus-api-metrics ... (good place to check how they handling nest?)

I do prefer tricoder because https_total_requests metrics addition which is very useful.

Nest.js is very quickly growing framework so this should be worth attention.

Builds on Node 10 are failing:

  ● index › metrics › third party metrics › Given metrics running, should include gc metrics

    expect(string).toContain(value)

    Expected string:
      "<redacted from this snippet>"
    To contain value:
      "nodejs_gc_runs_total"

It looks like Node 10's internals have been altered not to show this information.

Where we send http responses, it'd be great to get all the information we have for requests, but as a response metric too.

I suggest we rename this to be @trussle/express-prometheus-metrics-command-factory-builder ;)

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (@trussle)

It'd be great to have the payload size in bytes of traffic.

We could use it to detect malformed requests from upstream services

Hi,

I notice tricorder has some open PRs and issues that haven’t been triaged.

If you’re no longer using this internally and don’t wish to maintain the library I’m happy to either be added as a collaborator or take ownership of the codebase given I authored the code originally.

Would be good to see this actively supported as alternatives to this library aren’t great.