trycourier / courier-php Goto Github PK

We use https://github.com/nimbly/Capsule/ for building the outbound HTTP requests. There's a little risk in relying on Capsule because its not a popular dependency (just has 1 star on GH) - maybe we can find a better/widely used alternative and replace it?

The send api call doesn't support selecting a brand: https://github.com/trycourier/courier-php/blob/main/src/Courier.php#L183

The client has to be updated to support a brand ID so that notifications can be sent without having to always use the default brand.

https://docs.courier.com/reference/send-api#sendmessage

When following the instructions from the README.md file, the package isn't installed. They're prompting to install courier/courier-php but the packagist package is actually trycourier/courier. README.md has to be updated with the proper instructions.

Steps to reproduce:

1. Create a fresh directory for a temp project
2. Have php and composer installed
3. composer init
4. Follow prompts to create a basic PHP project, ready to add composer packages to.
5. Execute the instructions on README.md: composer require courier/courier-php

Expected result:

composer require trycourier/courier 
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 6 installs, 0 updates, 0 removals
  - Installing psr/http-message (dev-master efd67d1): Cloning efd67d1dc1 from cache
  - Installing psr/http-client (dev-master 22b2ef5): Cloning 22b2ef5687 from cache
  - Installing psr/http-factory (dev-master 36fa03d): Cloning 36fa03d50f from cache
  - Installing nimbly/capsule (0.11): Loading from cache
  - Installing nimbly/shuttle (0.3.3): Loading from cache
  - Installing trycourier/courier (dev-add-template f81f127): Cloning f81f12772c from cache
Writing lock file
Generating autoload files

Actual result:

composer require courier/courier-php                                                                                                                                                                                                       
  [InvalidArgumentException]                                                                                                                                                                                          
  Could not find a matching version of package courier/courier-php. Check the package spelling, your version constraint and that the package is available in a stability which matches your minimum-stability (dev).  
                                                                  

Just wanted to get some insight on the current minimum version of PHP required in composer.

Is there a current reason for the requirement of >=7.2, the current minimum maintained version of PHP is 7.4 which is receiving security fixes until 28th November 2022.

See support table for more insight.

With your blessing it would be nice to upgrade that minimum to at least 7.4 for security, updates etc. You may have further insight into the current versioning that I do not of course!

I would like to propose the the Laravel code is removed from this repository and moved to it's own separate repository.

trycourier/courier-php

• This allows this package to purely support the PHP implementation.
• Folks installing the package may not need the the additional code, nor should it be a requirement for them.
• The current Laravel code is not tested, adding tests would add complexity to this package.
• IMO, the current Laravel code is well below par when it comes to what the Laravel community expect from a package.
• Increasing Laravel support here would make it harder for others, unfamiliar with Laravel, to contribute, and understand.

trycourier/courier-laravel

• Allows improvements to the existing code in a dedicated and well tested environment.
• Would pull in this package so core functionality is still provided here.
• The aforementioned environment would allow us to more easily add some more features. I have been thinking about adding the ability to have Courier as a custom notification channel, allowing integration with Laravel's first-party notification system.

Imagine;

$user->notify(new InvoicePaid($invoice));
// Triggers a sendNotification() call to courier with the user reference and additional profile data etc. 🤤

Trying to install this SDK with PHP 8.2 is crashing...