tryexceptpass / korv Goto Github PK

Using pytest as the test framework, add the basic tests that verify a server instance:

• Instantiate KorvServer without errors using newly generated SSH keys.
• GET routes execute correctly and respond with valid JSON.
• STORE routes execute correctly and respond with valid JSON.
• UPDATE routes execute correctly and respond with valid JSON.
• DELETE routes execute correctly and respond with valid JSON.
• Verify it's not possible to connect with the wrong SSH key.

In Client.py line 99 need to add max_pktsize as an optional parameter to conn.create_connection()

• Let's minimize json data by setting separators=[',', ':'] during dumps().
• Use gzip.compress() on the minified json data before sending it on the client and server.
• Use gzip.decompress() before parsing the json on received messages on both client and server.

In Server.py line 121 - logging.info("Connection requested", dest_host, dest_port, orig_host, orig_port) is throwing a traceback when the client connects to the server.

the error is "Not all arguments are strings", everything continues to work though.

Ran into this when returning a Dictionary that was over the size limit so a partial dictionary was returned with half a string at the end ( ie "words words ) with no ending quote.

narrowed it down to:
Client.py
Class -> _SSHClientSession::data_received()
line 37 data = json.loads(data)

the data being parsed needs to validated prior to entering json.loads() or try/excepted here.

Using pytest as the test framework, add the basic tests that verify a client instance:

• Instantiate KorvClient connecting to a local server without errors using newly generated SSH keys.
• GET responses complete with the proper callback.
• STORE responses complete with the proper callback and with no callback.
• UPDATE responses complete with the proper callback and with no callback.
• DELETE responses complete with the proper callback and with no callback.
• Connection fails with the incorrect host address or port.
• Connection fails with the incorrect SSH key.