tspoke / typescript-open-location-code Goto Github PK

Thank you for this useful library!

It would be very kind of you to fill out the "license" field in the package.json file, i.e.:

"license": "Apache-2.0"

That would make checking license compatibility much easier.

Hello!

Would you mind adding an internal max length to your implementation, as per google/open-location-code#190?

Specifically, the following changes will be made:

• If you ask the library to encode a lat/long with more than 15 digits, the library will return a plus code with 15 digits.
• If you ask the library to decode a plus code with more than 15 digits, the library will only take the first 15 digits into account with the returned code area.
• Plus codes with more than 15 digits will be treated as valid if all the other validity constraints are satisfied. If the plus code has an invalid character after the 15th digit, it will be treated as invalid.

You can copy my PR for the JS implementation here: google/open-location-code#242

Let me know if you have time to do this in the next couple weeks.

Hello from the main Open Location Code repo!

We're currently working on fixing floating point precision issues with the various implementations (see here). For the implementations not directly in the main repo, we're asking for the owners to update their code accordingly. Would you be able to do the following when you get a chance?

1. Run the new test cases in test_data/encoding.csv.
2. If they fail, fix your implementation to properly handle the floating point precision issues. I'll post again when we have a commit that you can use for reference.