tth05 / morerefinedstorage Goto Github PK

Issue description:

More Refined Storage which adds large disk drives is incompatible with this fork.

What happens:

game crashes when trying to use a disk from the More Refined Storage mod (not this mod) simply holding a disk from the addon caused the crash.
https://www.curseforge.com/minecraft/mc-mods/more-refined-storage

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: 2847
• Refined Storage: 2.2.7

Does this issue occur on a server? [yes/no]
yes

If a (crash)log is relevant for this issue, link it here:

https://paste.mod.gg/guyedapofi.mccrash

Like... in JEI you can type in say (ring) and it'll show you all the items that have "(ring)" listed in it, or typing in Unbreaking to find the Unbreaking Enchanted Book, etc.

At the moment it doesn't seem that typing the details out won't find the items. You have to search by them by their Name, like if you wanted to find Enchanted Books, you have to type in Enchanted Book.

Issue description:

If you connect an Advanced Rolling Machine to the Collector from a refined storage in which there is a template for production from a certain resource, it disappears. There is no autocrafting or import bus, it just takes resources without starting the mechanism.

https://www.youtube.com/watch?v=k8iPTj5RdlY&feature=emb_logo

UPD: I thought that the problem was in the combination of two mods, but the problem turned out to be refined, it removes the resources for which it has a template:...
https://www.youtube.com/watch?v=qjGYYdC2G-g&feature=emb_title

UPD: Changed crafting plates from a compactor / metal former to cutting a block - it also removes iron (even 1-2 pieces that cannot be crafted)
https://www.youtube.com/watch?v=CAM5OlNtc7c&feature=emb_title
The same result comes out if you make copper plates, it takes away all the copper.

Does this issue occur on a server? [yes/no] yes

title

the server freezes when ordering a large number of autocraft resources
it only seems to happen on large networks
rs 2.2.6
https://pastebin.com/E8wMycrV

Issue description:

issue is not cureforge friendly aka deinds is possble for it to port that to curesforge

Version (make sure you are on the latest version before reporting):

• Refined Storage: reborn storage version cant rewrite a bug for reborn storage either

• Thaumic Grid
• Storing essentia in the network

I should have added this.gui.updateScrollbar(); at the end of postChange to ensure that crafting recipes (etc) can't scroll off the bottom while new unique items are coming into the system. I have only confirmed that this is a problem in RS on 1.16, but I suspect it is be the same in 1.12. Of course changing the contents of the search box will refresh the scroll bar anyway, so I suspect anyone searching for a crafting recipe will never notice this.

Hello,

Using this fork of RS causes the game to crash upon load with Refined Storage: Requestify

Buuz135/RS-Requestify#37

https://mclo.gs/ZVUB3Fu

Perhaps something is outdated which still requires the old RS. Any ideas?

Issue description:

Items with durability are duped through the shift button

Steps to reproduce:

1. In the crafting terminal, you lay out the craft of the item (it is imperative that items with durability are used in the craft), you craft it by shift, it is transferred to your inventory, and the ingredients are not spent.
   

2. If there is an item in the upper left slot, and a stack of items in the system, then it will look like this
   
   
   

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: latest 1.12.2
• Refined Storage: Release v2.1.0

Does this issue occur on a server? [yes/no] yes

my english is not very good, this is translated by google
Added more slots to the Pattern Grid in RS-1.9.17, so I would like to ask if it can be ported to this version

[Because trying to Refined Storage Large Patterns crashed many times in my modmodpacks, and trying to recompile Refined Storage Large Patterns because there is no com.raoulvdberge.refinedstorage.tile.config.IType, it fails to compile]

https://support.curseforge.com/en/support/home
https://support.curseforge.com/en/support/solutions/articles/9000197913-non-curseforge-mods
https://docs.google.com/spreadsheets/d/176Wv-PZUo9hFxy6oC6N8tWdquBLPRtSuLbNK-r0_byM/edit#gid=0

Issue description:

What happens:

You can craft infinite amounts of items with the wireless crafting grid without the items getting removed.

What you expected to happen:

Steps to reproduce:

1. Craft wireless crafting grid
2. Connect it to the controller
3. Craft any items as often as you wish

Does this issue occur on a server? [yes/no]

yes

Issue description: In GregTech there are machines with several fluid output slots, the fluid importer can only drain from the first non-empty fluid slot.

What happens: The importer on fluid mode only imports fluids from the first slot.

What you expected to happen: That the importer can import fluid from any slot.

Steps to reproduce:

1. Using GTCE run any recipe that results in 2 or more fluids.
2. Try to import a fluid that isn't in the first slot from the left.

Basically the issue is here. It should loop over the fluid tank properties like here.

It's a addition for RS,but i think it doesn't work on your version.Could you please cheak what's wrong with it.

Issue description:

Server crashes when switching pulverizer (from Thermal Expansion) mode connected to refined storage

What happens:

crash server

Steps to reproduce:

Connect the pulverizer to the refined storage, change the input ports and get a crash

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: latest
• Refined Storage: 2.1.1

Does this issue occur on a server? [yes/no] yes

If a (crash)log is relevant for this issue, link it here:

https://pastebin.com/bs9g2qyH

Issue description:

https://spark.lucko.me/#exNtnGPNkN

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: latest
• Refined Storage: 2.2.2

Does this issue occur on a server? [yes/no] yes

Issue description: I just transfered my quite large save to use your fork. I've noticed that quite a few of the recipes I had to use oredict (for instance steel, bronze plates) think they can't be crafted.

What happens: Try to craft an item that has an incorrect item with the correct oredict in the recipe. The crafter doesn't recognize the recipe to craft an item with the same oredict. In my case I was trying to craft a Mixed Metal Ingot from GTCE which uses Steel, Bronze and Aluminium plates. The recipe had Thermal Steel and Bronze plates in the pattern. I had existing patterns to craft GTCE Steel and Bronze plates.

Now maybe this is just something that is unavoidable giving the transfer to your fork but I wanted to bring it to your attention just in case.

[21:06:06] [Netty Local Client IO #3/ERROR] [FML]: NetworkDispatcher exception
java.lang.IllegalArgumentException: Payload may not be larger than 32767 bytes
at net.minecraft.network.play.client.CPacketCustomPayload.(CPacketCustomPayload.java:28) ~[lh.class:?]
at net.minecraftforge.fml.common.network.internal.FMLProxyPacket.toC17Packet(FMLProxyPacket.java:142) ~[FMLProxyPacket.class:?]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.write(NetworkDispatcher.java:533) ~[NetworkDispatcher.class:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:738) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:801) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:814) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:794) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:831) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:1032) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:296) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
at net.minecraft.network.NetworkManager$4.run(NetworkManager.java:245) [gw$4.class:?]
at io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54) [netty-all-4.1.9.Final.jar:4.1.9.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858) [netty-all-4.1.9.Final.jar:4.1.9.Final]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_291]

https://i.imgur.com/iytrvmk.png

Issue description: wrong coun items in barrels YABBA

What happens: Show only 64 but really another

What you expected to happen:

Steps to reproduce:

...

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: 2855 latest
• Refined Storage: lates your version

Does this issue occur on a server? [no]

If a (crash)log is relevant for this issue, link it here:

[pastebin/gist/etc link here]
https://i.imgur.com/uFq4OHM.png
https://i.imgur.com/BONITHw.png

Issue description:

RebornStorage (fork v3.3.5.2) does not support the latest version of moremorerefinedstorage anymore

What happens:

cannot use the new disks from RebornStorage

What you expected to happen:

Steps to reproduce:

...

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: 14.23.5.2860
• Refined Storage:v3.3.5.2

Does this issue occur on a server? [yes]

If a (crash)log is relevant for this issue, link it here:

[pastebin/gist/etc link here]

why if i choose only template form in terminal and prees to create anything its not show in this menu? in original its work good

Server crash
https://gist.github.com/bigenergy/24831302999d5f4f3f83c18dd13de6e3

all time when i press in jei + in refined storage on wood or plank( or may be somethink i have this
i dont know what it happens but i press [plus] and this bug happen
https://pastebin.com/KDKKNDw3
and sapling too

This is just a QOL feature that is really good. Used it in PAE2 and it's actually really good. Let me know your thoughts.

So when you shift click the arrow to encode a pattern, it sends it straight to your inventory. This can be used to have multiple of the same patterns to be used in parallel. Thank you

Issue description:

Friend went on my system and ordered 23512 crafters (e2e recipe). It wouldn't go onto the pre craft screen and just stay there. Clicked cancel and tried again to craft 1. it wouldnt go onto the pre craft screen again, and i logged on and checked that all of my redstone, iron and glass just disappeared.

What happens:

Friend went on my system and ordered 23512 crafters (e2e recipe). It wouldn't go onto the pre craft screen and just stay there. Clicked cancel and tried again to craft 1. it wouldnt go onto the pre craft screen again, and i logged on and checked that all of my redstone, iron and glass just disappeared.

What you expected to happen:

To go to the precraft screen and be able to cancel it and be able to autocraft it again, and not have my items disappear.

Steps to reproduce:

1. Craft a crafter (e2e recipe) fully automated recipe. Ask for an absurdly large number.
2. To be honest I don't even know if this is reproduceable, if you want I can send you the server IP so you can test it out and the co ordinates of my house.
   ...

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: 2847
• Refined Storage: 2.2.9

Does this issue occur on a server? [yes/no]
Yes

If a (crash)log is relevant for this issue, link it here:

[pastebin/gist/etc link here]

Hey, found your fork and it's really nice to see new features from 1.12+ version here as well as some improvements. I have one question though. Is it possible to change single item extraction button from middle click to SHIFT/CTRL + R-Click for instance (like AE2 does it)? Because to be honest having it on middle click isn't that convenient and easy to use.

Issue description:

Can not access the fields of an Itemstack in oc.

What happens:

After retrieving the items of the system you are unable to access any information of them because everything returns null.

What you expected to happen:

Steps to reproduce:

1. Make an opencomputers setup
2. Get the items of the refined storage system
3. Try to access the fields of an itemstack (name, label, etc)

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12
• Forge:
• Refined Storage: latest

Does this issue occur on a server? [yes/no]

yes

This version of RS doesn't support Thaumic Grid

crash-2023-08-21_05.55.57-client.txt

If possible, add support for this. Only the OG RS supports it. Probably something outdated on TG part.

DoctorFTB/ThaumicGrid#20

Issue description:

What happens:

The side button in a filter displays unlocalized names:
sidebutton.refinedstorage:type.ITEMS
sidebutton.refinedstorage:type.FLUIDS

What you expected to happen:

'Item' and 'Fluid' to be displayed & localised in en_us.lang

Steps to reproduce:

1. right-click a filter item.
2. hover over 'Type' side button.
3. see unlocalized name for both items and fluids.
   ...

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: 14.23.5.2860
• Refined Storage: 2.3.2

Does this issue occur on a server? [yes/no]
Yes

If a (crash)log is relevant for this issue, link it here:

N/A

No need for detailed Display Modes, just make controller to accept IC2 EU.

Issue description:

Will morerefinedstorage keep chunkloading?
I am the only one in the server, but spark and LagGoggles shows, the refinedstorage's thread is always running, is it possible to add an option in the config for turning off chunkloading?

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: 2680
• Refined Storage: 2.3.1

Does this issue occur on a server? [yes]

If a (crash)log is relevant for this issue, link it here:

[pastebin/gist/etc link here]

Issue description:

Server crashes when I request autocraft of high amount of IC2 overclockers. It also crashed when someone on server autocrafted planks? It crashes as soon as you press the button after typing how many you want. (Pre-calculation screen).

Interestingly it only happens on the dedicated server. It has 10GB ram available so I don't really know.

What happens:

What you expected to happen:

It would go on the calculation screen and we can click start.

Steps to reproduce:

1. Craft many items on a server.
2. Watch it burn.

...

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: 2860
• Refined Storage: 2.3.2

Does this issue occur on a server? [yes/no]
Yes, only on server

If a (crash)log is relevant for this issue, link it here:

For IC2 Overclockers:
https://mclo.gs/N2aLqDq

For Wooden planks (I believe):
https://mclo.gs/ZN4STrz
[pastebin/gist/etc link here]

Issue description:

Crashes when using extreme patterns

What happens:

I used Refined Avaritia to make a crafting pattern for crystaltine. Made the pattern and then put into crafter (above automation interface) and then server crashes.

What you expected to happen:

It wouldn't crash

Steps to reproduce:

1. Make extreme pattern
2. Put in crafter
3. Kaboom
   ...

Version (make sure you are on the latest version before reporting):

• Refined Avaritia: 2.6
• Minecraft: 1.12.2
• Forge: 2847
• Refined Storage: 2.2.6

Does this issue occur on a server? [yes/no]
Don't know

If a (crash)log is relevant for this issue, link it here:

[pastebin/gist/etc link here]
https://pastebin.com/YHiwpZnK

Issue description: When trying to autocraft an item in the crafting grid you have to press shift. Doing this shows only craftable items. If you have one or more items and hold shift it disappears, even if it can be crafted.

What you expected to happen: That I can press shift on an existing item and start a craft.

Steps to reproduce:

1. Have a recipe for any item.
2. Have one or more of said item.
3. Go into crafting grid, press shift and see said item disappear.

Issue description:

It crashes when used with Refined Storage Addons because some APIs have changed.

Steps to reproduce:

Install the latest versions of Refined Storage Addons and More Refined Storage.

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: 14.23.5.2854
• Refined Storage: 2.2.1

I haven't tested on a server.

If a (crash)log is relevant for this issue, link it here:

This is the first message you get upon trying to load a world:

java.lang.NoClassDefFoundError: com/raoulvdberge/refinedstorage/apiimpl/util/OneSixMigrationHelper
	at com.raoulvdberge.refinedstorageaddons.proxy.ProxyCommon.fixBlockMappings(ProxyCommon.java:37) ~[ProxyCommon.class:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_1580_ProxyCommon_fixBlockMappings_MissingMappings.invoke(.dynamic) ~[?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus$1.invoke(EventBus.java:144) ~[EventBus$1.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182) ~[EventBus.class:?]
	at net.minecraftforge.registries.GameData.lambda$injectSnapshot$20(GameData.java:684) ~[GameData.class:?]
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) [?:1.8.0_201]
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) [?:1.8.0_201]
	at java.util.Iterator.forEachRemaining(Iterator.java:116) [?:1.8.0_201]

I rebuilt the addons locally to remove references to OneSixMigrationHelper, which then fails because of API changes to onCrafted, onCraftedShift, etc.

Is there an alternative version of the addons I should be using?

Issue description:

server crash in start

Version (make sure you are on the latest version before reporting):

• Minecraft:
• Forge:
• Refined Storage: 2.1.7

Does this issue occur on a server? yes

https://pastebin.com/9hmaPBKJ

Issue description:

Mod crashes on load if baubles not installed

If a (crash)log is relevant for this issue, link it here:

https://pastebin.com/nnuBXkxr

take a custom disk (storage tech) from JEI and crash server
https://pastebin.com/1eWNYbKx

Issue description:

Thaumic Grid incompatible

What happens:

Crash

Steps to reproduce:

1. Install RS (morerefinedstorage)
2. Install Thaumic Grid (https://www.curseforge.com/minecraft/mc-mods/thaumic-grid)
3. Install Thaumcraft 6.1
4. Start client or server and get crash https://pastebin.com/6nVNMuj1

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: latest
• Refined Storage: latest

Does this issue occur on a server? yes

If a (crash)log is relevant for this issue, link it here:

https://pastebin.com/6nVNMuj1

Issue description: Refined storage autocrafting is deleting buckets when using water filled buckets in recipe

What happens: create pattern for paper using 4x sawdust + 1 water filled bucket. System crafts required buckets, then fills them with water. When the autocrafting process gets to create the paper with sawdust + water bucket, paper is outputted but all water buckets used are destroyed (not returned to the storage system)

What you expected to happen: when executing the same crafting recipe in a vanilla crafting table, empty bucket remains in the table.

Steps to reproduce:

1. Autocraft 4x sawdust (Thermal) + 1 water filled bucket = 6 paper
2. Count the number of buckets crafted (plus iron usage)
3. Validate if buckets remain in the system after crafting is done
   ...

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.16.5
• Forge: 36.2.2
• Refined Storage: 1.9.15

Does this issue occur on a server? [yes/no] no

If a (crash)log is relevant for this issue, link it here:

No crash

v2.2.3
https://pastebin.com/m1YVMk9n

Issue description:

If you put a redstone on the network, after a while it will break

Steps to reproduce:

Until I figured out how to reproduce it

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: latest
• Refined Storage: latest

Does this issue occur on a server? [yes/no] yes