tucq88 / coderschool-week1 Goto Github PK

Hi @tucq88, great job with the submission. We're sorry for the slow reply. Somehow your homework was marked as reviewed but I no comments were left for it.

Great stuff:

• Good routes. You can make your routes cleaner by using get 'contact' => 'home#contact instead of using the to: syntax.
• Validations in the model.
• Understand and use has_and_belongs_to_many. We tend to use has_many :through instead (more control and it's cleaner). But your approach is just fine.
• Use of Google Maps js
• Good use of bootstrap css

Suggestions:

• The main thing to notice in your homework is that you use jQuery's $(document).ready -- this does not work well with turbolinks 5. See http://guides.rubyonrails.org/working_with_javascript_in_rails.html#page-change-events to know why we should wrap the set up script inside a turbolinks:load instead.
• Good code style in general, but you should use 2-space indentation everywhere in your code. There are some inconsistencies such as in here