tuliot / pitchperfect Goto Github PK

I would like to use the App Icon supplied by udacity

The Normal button is now a button below the list of the modulators. I would like this button to be inside of the collectionview with the rest of the modulators.

Modulator buttons start at the very top of the screen. There should be some space that separates the two. When you scroll upwards, though, they should disappear behind the nav bar, and not be cut off

Would like to have a look-through of all the code written prior to submission.

• Functions have a headerdoc
• Variable names are smart
• Spacing is consistent (use of a linter is OK)
• Guards are being used in place of if ... blocks that guard
• Code that is not obvious is well-documented
• Functions are organized within each file, under their respective // MARK: header

I would like for the app to not be white. Don't know what color scheme would be the most appropriate, but something simple and playful that is also easy to change. I expect whatever color scheme is chosen to be implemented throughout the application, and for any other view controller to fallback to said theme if none other is specified

In the Play screen, I expect to be able to play a sound a few seconds after playing a previous sound. This is not happening anymore.

Udacity provided other images that were still not being used. These should be added:

Microphone/Stop, Pause/Resume

Custom Modulator Creation
As a user, I would like to be able to create my own modifiers. I want there to be button on the screen that allows me to playback my sound, just like the other modulators, with a plus sign. When I click this, I expect to be taken to a screen that allows me to create my modulator. There should be a checkbox for the boolean modulator options, { echo, reverb }, a slider for the numeric options, { rate, pitch }, and an input for me to give my modulator a name.

As a nice-to-have, I would like this modulator to be persisted, so that I can use it next time I open the app as well

There should be a button that takes me to the creation of a modulator. This button should always be the last button on the list of modulators, but should not really be a modulator. It should just have a plus sign on it, to indicate that it would allow me to create a new modulator.

I would like the Playback screen to look prettier. Right now, this looks like

Which is hideous. I would like them to appear in a grid, paginated so that I only see four at a time.

Spamming one of the play buttons breaks the app

I expect the README document to say what this app does, how to build it, how to contribute, and licensing information

As a nice-to-have, I would also like the README to have changelog

Right now, there is no visual indicator that a sound is playing. This might be a bit confusing, and the app would look way nicer with this. I would like for all modulators to dim when I am not allowed to click on them

• Add a 'disabled' state for the modulatorcell
• OnClick of a modulatorcell, apply the 'disabled' state
• When sound is finished, remove the 'disabled' state

I would like to have a button under all the modulators that allows me to stop a sound that is playing. This button should first be hidden, and should only appear when a sound is currently playing.

The image that should be used for the button is the following:

When I press this button, I expect for all of the following to happen

• The button should disappear
• All modulators should now be available for usage, and should NOT be dim anymore

Would like for all user-facing text in the application to be localized strings

While a sound is playing, if I press "Record" on the nav bar, I get taken to the Record screen but the sound keeps playing

The scroll bar in the collectionview looks really ugly, so lets hide it

For Udacity submission, I would like to disable addition of modulators. The main reason, is that I want to submit the project already and want to move on to the next one. Since the "Add Modulator" button doesn't do anything, I want it to be a feature that is disabled. This way, the app looks complete, and I don't to remove my Add Modulator code.

Saving the sounds and listening to past ones would be really nice

I would like to be able to add images to the modulators, so that the buttons look cooler.
Also, i would like the record and play buttons to have images.

Use all images supplied by udacity