Giter VIP home page Giter VIP logo

falcon-celery's Issues

First Review

Problem:

  • both saveResultToFile.py and task.py are not controller but rather service, should move them to service folder
  • remove data.txt from git ( not source code )
  • if using env file, should create an .env.sample file, commit it and put sample parameters in there so other developers can know which parameters are needed
  • login:
if not UserModel.objects(email = email):
            resp.status = falcon.HTTP_400
            resp.body = "Email or password is incorrent!"
            return

 user = UserModel.objects(email = email).get()

only need to query user once, doing it twice will query db twice -> waste resources, increase response time

user = UserModel.objects(email = email).get()
if not user:
     ...

....

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.