turakar / signal4j Goto Github PK

Hi,

Thank you for your great work.

I'm unable to run the empty Android application after adding signal4j as dependency.

Build.gradle (Module:app) looks like this,

apply plugin: 'com.android.application'

android {
    compileSdkVersion 28
    defaultConfig {
        applicationId "client.company.com.myapplication"
        minSdkVersion 15
        targetSdkVersion 28
        versionCode 1
        versionName "1.0"
        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
        multiDexEnabled true
    }
    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }
}

repositories {
    mavenCentral()
    maven { url "https://jitpack.io" }
}

dependencies {
    implementation fileTree(dir: 'libs', include: ['*.jar'])
    implementation 'com.android.support:appcompat-v7:28.0.0'
    implementation 'com.android.support.constraint:constraint-layout:1.1.3'
    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'com.android.support.test:runner:1.0.2'
    androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'

    implementation 'com.github.turakar:signal4j:1.0.0'
}

In Build.gradle (Module Project) classpath is 3.1.4

[classpath 'com.android.tools.build:gradle:3.1.4']

I tried to downgrade to appcompat-v7:26.0.0 and in that case i'm facing following error. File changes in error but Multiple dex files define remains.

Multiple dex files define Lorg/bouncycastle/asn1/cms/AuthenticatedData;

The API should be capable of updating a group's or contact's metadata.

I was tried to call in my main class

signalService.finishConnectAsPrimary(verCode);

but this error occurs:

Exception in thread "main" org.whispersystems.signalservice.api.push.exceptions.NonSuccessfulResponseCodeException: Bad response: 400
at org.whispersystems.signalservice.internal.push.PushServiceSocket.makeServiceRequest(PushServiceSocket.java:894)
at org.whispersystems.signalservice.internal.push.PushServiceSocket.makeServiceRequest(PushServiceSocket.java:791)
at org.whispersystems.signalservice.internal.push.PushServiceSocket.verifyAccountCode(PushServiceSocket.java:223)
at org.whispersystems.signalservice.api.SignalServiceAccountManager.verifyAccountWithCode(SignalServiceAccountManager.java:203)

any idea?

i'm using jdk 1.8

This library isn't up-to-date with the latest versions of the libsignal-protocol-java library.

Therefore a lot of javadoc has to be updated to make it compatible.

To complete the usage as the first device, sync request should be answered. This should be done in handleSyncMessage.

signal4j does not offer (?) a way to send messages to groups, if the user knows only the groupid, because signal4j won't tell you the group's members.

In the sample plugins this works nicely as they only respond to group messages and thus get a handle to the group object, but a plugin that wants to send messages without receiving some does not.

I have added a new sendMessage overload to SignalService to have a dirty workaround:

public void sendMessage(String groupId, String content) throws IOException {
    byte[] id = Base64.decode(groupId);
    Group group = store.getDataStore().getGroup(new GroupId(id));
    SignalServiceDataMessage message = SignalServiceDataMessage.newBuilder()
        .withTimestamp(System.currentTimeMillis())
        .asGroupMessage(SignalServiceGroup.newBuilder(Type.DELIVER)
            .withId(group.getId().getId())
            .build())
        .withBody(content)
        .withExpiration(group.getMessageExpirationTime())
        .build();
   sendMessage(group.getMembers(), message);
}

What did you intend?