Giter VIP home page Giter VIP logo

dind-nurse's People

Contributors

damoon avatar elchenberg avatar renovate-bot avatar renovate[bot] avatar

Stargazers

avatar

Watchers

avatar avatar avatar avatar

Forkers

procinger wasdergg

dind-nurse's Issues

Run build tests without the need of a test directory and Dockerfile

The following three lines of shell script could be replaced with a one-liner:

echo "FROM docker.io/library/hello-world:latest" | docker build --file=- .

dind-nurse/pkg/setup.go

Lines 88 to 90 in 9bde468

`mkdir -p /test-build
echo "FROM hello-world" > /test-build/Dockerfile
docker build /test-build`, 

echo "FROM docker.io/library/hello-world:latest" | docker buildx build --file=- .

dind-nurse/pkg/setup.go

Lines 109 to 111 in 9bde468

`mkdir -p /test-build
echo "FROM hello-world" > /test-build/Dockerfile
docker buildx build /test-build`,

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Detected dependencies

dockerfile
deployment/Dockerfile
  • docker 26.1.3@sha256:76ba10a4aed708c7b2db09d45740d711edf707f7368f6808bd32a53eaed33404
  • golang 1.22.3-alpine@sha256:7e788330fa9ae95c68784153b7fd5d5076c79af47651e992a3cdeceeb5dd1df0
  • alpine 3.20.0@sha256:77726ef6b57ddf65bb551896826ec38bc3e53f75cdde31354fbffb4f25238ebd
tests/Dockerfile
  • ghcr.io/utopia-planitia/docker-buildx-cli latest@sha256:cd0de5fb4bdaf978325d2b79103bec1a6e8748b7c0668813975f119ed8358622
github-actions
.github/workflows/check.yml
  • actions/checkout v4@a5ac7e51b41094c92402da3b24376905380afc29
  • actions/setup-go v5@cdcb36043654635271a94b9a6d1392de5bb323a7
  • golangci/golangci-lint-action v6@a4f60bb28d35aeee14e6880718e0c85ff1882e64
  • actions/checkout v4@a5ac7e51b41094c92402da3b24376905380afc29
  • actions/setup-go v5@cdcb36043654635271a94b9a6d1392de5bb323a7
  • actions/checkout v4@a5ac7e51b41094c92402da3b24376905380afc29
  • helm/kind-action v1.10.0@0025e74a8c7512023d06dc019c617aa3cf561fde
  • yokawasa/action-setup-kube-tools v0.11.1@5fe385031665158529decddddb51d6224422836e
  • actions/checkout v4@a5ac7e51b41094c92402da3b24376905380afc29
  • helm/kind-action v1.10.0@0025e74a8c7512023d06dc019c617aa3cf561fde
  • yokawasa/action-setup-kube-tools v0.11.1@5fe385031665158529decddddb51d6224422836e
.github/workflows/release.yml
  • actions/checkout v4@a5ac7e51b41094c92402da3b24376905380afc29
  • docker/login-action v3@0d4c9c5ea7693da7b068278f7b52bda2a190a446
  • docker/metadata-action v5@8e5442c4ef9f78752691e2d8f8d19755c6f78e81
  • docker/build-push-action v5@2cdde995de11925a030ce8070c3d77a52ffcf1c0
gomod
go.mod
  • go 1.19
  • github.com/gorilla/mux v1.8.1
  • github.com/urfave/cli/v2 v2.27.2
  • golang.org/x/sync v0.7.0
kubernetes
deployment/kubernetes.yaml
  • docker 26.1.3-dind@sha256:76ba10a4aed708c7b2db09d45740d711edf707f7368f6808bd32a53eaed33404
  • Deployment apps/v1
tests/build-test.yaml
  • build-test-image undefined
tests/buildx-test.yaml
  • build-test-image undefined
regex
.github/workflows/check.yml
  • tilt-dev/tilt v0.33.14
  • tilt-dev/tilt v0.33.14
deployment/Dockerfile
  • docker/buildx v0.14.1
  • Check this box to trigger a request for Renovate to run again on this repository

What is the purpose of the test builds during setup?

It seems to me that the results of the test builds (success or failure) are completely ignored. Should we remove them then?

dind-nurse/pkg/setup.go

Lines 23 to 27 in 9bde468

testBuild(ctx)
testBuildx(ctx)
return nil

If we do not delete them: Why should they fail when we already know (from awaitDocker) that the daemon is running? And if they fail, shouldn't there be some kind consequences (for example throwing an error so the container restarts or marking the container NotReady)?

How can `docker buildx create` succeed when the Docker daemon is not ready?

During setup setupBuildxBuilder is executed before awaitDocker. Maybe I am not understanding something here but I think we need to wait for the daemon before we can create the builder. When I try to create a builder with a non-existing daemon it fails:

DOCKER_HOST=tcp://localhost:2375/no-daemon-is-listening-here docker buildx create --name test
ERROR: failed to initialize builder test (test0): Cannot connect to the Docker daemon at tcp://localhost:2375/no-daemon-is-listening-here. Is the docker daemon running?

dind-nurse/pkg/setup.go

Line 13 in 9bde468

err := setupBuildxBuilder(ctx, buildkitdToml)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.