turnitin / dbmate Goto Github PK

The locking bits are pretty interesting and would be useful more broadly too.

Would you ever contribute them upstream to the original dbmate?

Hi,
The current version does not seem to be able to read files with CRLF terminators.
I think this is causing it to effectively comment out all of the code.
noticed because it worked on the machine I created the files in, but not in any machine that updated the files from github.
I scanned two files for testing, this was the output of the files * command on Ubuntu:

20181123004251_test.sql: ASCII text, with CRLF line terminators
20181124185152_test1.sql: ASCII text

The test.sql file never ran, I forced good and bad SQL, it never created the tables or threw any errors.
The test1.sql always worked just fine.

Both files would show up on the schema_migrations table after running dbmate up.

After changing the line endings from CRLF to LF, test.sql ran as intended.

Hi, because of the following line, dbmate up outputs the following error message when applied to a utf8mb4, innodb (version<5.7) database: Error: Error 1071: Specified key was too long; max key length is 767 bytes

You should limit the version field to less chars (e.g 100) in order to avoid exceeding the 767 byes primary key limit (when multiplied by 4), or force a latin/utf8 encoding on the schema_migrations table ignoring the default db one. more details here: https://stackoverflow.com/a/1814594/1205281

Thanks