Giter VIP home page Giter VIP logo

creating-a-future-proof-responsive-email-without-media-queries's People

Contributors

adamarthurryan avatar snaptin avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

creating-a-future-proof-responsive-email-without-media-queries's Issues

<div><table class="column"> vs <table class="column"

Is there a reason you use a wrapping div for the 2-columns while you direclty put the "content" class in the table for the 3-columns?

Also, you have styles declaring ".column" as display: inline-block but you don't put it back to "display: table" or "display: block" on media query:

I'd expect something like this in the @media query:

    .column {
        display: block !important;
    }
    table.column {
        display: table !important;
    }

Otherwise a small content would not push its ".content" to 100%.

Another option would be to use "width" instead of "max-width" in the @media rules, but maybe there is a reason to not use it... any hint?

Thank you for sharing this template!

vertical-align issue

Hi,

this is absolutely a great piece of code, but I think there is an issue...
It seems, in 2 or three columns blocks, that vertical-align: middle doesn't work if the first column has vertical-align: top

Any suggestion?
Thanks
Ale

Licence

Is there any license for this code?

A bit flawed IMO

This project/example is a great resource, but there are some things that are just a bit confusing to me. I understand for the sake of code weight, just using a table for simple one-column layouts without divs, but this presents issues with consistency across rows of content and I think the extra couple lines of code to do ghost tables here would be much less confusing and more maintainable.
Secondly, if you need to have a section have a different background color, it doesn't work with this weird padding convention where you have to manually set a padding on every row of the layout to line up the edges. Adding a background color to a section with this method would mean a nested ghost table and div inside another just for a bg color, which, while technically works, is not ideal when the rest of the rows don't have this. It would be much better to wrap each row by default with its own wrapper div/ghost table with its own padding so background color can be controlled within the padding of each section.

Fix/improve IE9 based renderings

IE9 correctly supports media queries, so it applies media query styles to a layout using conditional comment tables, and this is not supported by the layout that breaks.
replacing:
[if (gte mso 9)|(IE)]
with:
[if (gte mso 9)|(lte ie 8)]
get better results on IE9.

Do you have any warning against this change?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.