twentyhq / twenty Goto Github PK

• Todo first (before companies page)
• Non editable at this point
• Real back-end data, not mock data

Crop content with [...] when name is too long

#123
#125

We are already retrieving email, first name, last name from google.
We could also retrieve profile picture.

The profile picture will come as an URL, if we store it directly in our DB this won't work because we are currently storing relative path to our own storage in backend
I see two alternatives:

• enable to store absolute path in back-end, in this case, we need to introduce a picture table with type 'absolute' | 'relative' and link it to workspace / user. We then need to update frontend accordingly or have the server always send the absolute URL
• fetch the Image URL and re-upload the image in our own backend.

To keep it simple, I would go for the second option :
https://stackoverflow.com/questions/18264346/how-to-load-an-image-from-url-into-buffer-in-nodejs

Front only

_{From SyncLinear.com | T-325}

It's not taking 100% so we can see that borders aren't touching the container border

Reduce checkbox column width & remove right border

Online:

Figma

On Companies and People tables

_{From SyncLinear.com | T-279}

_T-388

• Logo
• Name

TBD if this task is mostly Front or Front + Back, depending on if T-280 is done before or after this one

Related: #238

_{From SyncLinear.com | T-55}

Maybe we should deactivate linting for this folder instead because it's painful to wait so long for linting-generated code.

• Try to derivate typing from the useGetEntities hook passed in props to this component
• Try to create types that will enforce that where, orderBy and proper request fields are present on the passed requests hooks

With the current setup it's easy to inadvertently erase a lot of records by mistake.

We should show a toast that defers sending the deletion request by a few seconds.

The deletion shouldn't still happen if I move to a new page.

See prototype here: https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=5215-59367&mode=design&t=3yzJPjValanNrceO-4

Concurrency issue between Postgres and Hasura
Setup failed for me because Postgres started right before Hasura, therefore Hasura failed to connect to the DB.
The solution was to restart the Hasura container once Postgres had been fully loaded.

Metadata issue
Second issue was that metadata were not in sync with migrations. The column deleted_at was missing, either from the model or from the db, I'm not sure.

• Frontend only

_{From SyncLinear.com | T-287}

Coming soon item in the navigation menu are to heigh 28px instead of 24px.

_{From SyncLinear.com | T-280}

To reproduce, open a comment thread and remove all the companies / persons, the last one should stay checked and if you click one more time on it it will throw this error.

Implement scoping of recoil atomFamily by using a generic react context.

The idea is to create a RecoilScope component that will be used to wrap a hierarchy of components.

Each component or hook called inside a RecoilScope component can then use something like :

useRecoilState(myAtomFamily(useContext(RecoilScopeContext)))

Which can be factorized to :

useRecoilState(myAtomFamily(useRecoilScope()))

See atomFamily documentation here : https://recoiljs.org/docs/api-reference/utils/atomFamily/#example

I should be able to field first name > tab > last name > tab > email > tab > company > tab, etc.

_{From SyncLinear.com | T-268}

_{From SyncLinear.com | T-289}

Since entity chips can have different max width, whether they are used in a table cell or a entity picker, they should handle themselves the text that is overflowing the max width.

We should also find a way to fix their max width :

• Have separate components wrapping a generic EntityChip component
• Giving width or max-width in a props

Currently each time we select / deselect an entity from the multi relation picker, it shows up empty during the network roundtrip, then shows the incoming data.

Here are 3 ways of doing it :

• Use optimistic rendering
• Use manual Apollo cache update
• Maybe we can make it work by playing with typePolicies of Apollo's MemoryCache

Current behavior :

• Go on company page
• Click on a comment bubble
• Add a company which has no associated comments in the relations on the comment thread
• A comment bubble should appear next to the company's name
• Click on it
• The comment drawer opens up and there is only one comment thread
• Refresh the app
• Click on the comment bubble again
• The drawer opens this time with all the comment threads

Expected behavior :

• The comment drawer should open with the multiple comment threads associated to the entity after it is associated to a comment thread by editing via the relation picker

It should be fixable by adding the right request in the refetch query array of some request in the page related to comment threads.

• Call the pipeline Sales
• Emoji 🎯
• Seed with following status:
  • New (type open, color xxx)
  • Ongoing (type open, color xxx)
  • Won (type closed, color xxx)
  • Lost (type closed, color xxx)

_{From SyncLinear.com | T-291}

https://github.com/KingSora/OverlayScrollbars

And apply it on every updateOne mutations

Introducing a new column and frontend component on company/people view:

• Backend to retrieve the workspace's pipelines

_{From SyncLinear.com | T-288}

The error is : ResizeObserver loop limit exceeded

New scope for this ticket:

• move sort and filters components into @/ui/sort and @/ui/filter
• these components should expose a simple API that direclty uses DropdownMenu, MenuItems, SingleSelect components + hooks to use them. Remove the current "configurable api"

Put all the FilterDropdownState information in a recoil state or context
read this state from FilterDropdown components to display the right dropdown content
make this "generic"
use DropdownMenu hook to pilot the dropdown itself
use existing filterDefinition recoil state to communicate with view system

null

_T-402

How it should look on mobile:

1. Left menu is hidden by default
2. Instead, show hamburger in top navbar to toggle left menu visibility. Center the top navbar title (aligned on the left currently / when in desktop mode)
3. Make sure the margins still look good when menu is hidden

_{From SyncLinear.com | T-233}

• First Name
• Last
• Email is READ only for now, it shouldn't be possible to change it

_{From SyncLinear.com | T-56}

From Logout button in settings panel

_{From SyncLinear.com | T-322}