twido / tmc Goto Github PK

Create deb package for easy installation.

Add .gitignore file. File should contain build directory and driver directory. Optionally IDE's files for QtCreator and Netbeans.

Hy,

Here are some issues I encountered during installation on a debian Sid.

• The 3d line of the Makefile didn't work on my shell, I had to blank the variable PATH_PREFIX.
• The Linker awaits ftd2xx to be copied in system library (at least, in /usr/local/lib/). This is specified in the ReadMe of the driver, but not in your documentation. An alternative could be to set the linker's library path differently.

What follows may be specific with Thorlabs TBD001 (but I don't think so...):

• In cmd.cpp, some device_calls functions are switched in conditional blocs of several command functions: StartRelMoveC, StartAbsMoveC (and perhaps StartJogMoveC, I didn't used this one). This make these commands unusable with TBD001 at least.
  For example, in StartRelMoveC, conditional bloc:

    if (dist_spec) ret = device_calls::StartSetRelativeMove(0x50, index);
    else ret = device_calls::StartRelativeMove(dist, 0x50, index); 

should be:

    if (dist_spec) ret = device_calls::StartRelativeMove(dist, 0x50, index); 
    else ret = device_calls::StartSetRelativeMove(0x50, index);

• TBD001 model is not set in 'functionsSet' of init.cpp (line 303).

These are more subjective:

• A tab/spaces at the beginning of each return of a command may enhance readability. For example:

relmove -h
    Start relative move. Distance can be either specified or previously set by relmovep command.
    -i NUMBER           index of motor to start move, default is 1
    -d VALUE            distance to move, if not specified parameter stored in device is used
relmove -d ...

• The very first message before prompt should be preceded by a blank line (I stupidly didn't see it the very first time !). By the way, It may be useful to write that '-h' option is available for every command (took me some time to figure that out).
  This is on line 1625 of file cmd.cpp. My proposition :
  printf("\nAwaiting commands. Type \"help\" to display available commands.\n(tip: \"-h\" option is available for all commands to obtain specific help)\n");

Great job anyway :-D

Integrate Qt tool moc to Makefile instead of having static files.

Graphical build on Ubuntu 16.04 fails due to wrong includes of qt lib. Fix and check if problem occurs in Debian 9 too.

Squash unnecessary commits.

Code is a mess. At least a quick refactor and use clang-format.