Comments (4)
Thanks for the bug report. We will look into this.
from twirp.
Still keeping this open.
from twirp.
Hello @faizanahmadsyed!
in v8.1.0
and onward, jsonSkipDefaults
is set to false
by default, and the NewBuilderServer
constructor no longer recognizes the JSONSkipDefaults
value. For reference, here's the note regarding that. We could potentially improve the comments in the options struct regarding deprecation of that value.
Two potential solutions would be:
- Use the options as illustrated in the docs:
builderHandler := rpc.NewBuilderServer(d.handlers.builder,
twirp.WithServerJSONSkipDefaults(true),
twirp.WithServiceHooks(defaultHooks()),
twirp.WithServerPathPrefix(pathPrefix))
- If still inclined to define reusable defaults, define
defaultOptions
and use them in the following way:
defaultOptions := []twirp.ServerOption{
twirp.WithServerJSONSkipDefaults(true),
twirp.WithServiceHooks(defaultHooks()),
}
opts := []twirp.ServerOption{}
opts = append(opts, defaultOptions...)
opts = append(opts, twirp.WithServerPathPrefix(pathPrefix))
builderHandler := rpc.NewBuilderServer(d.handlers.builder, opts...)
from twirp.
Given the explanation from @fpetelin, I am closing this issue.
from twirp.
Related Issues (20)
- Protocol inconsistency with implementation (data_loss) HOT 1
- Broken link in docs HOT 1
- Bug: Wrong generated file name error with `paths=imports` option & `module` option without trailing slash
- How to pronounce Twirp? HOT 1
- RFC 7807 HOT 1
- Proposal: write public constants for method names on code generation HOT 4
- Compatibility with `gogo/protobuf` HOT 2
- [Bug/Support] Running server/client on kubernetes cluster with containerd runtime HOT 3
- bilibili use this twirp?
- Fasthttp support HOT 5
- Provide auto-instrumentation for OpenTelemetry standard HOT 3
- Generated Code for sending JSON requests is not in the sending path HOT 3
- [Documentation] Use protocurl to interact with twirp protobuf endpoint instead of curl+protoc HOT 2
- Varying Success Status Codes HOT 2
- Multiple WithHTTPRequestHeaders HOT 4
- Allow Interceptor to return *dynamicpb.Message HOT 3
- Deprecated usage of `ioutil` HOT 2
- Response bodies are not read to EOF in certain cases, potentially causing TCP issues. HOT 2
- Twirp handler only works with mux.Handler, doesn't work with chi.Handler HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twirp.