Comments (2)
Hi. Apologies for the delay on a response.
We discussed this and came to the conclusion that because Twirp is not just a library at this point, but also a protocol that expects a status 200 for success, that making this change would not be easy. I think the custom metric is the correct approach at this point.
from twirp.
Thanks makes sense. A bug in something like this could cause some considerable pain. We only have a handful of spots we need it . Appreciate the detailed reply!
from twirp.
Related Issues (20)
- Broken link in docs HOT 1
- Bug: Wrong generated file name error with `paths=imports` option & `module` option without trailing slash
- How to pronounce Twirp? HOT 1
- RFC 7807 HOT 1
- Proposal: write public constants for method names on code generation HOT 4
- Compatibility with `gogo/protobuf` HOT 2
- TwirpServer Constructor not capturing ServerOptions in v8.1.2 HOT 4
- [Bug/Support] Running server/client on kubernetes cluster with containerd runtime HOT 3
- bilibili use this twirp?
- Fasthttp support HOT 5
- Provide auto-instrumentation for OpenTelemetry standard HOT 3
- Generated Code for sending JSON requests is not in the sending path HOT 3
- [Documentation] Use protocurl to interact with twirp protobuf endpoint instead of curl+protoc HOT 2
- Multiple WithHTTPRequestHeaders HOT 4
- Allow Interceptor to return *dynamicpb.Message HOT 3
- Deprecated usage of `ioutil` HOT 2
- Response bodies are not read to EOF in certain cases, potentially causing TCP issues. HOT 2
- Twirp handler only works with mux.Handler, doesn't work with chi.Handler HOT 3
- Documentation website domain triggers Chrome's warning HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twirp.