two9a / jsgb Goto Github PK

Windows defender keeps bothering be when i try and download the zip of this repo.

https://www.microsoft.com/security/portal/threat/encyclopedia/entry.aspx?name=Trojan%3aWin32%2fSprisky.C!cl&threatid=2147717869&enterprise=0

I trust you just putting this out here incase others have the same problem...

On initially downloading this the code does not seem to run at all. It appears that one possible issue is a minor typo in 'index.html'.

It looks like this:

<td class="regname">D</td><td class=reg" rel="d"></td>

There should be a " before reg.

Additionally the presentation of an non-existent '.gb' filename seems to cause the emulator some trouble. In addition to not working at all, it seems to cause all three tabs to show up in a vertical column (with the latter two not getting a header) rather than showing only the selected tab in the designated position. It appears to be a specific problem resulting from a wrong hardcoded value at page load. If you change the input field later to a non-existent file then it simply doesn't load that and retains the previous rom.

The sole 0x4C in _bios should be 0x3C
One of the c's in a 0x3C is lowercase
The second 0xF2 in _bios should be 0xE2

Source: compared with actual game boy bios
(sharing an actual game boy bios is illegal, this disassembly is accurate though to my game boy bios dump)

есть идея сделать эти кнопки на картинке как раз для задавания кнопок управления, а не для самого управления, соответственно надо будет как-то сопоставлять коды кнопок с названием

In z80.js line 669, the opcode 0x08 is mapped to a function "LDmmSP" which doesn't exist.
https://github.com/Two9A/jsGB/blob/master/js/z80.js#L669

LDmmSP appears in _map but doesn't appear to be implemented anywhere.

Hi,

you included a BIOS but do not use it after all.

Is this BIOS somehow needed, and why did you include it but do not use it in your demo?

Thanks in advance :)