typo3gmbh / site-intercept Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 6.0 6.75 MB

License: GNU General Public License v2.0

JavaScript 0.76% PHP 83.07% Shell 0.63% HTML 8.13% Twig 7.41%

site site-symfony template-bundle

site-intercept's People

Contributors

Stargazers

Watchers

Forkers

sypets lolli42 gilbertsoft linawolf brotkrueml

site-intercept's Issues

ErrorException: Warning: include(assets/css/error.css): failed to open stream: No such file or directory

Sentry Issue: INTERCEPT-4

ErrorException: Warning: include(assets/css/error.css): failed to open stream: No such file or directory
  File "/public/index.php", line 31
    $response = $kernel->handle($request);
...
(14 additional frame(s) were not displayed)

TYPO3 v10 compatible ext was displayed as v9.5

Hello,

I have just pushed EXT:sponsoring which is TYPO3 9.5 and 10.4 compatible. A WebHook calls your interceptor.
In list of interceptor I see that manual was only rendered for TYPO3 version 9.5 (column Support).
A little bit deeper I found EXT:headless which has support for 9.5-10.0. So it works in general.

Daniel Siepmann means it seems to be a problem with our 3 parts used TYPO3 version ^10.4.2. But as long as this version is officially supported it would be nice to support this kind of version, too.

Stefan

Syntax errors in redirects

@NeoBlack It seems like we have a syntax error in the redirects, see here: https://github.com/TYPO3-Documentation/t3docs-ci-deploy/actions/runs/4055265525/jobs/6978166160

err: nginx: [emerg] unexpected "}" in /etc/nginx/includes/docs_redirects/static_redirects.conf:106
err: nginx: configuration file /etc/nginx/nginx.conf test failed
out: Error while config check.
out: Something went wrong, I do a rollback

I can however find nothing wrong in the file. Could you have a look please?

Make the "create issue from core change" reusable for other projects

Some other projects could also use this:

Mask email addresses when creating new issues

Email addresses should be masked like ***@typo3.org to not reveal email addresses to the public which spammers could collect easily since these will be publicly exposed and nobody really likes to get spam emails.

https://stackoverflow.com/questions/20545301/partially-hide-email-address-in-php

What are the reasons for the very strict composer.json constraints for documentation to be rendered on docs.typo3.org

Currently for documentation of a package to be rendered on docs.typo3.org this package not only needs to be registered (and be approved) manually, but must also pass some automated checks regarding the composer.json

This does not work for packages like helhum/typo3-console (very complex workaround is in place to circumvent these constraints) or typo3/coding-standards (not yet on docs.typo3.org).

If there is a manual approval workflow anyway, why are there these strict automated tests as well? What is the purpose to have them?

Please add TYPO3 fluid to documentation

There was work done to migrate TYPO3 fluid project to follow our documentation setup.
We were unable to add them as inercept throws 500 status codes when adding via UI: https://github.com/TYPO3/Fluid.
Also adding the web hook ended up in 500 status codes.

Can you have a look and fix the issue so we can add the fluid documentation?

Q: How does the current webhook for docs rendering work?

I'd like to understand how we get from the GitHub webhook notification to the rendering and deployment of a manual.

I'm aware of

But what's going on when GitHub requests https://docs-hook.typo3.org ?
Which script is behind that?

Remove redirects for Extbase because they result in 404 for main (and should also be removed in 11.5)

will submit PR

main: Extbase: 404

https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/Extbase/Index.html

 curl -IL https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/Extbase/Index.html
location: https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/Concepts/Extbase.html

HTTP/2 404

11.5 Extbase: is: is now ok but I would suggest to also remove and unify the paths in all branches (or at least main and 11.5)

https://docs.typo3.org/m/typo3/reference-coreapi/11.5/en-us/ExtensionArchitecture/Extbase/Index.html

is ok

curl -IL https://docs.typo3.org/m/typo3/reference-coreapi/11.5/en-us/ExtensionArchitecture/Extbase/Index.html
location: https://docs.typo3.org/m/typo3/reference-coreapi/11.5/en-us/ExtensionArchitecture/Concepts/Extbase.html

HTTP/2 200

Would propose to make a change in 11.5 as well (in TYPO3 Explained) so that in main + 11.5 the file in the same for main + 11.5:

Documentation/ExtensionArchitecture/Extbase/Index.html

Bug: ajaxversions.php creates wrong links from singlehtml

How to reproduce

Good and expected behaviour

Visit
https://docs.typo3.org/services/ajaxversions.php?url=https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/

Get this output. It is used to fill the version switcher on our docs pages:

<dd><a href="/m/typo3/reference-coreapi/master/en-us/">master en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/draft/en-us/">draft en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/10.4/en-us/">10.4 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/9.5/en-us/">9.5 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/8.7/en-us/">8.7 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/7.6/en-us/">7.6 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/6.2/en-us/">6.2 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/master/en-us/singlehtml/">In one file: master en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/draft/en-us/singlehtml/">In one file: draft en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/10.4/en-us/singlehtml/">In one file: 10.4 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/9.5/en-us/singlehtml/">In one file: 9.5 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/8.7/en-us/singlehtml/">In one file: 8.7 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/7.6/en-us/singlehtml/">In one file: 7.6 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/6.2/en-us/singlehtml/">In one file: 6.2 en-us</a></dd>

Bad and buggy behaviour

Visit
https://docs.typo3.org/services/ajaxversions.php?url=https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/singlehtml/

We should get exactly the same output as before. Instead, there is singlehtml in some links where it shouldn't be:

<dd><a href="/m/typo3/reference-coreapi/master/en-us/singlehtml">master en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/draft/en-us/singlehtml">draft en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/10.4/en-us/singlehtml">10.4 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/9.5/en-us/singlehtml">9.5 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/8.7/en-us/singlehtml">8.7 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/7.6/en-us/singlehtml">7.6 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/6.2/en-us/singlehtml">6.2 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/master/en-us/singlehtml/">In one file: master en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/draft/en-us/singlehtml/">In one file: draft en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/10.4/en-us/singlehtml/">In one file: 10.4 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/9.5/en-us/singlehtml/">In one file: 9.5 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/8.7/en-us/singlehtml/">In one file: 8.7 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/7.6/en-us/singlehtml/">In one file: 7.6 en-us</a></dd>
<dd><a href="/m/typo3/reference-coreapi/6.2/en-us/singlehtml/">In one file: 6.2 en-us</a></dd>

See the bug in action

Try the version switcher here in the singlehtml version:
https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/singlehtml/

In contrast, in the html version the links are ok:
https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/