typr124 / fmtor Goto Github PK

*_or_else methods are typically used for lazy evaluation, where expensive work might be avoided. It may be surprising for users that the closure will be called every time the value is formatted, instead of once as maybe_string.unwrap_or_else(|| String::from("Eheh")) would.

It'd be fine to just add a note to the documentation explaining this behaviour, but it also highlights the issue that the fallback value must be 'static. Maybe there's an alternative API that could be more flexible.