Modelling empty lists and sets by omitting the property is understandable from a stora

For context, are you speaking about something like this? <div class="highlight hig

Our workaround: set convertEmptyVal

[Feature Request] Required container attributes can have empty values about electrodb HOT 2 OPEN

tywalch commented on May 25, 2024 2

[Feature Request] Required container attributes can have empty values

from electrodb.

Comments (2)

misterjoshua commented on May 25, 2024 1

For context, are you speaking about something like this?

/* Model queries, see results, share with friends */

import { Entity, Service } from "electrodb";

const table = "your_table_name";

/* Tasks Entity */
const listHolder = new Entity(
  {
    model: {
      entity: "listHolder",
      version: "1",
      service: "app"
    },
    attributes: {
      id: {
        type: 'string',
        required: true,
      },
      set: {
        type: 'set',
        items: 'string',
        required: true,
        default: [],
      },
    },
    indexes: {
      main: {
        pk: {
          field: 'pk',
          composite: ['id'],
        }
      }
    }
  },
  { table }
);

async function demonstrateIssue() {
  await listHolder
    .create({ id: 'example', set: [] })
    .go();

  const { data } = await listHolder
    .get({ id: 'example' })
    .go();

  if (!data) return;

  console.log(data.set.length); // TypeError: Cannot read property 'length' of undefined
}

This one got me today.

from electrodb.

0815Hunter commented on May 25, 2024 1

Our workaround:

set convertEmptyValues: true

DynamoDBDocumentClient.from(ddbClient, {
    marshallOptions: {
        convertEmptyValues: true, 
    },
})

Note that convertEmptyValues: true also sets empty strings / blobs to null, so you have to use a get() hook there too.

use a get() hook to replace null values:

attributes: {
        set: {
            type: 'set',
            required: true,
            items: ['A', 'B', 'C'] as const,
            get: (val: any, item: any) => val !== null ? val : [],
        },
    },

It's weird that the document client allows empty strings, but doesn't allow empty sets, even though it's possible to add empty sets manually in AWS.

from electrodb.

Recommend Projects