ubports / system-settings Goto Github PK

Moved to https://gitlab.com/ubports/core/lomiri-system-settings

Home Page: https://gitlab.com/ubports/core/lomiri-system-settings

License: GNU General Public License v3.0

CMake 3.33% C++ 44.56% QML 36.76% JavaScript 1.53% C 0.21% Python 13.62%

system-settings's Introduction

The System Settings application for Ubuntu Touch.

The upstream project is hosted on launchpad, the design on the Ubuntu wiki:
https://launchpad.net/ubuntu-system-settings
https://wiki.ubuntu.com/SystemSettings

system-settings's People

Contributors

Stargazers

Watchers

system-settings's Issues

Add generic caldav account: Keyboard does not show up

When clicking on the input fields, no keyboard shows up

Images in "Background" take a notable time to render

The images that the user is able to select in "Background" load pretty slowly, which can be offputting to a new user.

Perhaps this should be rendered in the background when systems settings is started? It rerenders every time the menu is opened.

16.04 devel hammerhead

[Enhancement] Downloaded Update Can't Be Installed Offline

Download system update
Enable flight mode

Expected:

to be able to install downloaded file

Actual behaviour:

Downloaded update dissapears

System Settings crashes

Device: Nexus 5 (hammerhead)
Channel: RC
Build: Ubuntu 16.04 (2018-W47)

Steps to reproduce

Go to System Settings > Security & Privacy > App permissions
System Settings crashes

Logfiles

system-settings.log (https://paste.ubuntu.com/p/j96NRynHsw/)
unity8.log (https://paste.ubuntu.com/p/PpWsWbw6hs/)

Create new category "Storage" - to migrate removable media there

This will be the settings item which will replace the ugly app-like thingie with the red SD card symbol.

Placeholder ticket, needs proper description soon.

Related to: ubports/ubuntu-touch#187

Add a "test keyboard" menu in "Language & Text" settings

It would be nice to be able to test any keyboard settings changes you just made immediately after making them, without having to find an app to act as a a guinea pig (plus switching back and forth, etc.)

A submenu in "Language & Text" would absolutely do the job.

16.04 devel hammerhead

[E5HD] Changing Hotspot Password with Hotspot on Makes Device Reboot

Steps to Reproduce:

Turn on hotspot (make sure is on: icon is on the indicator)
Open hotspot configuration
Change password and tap on save

Expected behaviour:

Configuration is saved

Current behaviour:

Spinner is on save until stops spinning
Device reboots

VPN Setting cipher dropdown is missing "cipher none" option

Refuses to build against latest upstream accountsservice

Arch GNU/Linux, bionic branch

/mnt/antihype/Projects/AUR/_Unity8/_Unity8-Arch/system-settings-git/src/system-settings/plugins/language/language-plugin.cpp: In member function ‘void LanguagePlugin::updateCurrentLanguage()’:
/mnt/antihype/Projects/AUR/_Unity8/_Unity8-Arch/system-settings-git/src/system-settings/plugins/language/language-plugin.cpp:233:13: error: ‘act_user_set_formats_locale’ was not declared in this scope
             act_user_set_formats_locale(m_user, qPrintable(formatsLocale));
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/mnt/antihype/Projects/AUR/_Unity8/_Unity8-Arch/system-settings-git/src/system-settings/plugins/language/language-plugin.cpp:233:13: note: suggested alternative: ‘act_user_set_real_name’
             act_user_set_formats_locale(m_user, qPrintable(formatsLocale));
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
             act_user_set_real_name
/mnt/antihype/Projects/AUR/_Unity8/_Unity8-Arch/system-settings-git/src/system-settings/plugins/language/language-plugin.cpp:235:35: error: ‘act_user_get_formats_locale’ was not declared in this scope
             QString formatsLocale(act_user_get_formats_locale(m_user));
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/mnt/antihype/Projects/AUR/_Unity8/_Unity8-Arch/system-settings-git/src/system-settings/plugins/language/language-plugin.cpp:235:35: note: suggested alternative: ‘act_user_get_real_name’
             QString formatsLocale(act_user_get_formats_locale(m_user));
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                                   act_user_get_real_name

/usr/include/accountsservice-1.0/act/act-user.h is in fact missing these functions

Clicking "Forget this network" doesn't kick the user back to the network list

When wanting to forget a network in the Wi-Fi settings, tapping "Forget this network" should either kick the user back to the list of networks they can connect to, or switch to a string like "Connect to this network" and hide "IP address". As it is right now, the user doesn't know anything happened.

16.04 devel hammerhead

VPN Settings page is missing auto-start option

VPN Setting page is missing auto-start option. When you setup a VPN and start it successfully, it will not retain it's ON status after a reboot of the phone

Keyboard layout list is slow to scroll

When accessing keyboard settings from the indicator menu, an exhaustive list of keyboard layouts is shown. If i want to select e.g Vietnameese i have to swipe bottom up 42 times. Any suggestions ?

Accessing keyboard layouts from Settings don't give you the full list, so it is not a pb

forget wifi connection option needs 'back' navigation to overview page

in: Wi-Fi --> Previous Networks --> [Selected network]
When using the ' Forget Network' option, The chosen network visibly doenst seem to get removed, when in fact it has been. It seems like that after removing the wifi stored connection, the page should go back to the main wifi-connections overview page (this is what happens in 15.04), but it doesnt do that.

Device: Meizu Pro 5
Channel: 16.04 RC (2018-W27)

[vivid] [xenial] Language aids interfere with TextFields

If «word suggestion» or «spell checking» is activated, interferes in TextFields like browser title bar or and other TextField that checks if TextField.text is empty and with clear button (x)

Example:
when typing text in browser address bar, browser history and suggestions should appear:

Image 1) Word suggestion and Spell checking off

Image 2) Word suggestion or Spell checking on

Wifi: enable static IP address configuration

Device: frieza
Channel: 16.04/stable
Version: OTA-8

Currently, connecting to a Wifi-network implicitly assumes the usage of DHCP.
It is not possible to manually configure the wireless network interface through system-settings.
This restriction is old [1] and well known:

"In future this screen might also allow entering a static IP address,
bug 1445772, and contain router and DNS information." [2]

Fortunately, ubports comes preinstalled with nmtui,
which can be used to configure a static IP address from the command line.

[1] https://bugs.launchpad.net/ubuntu/+source/indicator-network/+bug/1445772
[2] https://wiki.ubuntu.com/Networking#A.2BIBw-Wi-Fi.2BIB0_settings_.28phone.29

[Xenial] VPN Manual Configuration Is Not Translatable

The component that is open here, is not translatable. I can't find the qml
https://github.com/ubports/system-settings/blob/xenial/plugins/vpn/PageComponent.qml#L91

add values higher than 10 minutes to "Lock when idle" in SystemSettings

as a feature request:
sometimes I need the phone to be unlocked for slightly more than 10 minutes (e.g. 15 or 20 minutes)
In this case I usally set "Lock when idle" to "never", and switch it back to 10 minutes later (which is the highest available value right now)

If I forget switching it back, the screen could remain on forever (and discharge the phone quickly)

So adding more options to this list (or a custom value) would be helpful.

"Previous networks" should probably be "Saved networks" or similar

The past tense of "Previous" implies that you can't connect to the given networks anymore, that it's in the past. Perhaps this should be changed to "Saved networks" or "Saved connections"

16.04 devel hammerhead

Switching channel

Device: turbo
Channel: devel
Build: 24

The possibility of choosing upgrade channel in turbo device doesn't work. I choose
Settings -> Updates -> Update settngs (yes, there is an error here, there is an "i" missing) -> Channels and there there is an empty list with the tile "Channel to get updates from".

A change in Qt 5.11_beta3 leads to errors

Arch GNU/Linux, bionic branch

CMake Error at lib/SystemSettings/CMakeLists.txt:7 (qt5_use_modules):
  Unknown CMake command "qt5_use_modules".

CMake Error at plugins/background/CMakeLists.txt:12 (qt5_use_modules):
  Unknown CMake command "qt5_use_modules".

CMake Error at plugins/battery/plugin/CMakeLists.txt:9 (qt5_use_modules):
  Unknown CMake command "qt5_use_modules".

CMake Error at plugins/battery/CMakeLists.txt:13 (qt5_use_modules):
  Unknown CMake command "qt5_use_modules".

According to the official Qt documentation qt5_use_modules macro is obsolete

Same as ubports/ubuntu-download-manager#4

Connecting to a wifi network

In the wifi settings, when selecting a wifi network it immediately says "connected" while the phone is in fact not connected to the network yet and it doesn't have an IP assigned yet. It should say "connecting" instead and then say "connected" only when it has an IP.

Another thing related: when it says "connected" while it is still trying to get an IP, I can see that it doesn't have an IP yet by clicking on the network. There, a new screen opens where there is no IP displayed. Now: this screen though does not auto-refresh itself and the IP does not appear here when it finally gets one. I have to exit to the previous screen and click on the network again in order to see the IP.

Hotspot in Nexus 4

Hi,
Nexus 4 does not have Hotspot. Why?

Auth SHA256 unavailable for VPN

Hello Team,

I am trying to connect a fairphone to an openvpn server through the system vpn but as I have enable "auth SHA256" on the openvpn server I am not able to connect to it as I can't add the option "auth SHA256" in the "manual configuration".

Is there a workaround?

Server conf:
local *.*.*.*
port 1194
proto udp
dev tun
ca x.crt
cert x.crt
key x.key
dh x.pem
server 10.8.0.0 255.255.255.0
ifconfig-pool-persist ipp.txt
push "redirect-gateway def1 bypass-dhcp"
push "dhcp-option DNS 194.134.4.1"
push "dhcp-option DNS 194.134.0.49"
keepalive 10 120
tls-auth x.key 0
cipher AES-256-CBC
user nobody
group nobody
persist-key
persist-tun
status openvpn-status.log
log-append /var/log/openvpn.log
verb 5
explicit-exit-notify 1
key-direction 0
auth SHA256

client conf:
client
dev tun
proto udp
remote x.x.x.x 1194
resolv-retry infinite
nobind
persist-key
persist-tun
ca x.crt
cert x.crt
key x.key
remote-cert-tls server
tls-auth x.key 1
cipher AES-256-CBC
verb 3
auth SHA256
key-direction 1

Infos:
Phone: Fairphone 2
OS: Ubuntu 16.0.4 (OTA-7)
openvpn server: OpenVPN 2.4.6
OS : Fedora release 27
openvpn client: 2.4.6
OS : win 10 pro

Thanks for your help!

Regards,

Steackfrite

Improve `Reinstall all apps` UX

Asked this in UX Telegram group before opening this issue:

Relatively new UBports user, browsing through the settings to gain familiarity. Come across Settings > Updates > Update settings > Reinstall all apps. Now this has the > on the right side, indicating a further menu/page. Of course, there is another page but the reinstallation commences immediately, without any chance to confirm that action. No obvious way to back out once this starts, either. From a UX perspective, I would be expecting to browse the menu/page and then hitting a button to start this process.

Reinstall all apps does not get translated

The text "Reinstall all apps" does not get translated (System settings -> updates -> update settings).
I could not find it on weblate available for translation (i.e. search for reinstall).
BQ E5 with 16.04 rc 2018-W48

Updates don't detect/download on non-wifi connection

Device: hammerhead
Channel: 16.04/devel
build: 2018-10-29/2

Even though "automatic updates" is set to only on "wifi", the system should still detect that there is a new update and allow you the choice to download or not on a mobile data connection.

Instead, the update does not even show that it's available.

[Enhancement] Add to possibility to configure a VPN by importing a .ovpn file

As explained in this article, it is possible to configure manually a VPN through the System Settings.

However, the process is quite complex and time consuming.
We could imagine below the "Add Manual Configuration..." button a "Add Preset Configuration..." button to import a .ovpn file, define the user name and the password and review advanced options only if necessary.

Please add dark mode

SuruDark works already good within the app. Would be great having the choice in the settings. Like in the Messaging App.

Bluetooth: Reorder List of connectable Devices

At first use I thought that Bluetooth do not work correct. All entries had a "Unknown" as Name. I had to scroll the whole list to the bottom until the first named Bluetooth appeared.

Please list named devices at first.

tap twice on storage results in missing back button on storage page

E5, RC 2019-W20

Steps to reproduce:

open system settings
open info
tap storage once
tap storage a second time before the page is opened

expected result:

storage page is loaded, back button available

actual result:

storage page is loaded
page does load storage values (circles appear for a few seconds)
after storage values are loaded the back button disappears

reproducible:

always when tapping twice
never when tapping only once

Ubuntu touch -> Ubuntu Touch

When updating my phone, shouldn't "Ubuntu touch" instead be "Ubuntu Touch"?

16.04 devel hammerhead

Updated Channel Settings does not reflect on "Update" Screen and "Update settings" Screen

System Settings - Updates screen
Does not show the currently choosen Channel.

Also under
System Settings - Updates - Update settings - Channels.
When another channel is choosen (a tick mark confirms it) followed by back arrow on left top, the Update settings screen does not reflect the changed channel. It only shows the previously choosen channel ! Even if we go into Channels again and come out, it will not.

And if we come out by another back arrow, the Updates screen does not show the current choosen channel. The user might be under the impression that the channel had NOT been changed.

It is better to display the current channel on "Updates" Screen.
"Update settings" should show the changed channel name.

Thanks

@NatarajanNNapoleon

[audio plugin] provide options to set output device

there is no support for setting pulseaudio sinks (useful for the desktop session)

Dash background becomes black when enabling Dash background

Steps to replicate:

Do a fresh install of Ubuntu Touch.
Go to the settings app and enable Dash Background under Background section

Expected:
The dash background is set to the default background image.

Actual:
The dash background becomes black.

Other observations:
This can be fixed by changing the background image so it seems that this only happens when you've never changed the default background image yet.

Device:
Nexus 7 15.04/rc
Nexus 5 16.04/devel

Fix failing CI builds for all recent PRs

This discussion began in the Ubuntu Touch App Dev Telegram group. Copying main parts here and adding further details below.

Currently open PRs

There are 5 PRs, all of them failing except the earliest one (#72), which was opened on Aug 11, 2018

This one PR has a completely different build output to the ones since then -- so I'm claiming that something has changed since Aug 11, 2018

Summary of the 10 tests that are failing

3/30 Test #3: tst-systemimage .....................***Failed

9/30 Test #9: testsystemupdate_global .............***Failed

10/30 Test #10: testsystemupdate_pagecomponent ......***Failed

11/30 Test #11: testsystemupdate_entrycomponent .....***Failed

13/30 Test #13: testsystemupdate_download_handler ...***Failed

18/30 Test #18: tst-clickmanager ....................***Exception: Other

19/30 Test #19: tst-imagemanager ....................***Exception: Other

20/30 Test #20: tst-updatemanager ...................***Exception: Other

21/30 Test #21: tst-updatedb ........................***Exception: Other

23/30 Test #23: tst-updatemodel .....................***Exception: Other

More recent build issue

One last build issue, which differed more recently:
/var/lib/jenkins/workspace/orts_system-settings_PR-102-...
Missing the p from orts_system-settings, unlike some of the other broken builds

Failure details for all 10 tests

In the sample below, I've trimmed out the following from the paths in order make it easier to locate the specific errors:

/build\/varlibjenkinsworkspaceortssystemsettingsPRWREEQYVDAJRTHUVOOMQOXFEOMVJOHUZNXQENBVVZAubuntusystemsettingsubportsgbpeddsc

Note, these breakdowns may not be exhaustive but they should be useful enough to help track down the underlying issues.

1. `3/30 Test #3: tst-systemimage .....................***Failed`

FAIL!  : TstSystemImage::testDetailedVersionDetails() Compared values are not the same
   Loc: [.../tests/tst_systemimage.cpp(83)]

2. `9/30 Test #9: testsystemupdate_global .............***Failed`

file://.../tests/plugins/system-update/tst_systemupdate_global.qml:35:9: Type GlobalUpdateControls unavailable 
             GlobalUpdateControls { 
             ^
file://.../plugins/system-update/Global.qml: No such file or directory

3. `10/30 Test #10: testsystemupdate_pagecomponent ......***Failed`

FAIL!  : qmltestrunner::PageComponentBatchModeTestCase::test_clicksAndImageAlreadyDownloaded() function returned unexpected result
   Actual   (): false
   Expected (): true
   Loc: [.../tests/plugins/system-update/tst_systemupdate_pagecomponent.qml(350)]

4. `11/30 Test #11: testsystemupdate_entrycomponent .....***Failed`

FAIL!  : qmltestrunner::EntryComponentNoImageUpdateTestCase::test_clickUpdates() item did not have the correct height when we had click updates
   Actual   (): 0
   Expected (): 52
   Loc: [.../tests/plugins/system-update/tst_systemupdate_entrycomponent.qml(73)]

5. `13/30 Test #13: testsystemupdate_download_handler ...***Failed`

FAIL!  : qmltestrunner::DownloadHandlerTestNoExistingDownloads::test_downloadExists() Uncaught exception: Cannot read property 'updateState' of undefined
   Loc: [.../tests/plugins/system-update/tst_systemupdate_download_handler.qml(211)]

6. `18/30 Test #18: tst-clickmanager ....................***Exception: Other`

QFATAL : TstClickManager::testSynchronization(One installed) Received signal 11
         Function time: 0ms Total time: 2ms
FAIL!  : TstClickManager::testSynchronization(One installed) Received a fatal error.
   Loc: [Unknown file(0)]

7. `19/30 Test #19: tst-imagemanager ....................***Exception: Other`

FAIL!  : TstImageManager::testUpdateAvailableStatus((auto) paused) '!u.isNull()' returned FALSE. ()
   Loc: [.../tests/plugins/system-update/tst_imagemanager.cpp(151)]

8. `20/30 Test #20: tst-updatemanager ...................***Exception: Other`

FAIL!  : TstUpdateManager::testCheckRequired(Now) 'q.exec()' returned FALSE. ()
   Loc: [.../tests/plugins/system-update/tst_updatemanager.cpp(80)]

9. `21/30 Test #21: tst-updatedb ........................***Exception: Other`

FAIL!  : TstUpdateDb::testRemoveUpdate() Compared values are not the same
   Actual   (((changedSpy.count()))): 1
   Expected (2)                     : 2
   Loc: [.../tests/plugins/system-update/tst_updatedb.cpp(79)]

10. `23/30 Test #23: tst-updatemodel .....................***Exception: Other`

FAIL!  : TstUpdateModel::testAdd() Compared values are not the same
   Actual   (((insertedSpy.count()))): 0
   Expected (1)                      : 1
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(88)]
...
FAIL!  : TstUpdateModel::testAddMultiple() Compared values are not the same
   Actual   (m_model->rowCount()): 0
   Expected (3)                  : 3
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(107)]
...
FAIL!  : TstUpdateModel::testRemove() Compared values are not the same
   Actual   (((removeSpy.count()))): 0
   Expected (1)                    : 1
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(118)]
...
FAIL!  : TstUpdateModel::testChange() Compared values are not the same
   Actual   (((dataChangedSpy.count()))): 0
   Expected (1)                         : 1
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(137)]
...
FAIL!  : TstUpdateModel::testMultipleChanges() Compared values are not the same
   Actual   (((dataChangedSpy.count()))): 0
   Expected (3)                         : 3
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(178)]
...
FAIL!  : TstUpdateModel::testRoles(KindRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(uint,2)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(IdRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,test)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(IdRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,v1)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(RemoteVersionRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,0.2)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(RevisionRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(int,42)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(TitleRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,Test App)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(DownloadHashRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,987654323456789)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(DownloadIdRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,someuuid)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(SizeRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(int,1000)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(IconUrlRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,http://example.org/testapp.png)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(DownloadUrlRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,http://example.org/testapp.click)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(CommandRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QStringList,<value not representable as string>)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(ChangelogRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,* Fixed all bugs * Introduced new bugs)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(TokenRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,token)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(ProgressRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(int,50)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(UpdateStateRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(uint,10)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(ErrorRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,Failure)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(PackageNameRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,testapp)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(SignedDownloadUrlRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QString,signedUrl)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testRoles(UpdatedAtRole) Compared values are not the same
   Actual   (m_model->data(m_model->index(0), role)): QVariant()
   Expected (value)                                 : QVariant(QDateTime,2018-11-08T23:24:34Z)
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(337)]
...
FAIL!  : TstUpdateModel::testCreatedAtRole() 'm_model->data( m_model->index(0), UpdateModel::CreatedAtRole).toDateTime().isValid()' returned FALSE. ()
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(346)]
...
FAIL!  : TstUpdateModel::testImageUpdate() Compared values are not the same
   Actual   (m_model->rowCount()): 0
   Expected (1)                  : 1
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(356)]
...
FAIL!  : TstUpdateModel::testSetAvailable() '!update1.isNull()' returned FALSE. ()
   Loc: [.../tests/plugins/system-update/tst_updatemodel.cpp(378)]

Un-intuitive password change process for 4-digit passcode

If you go to system settings / security & privacy / locking and unlocking / lock security you have 3 options: swipe (no security), 4-digit passcode and passphrase.

For the 4-digit passcode, once you have set it, does not have a 'change passcode' option. The way I have to change it is to change to 'swipe (no security)' and then go back into 4-digit passcode to create an updated passcode.

What I expect is exactly what is in the 'passphrase' option where you can enter:

existing passcode
choose new passcode
confirm passcode

Thanks!

System Settings is unresponsive while update is being downloaded

Discussed this in the Telegram SuperGroup and also confirmed by @jonnius:

myii, [18.04.19 21:56]

myii, [18.04.19 21:56]
Tried to download a system update on devel. It got stuck while downloading.

myii, [18.04.19 21:57]
Every time I open Systems Settings, it's now frozen with the part shown in the image above.

myii, [18.04.19 21:58]
OK, it's just started working after a number of minutes.

myii, [18.04.19 21:58]
Seems to get stuck while downloading the update.

Jonatan Hatakeyama Zeidler, [19.04.19 05:56]
[In reply to myii]
Happens for me all the time

Keyboard themes aren't descriptive enough

There should either be a preview for the keyboard theme or some sort of color description or something describing each keyboard layout under "Language & Text". New users probably won't know what a "Suru" is, and either way, would probably want to see what they're getting for a theme.

16.04 devel hammerhead

Auto cache cleaning

i think it is important to have an option to clean the cache or an automatic way to do this.

After a couple of days i need to clean the cache manualy to be able to update the system.

A idea could be, after removing "update" from the last updated list in setting, this update can be removed from the partition, so the user doesn't need to take this task....

or on a reload of new updates, it look for the one that are 2-3 update ago and delete it(no looking on the time as Stable needs more time than Devel ).

this is only my opinion, the "normal" user don't clean cache manualy

System update notification icons are reversed

In the notification for the system updates, the symbolic icon is placed on the left side, which has an inset UbuntuShape, and is not colorized, while the app icon is unshaped and on the right side. This is a bit ugly, as the app icon is meant to be cropped to shape, while the symbolic icon is meant to be colorized.

[Xenial] Where is printing?

Device: Nexus 4
Channel: Dev
Build: 2018-08-10

After entering "Print", only the category in which the printing is to be displayed is displayed.
Look at this screenshots.

[enhancment] different backround image for dash and lock screen

I would like to have the option to choose a different background image for lock screen and dash.
For the lock screen the background image can be a nice lively photo or something.
For the dash you do need a background that is less busy (?, more even colors), so you can easily see all the app icons.
Therefore I think having the option to set two different images like in Ubuntu would be nice.

Radio settings (APN) need options for MCC and MNC

Certain providers will require slight tuning of MCC and MNC:

If one cannot enter or change those numbers then connectivity and roaming might be impaired.

Add 3G/4G as connection

At moment there are no connection types without 2G. Please add a 3G/4G connection.

Tests failing to build in trust store mock

Builds are failing in xenial branch with the following error:

[ 77%] Building CXX object tests/plugins/security-privacy/CMakeFiles/tst-trust-store-model.dir/tst_trust_store_model.cpp.o

cd /build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/obj-x86_64-linux-gnu/tests/plugins/security-privacy && /usr/lib/ccache/x86_64-linux-gnu-g++   -DDATA_DIR=\"/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/tests/plugins/security-privacy/data\" -DI18N_DOMAIN=\"ubuntu-system-settings\" -DMANIFEST_DIR=\"data\" -DPLUGIN_MANIFEST_DIR=\"/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/tests/data\" -DPLUGIN_MODULE_DIR=\"/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/obj-x86_64-linux-gnu/tests\" -DPLUGIN_PRIVATE_MODULE_DIR=\"/usr/lib/x86_64-linux-gnu/ubuntu-system-settings/private\" -DPLUGIN_QML_DIR=\"/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/obj-x86_64-linux-gnu/tests\" -DQML_DIR=\"/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/obj-x86_64-linux-gnu/tests\" -DQML_TEST_DIR=\"/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/tests\" -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_QML_LIB -DQT_TESTCASE_BUILDDIR=\"/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/obj-x86_64-linux-gnu\" -DQT_TESTLIB_LIB -DSYSTEM_IMAGE_DBUS_TEMPLATE=\"/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/tests/autopilot/ubuntu_system_settings/tests/systemimage.py\" -DTESTS -I/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/lib -I/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/src -I/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/tests/../src -I/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/obj-x86_64-linux-gnu/tests -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libqtdbusmock-1 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/include/x86_64-linux-gnu/qt5 -I/usr/include/libqtdbustest-1 -I/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/obj-x86_64-linux-gnu/tests/plugins/security-privacy -I/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/tests/plugins/security-privacy/../../../plugins/security-privacy -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -isystem /usr/include/x86_64-linux-gnu/qt5/QtQml -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtTest  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -std=c++0x -fno-permissive -pedantic -Wall -Wextra   -fPIC -std=gnu++11 -o CMakeFiles/tst-trust-store-model.dir/tst_trust_store_model.cpp.o -c /build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/tests/plugins/security-privacy/tst_trust_store_model.cpp

/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/tests/plugins/security-privacy/tst_trust_store_model.cpp: In member function 'void TrustStoreModelTest::init()':

/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/tests/plugins/security-privacy/tst_trust_store_model.cpp:242:54: error: invalid new-expression of abstract class type '{anonymous}::mock::Store'

     m_store = std::shared_ptr<mock::Store>(new mock::Store);

                                                      ^

/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/tests/plugins/security-privacy/tst_trust_store_model.cpp:33:8: note:   because the following virtual functions are pure within '{anonymous}::mock::Store':

 struct Store: public core::trust::Store

        ^

In file included from /build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/tests/plugins/security-privacy/tst_trust_store_model.cpp:24:0:

/usr/include/core/trust/store.h:181:18: note: 	virtual void core::trust::Store::remove_application(const string&)

     virtual void remove_application(const std::string& id) = 0;

                  ^

tests/plugins/security-privacy/CMakeFiles/tst-trust-store-model.dir/build.make:65: recipe for target 'tests/plugins/security-privacy/CMakeFiles/tst-trust-store-model.dir/tst_trust_store_model.cpp.o' failed

make[4]: *** [tests/plugins/security-privacy/CMakeFiles/tst-trust-store-model.dir/tst_trust_store_model.cpp.o] Error 1

make[4]: Leaving directory '/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/obj-x86_64-linux-gnu'

CMakeFiles/Makefile2:7870: recipe for target 'tests/plugins/security-privacy/CMakeFiles/tst-trust-store-model.dir/all' failed

make[3]: *** [tests/plugins/security-privacy/CMakeFiles/tst-trust-store-model.dir/all] Error 2

make[3]: Leaving directory '/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/obj-x86_64-linux-gnu'

Makefile:141: recipe for target 'all' failed

make[2]: *** [all] Error 2

make[2]: Leaving directory '/build/varlibjenkinsworkspaceubportssystemsettingsPRubuntusystemsettingsubportsgbpcdbdsc/obj-x86_64-linux-gnu'

dh_auto_build: make -j1 returned exit code 2

Add option whether to remember updates

It would be nice to have an option to select, whether completed updates should be stored to history or not. Always removing them by hand is annoying.

[Xenial] Some elements hidden by Header

Open Notifications > app
First item «enable notifications» switch is hidden behind header
Flickable is bad anchored? So it doesn't flick making imposible to access the switch

Updates install button doesn't process

Device: Hammerhead
Channel: 16.04/devel
Build: 2018-10-29/2

Steps to Reproduce:

Open System Settings
Go to updates and download update
Press "install"
Press "Restart & Install"

Expected:

System reboots and installs

Actual:

"Update System" dialogue goes away and nothing happens. No Reboot etc.

Comments:
This behaviour happens quite frequently, and often resolves with multiple attempts. On this build I have tried at least 10 times without the system rebooting/installing.

System Settings can't fetch app-updates from certain apps in OpenStore

As the title said system-settings can't fetch some app-updates from certain apps from OpenStore.

How to reproduce? Just wipe your phone, then open each app (OpenStore and SystemSettings). Check my file attached.

Device:FP2
Channel:Devel
Version:270

"Brightness & Display" Adjust automatically checkbox is a bit sticky

I'm able to tap the "Adjust automatically" checkbox maybe once, but after that it refuses to toggle or do anything. If I swipe down and adjust it from the notifications menu (for lack of a better term) it works, and it reflects it in the settings menu, but I still can't toggle it.

16.04 devel hammerhead

ubports / system-settings Goto Github PK

system-settings's Introduction

system-settings's People

Contributors

Stargazers

Watchers

Forkers

system-settings's Issues

Steps to reproduce

Logfiles

Currently open PRs

Summary of the 10 tests that are failing

More recent build issue

Failure details for all 10 tests

1. 3/30 Test #3: tst-systemimage .....................***Failed

2. 9/30 Test #9: testsystemupdate_global .............***Failed

3. 10/30 Test #10: testsystemupdate_pagecomponent ......***Failed

4. 11/30 Test #11: testsystemupdate_entrycomponent .....***Failed

5. 13/30 Test #13: testsystemupdate_download_handler ...***Failed

6. 18/30 Test #18: tst-clickmanager ....................***Exception: Other

7. 19/30 Test #19: tst-imagemanager ....................***Exception: Other

8. 20/30 Test #20: tst-updatemanager ...................***Exception: Other

9. 21/30 Test #21: tst-updatedb ........................***Exception: Other

10. 23/30 Test #23: tst-updatemodel .....................***Exception: Other

Recommend Projects

Recommend Topics

Recommend Org

1. `3/30 Test #3: tst-systemimage .....................***Failed`

2. `9/30 Test #9: testsystemupdate_global .............***Failed`

3. `10/30 Test #10: testsystemupdate_pagecomponent ......***Failed`

4. `11/30 Test #11: testsystemupdate_entrycomponent .....***Failed`

5. `13/30 Test #13: testsystemupdate_download_handler ...***Failed`

6. `18/30 Test #18: tst-clickmanager ....................***Exception: Other`

7. `19/30 Test #19: tst-imagemanager ....................***Exception: Other`

8. `20/30 Test #20: tst-updatemanager ...................***Exception: Other`

9. `21/30 Test #21: tst-updatedb ........................***Exception: Other`

10. `23/30 Test #23: tst-updatemodel .....................***Exception: Other`