@reshnashrestha , Is it all okay with part 1?? Or do you still need to add some? Can I start the documentation part taking reference from your work?

@reshnashrestha Hope you have done your part. Please have a look once to analyze your algorithm and results so that I can proceed for further process.

When you have your unit test file finished, make sure to change the file name to run the finished file in your unit test action, as on line

Who is doing task 2 in your group? Need to ask something.

Hi guys, as we are already here, we need to discuss which station data are we going to use.

Hi all,
Your group's progress is impressive. I think you're all set once you add the Linting Action for your tasks.

What could be the proper frequency units for the data?

As Dr. Tim suggested, we need to upload the py file instead of ipynb file since we have to do the unit testing using a Github workflow. You can consider it.
Thanks for your time.

@tirthbha I have added the license file to this hw, could you please review it and then accept it.

This task (the documentation, github actions for linting and unit tests and to write unit tests for Task1 and Task 2)
is assigned to @poojashresthacode

Has anyone figured out the function for actual frequency?

Have you guys selected the data? Please let us know.

Hi @tirthbha , Can you make the label naming "Request". I need to use that label.

Just a reminder that task 3 requires the creation of a github action for linting. You can just reuse one from a prior project, but make sure you include it if you have the time to do so!

I would like to do task 1 if there is no problem. @tirthbha @poojashresthacode

What is the frequency you have received using this code? And also what is its unit?

Do we need to include graph in Documentation?

Should the file be in py format? Or ipynb works fine for task 1? @laserlab

Who shall be the maintainer?

Cape Kumukahi, Hawaii, United States (KUM)

@tirthbha thank you for sharing the code but it has an issue in it. The frequency returned by your second function is zero which doesn't seem right to me. Any way you could fix it.

As there are many files in the task 2 folder, I am a bit confused about doing unit test. Can you provide a brief insight? @tirthbha

This task is assigned to @tirthbha. I'll notify you as soon as I finish my task.

@reshnashrestha I think, if I were not wrong, ipynb format will not work for the Github Action. Can you please create those code in .py format.

https://gml.noaa.gov/dv/data/index.php?category=Greenhouse%2BGases&parameter_name=Carbon%2BDioxide&frequency=Monthly%2BAverages&search=sand+island

This task (the documentation, github actions for linting and unit tests and to write unit tests for Task1 and Task 2)
is assigned to @poojashresthacode.

Hi all,
We have chosen St. Croix, Virgin Islands, United States (AVI) station for our data reference.

we G3 choose Ascension Island, United Kingdom (ASC)

Are we supposed to perform inverse fft on the original X or the filtered X?

What is your frequency?

Lets choose the station "Sand Island, Midway, United States (MID)", under the category of Greenhouse Gases, with the specific parameter being Carbon Dioxide (CO2), and the data frequency is noted as Monthly Averages.
This is from my viewpoint guys @reshnashrestha @poojashresthacode. What do you think?

Hi all, as we need to create two unit testing (one for calculating the actual frequency and another for the peak frequency) py files, Can we do these two unit testings in one single action workflow file or add two separate unit testing action workflow files?

Did you use the same data, used in the class?

@poojashresthacode just a suggestion, you can add references in the documentation. And as we are taking code reference from ubsuny comphys, it will be better to cite it.

Hi @tirthbha
You have just merged a .py file. Is it task 1 or task 2? You have defined a function in that file for the frequency, but this requirement is for task 1, you are supposed to do task 2. Or maybe clarify for me if it is related to task 2??

Can someone briefly explain how they have implemented padding and windowing?

I have applied heavyside. Is there any other suggestion.

What are we supposed to do to address the task (Write a function that calculates the actual frequency in useful units)? Any help will be appreciated.

how did you guys find the frequency is it after fft?

Hi all,
You still didn't do the documentation part, and so did we.
I need some clarification regarding the documentation. In your project, who is going to do the documentation part?
Can you please respond?

Hey just a reminder that we have to set milestones for our homework tasks.

The due for hw5 have been extended till wednesday.

@tirthbha as a maintainer, can you make sure to add new labels that will be helpful to highlight the issues?

Do we need to create github action only for the unit test and linting?

Can I ask which data are you guys taking? I think it should be fine with whatever data we take, right?

We have to have 30 conversations to get the full marks. How can I check the number of conversations I made? Thank you.

Let's divide our work.

Hi Reshna, there are two ipynb file created by you. Can you please explain me about these? It somehow looks similar,

@tirthbha and @poojashresthacode I am thinking of making a library file that will have all the functions that we are using under it, so that our work will be convenient and it will be easier to follow other tasks as well. specially for unit tests.
I will do this later on FYI.

Not exactly sure how to do this. Any suggestions?