ucf / brand-theme Goto Github PK

Accessibility Fixes

• Add underline to links
• Add skip to content link

Currently, it's impossible to assign a .h2 class to a <h1> element without having Archer set as the font family. Ideally, we should be able to adjust heading sizes using these heading utility classes without the font family also being impacted.

This issue stems from the fact that a good number of pages on the Brand site have no <h1>. We can't currently assign a <h1> without modifying those headings' styles.

Look into replacing with wp_remote_get() (preferred) or cURL.

Remove the ability to replace the WP site search with the now-defunct Google Search Appliance. This will include relevant theme options, updates to search.php, and the removal of related JS logic.

create_function() was deprecated as of PHP 7.2. Instances of this this function throughout the repo should be removed and replaced with anonymous functions to support newer versions of PHP.

See https://www.php.net/manual/en/function.create-function.php

It looks like ldap_required() is capable of calling ldap_destroy_session() multiple times in a single page load, which will throw a session_destroy(): Trying to destroy uninitialized session warning.

This situation occurs when a user logs in to the UIL lookup, then clicks the "log out" link at the top of the page. I'm not sure yet if there's any other instances where this would occur.

https://github.com/UCF/Brand-Theme/blob/master/functions.php#L119-L176

Because we use title-tag theme support instead of wp_title() to print a <title> tag in the document head, this function has no effect and should be removed.