ucf / pegasus-theme Goto Github PK

Update /v6/ functions.php, shortcodes.php, page.php, single-photo_essay.php and any other related or referenced functionality/markup/styles.

The current social share buttons are outdated style-wise and content-wise.

Replace the social buttons on the sub-footer, header, and story template. Also, ensure that older version's social functions do not conflict with the UCF-Social-Plugin's functions.

Changes were previously made to the v6 footer file but reverted since it was out of scope of that PR: See 132c2a8. Those should be good to cherry pick for these updates.

Update /v6/footer-front.php, /v6/footer.php, /v6/header-front.php, /v6/header.php and any other related or referenced functionality/markup/styles.

Update the screenshot for the theme before it is tagged next.

These font files are no longer referenced in Production and should be removed from the project.

Update JS in /v6/static/js/ as necessary. Some JS might have already been updated with previous Athena updates in this project. This should be completed towards the end of the project to update any remaining functionality and ensure that previous version's stories/pages/etc work correctly.

Update front-page.php, index.php, page.php, 404.php, and single.php to use Athena markup. This might be dependant on the current issue's version being set to 6+, so make sure to take that into consideration. The front-end should still be functional and look correctly if the current issue is set to v5.

The iPad app hasn't been a thing for a while. We have some leftover settings, markup and js logic still floating around for it that are still impacting frontend markup; the old "available on iPad!" modal in particular is getting flagged in Siteimprove for not being within an ARIA landmark. Removing these should help resolve those accessibility issues and help reduce a little bit of cruft in the theme and WP admin.

Update versions/v6/templates/issue/default.php, versions/v6/templates/story/default.php, versions/v6/templates/story/photo_essay.php with Athena markup. Also update the related scss files and functions.

We need to make sure issues that haven't been "published" yet don't show up in the issue list.

https://github.com/UCF/Pegasus-Theme/blob/rc-v6.0.0/versions/v6/functions/config.php#L22

Upgrade to latest 3.x version.

#77 (comment)

The pages in PROD have bootstrap markup in the wysiwyg editor that will have to be updated to utilize Athena markup and shortcodes. We can copy over the pages from PROD into QA and update them there, ready to update post-deployment.

The pages:

• https://www.ucf.edu/pegasus/about/
• https://www.ucf.edu/pegasus/archives/
• https://www.ucf.edu/pegasus/contribute/
• https://www.ucf.edu/pegasus/give/
• https://www.ucf.edu/pegasus/our-awards/
• https://www.ucf.edu/pegasus/suggest-a-story/
• https://www.ucf.edu/pegasus/tell-us-what-you-think/

Update search.php and searchform.php and any other related search functionality/markup/styles. Ensure search functionality for previous version stories, issue pages, and archive pages.

Look into replacing with wp_remote_get() (preferred) or cURL.

See title; these buttons should only be keyboard accessible when the pulldown is active/visible.

create_function() was deprecated as of PHP 7.2. Instances of this this function throughout the repo should be removed and replaced with anonymous functions to support newer versions of PHP.

See https://www.php.net/manual/en/function.create-function.php

We ran into a bug with generated font-weights after upgrading gulp-sass in v4.1.14 where the gotham() mixin at least is not generating accurate font-weight values; e.g. gotham(7) generates a font weight of 70 instead of 700. We may need to update these mixins to calculate weight explicitly instead of appending a literal in front of two 0's; e.g.:

...
$weight-calculated: $weight * 100;
font-weight: $weight-calculated;
...

Because we use title-tag theme support instead of wp_title() to print a <title> tag in the document head, this function has no effect and should be removed.

Description

See title.

Why it's Important

To incorporate accessibility improvements introduced in v1.1.1, and to ensure we're including the latest+greatest updates.

Alternatives

n/a

Possible Implementation

Update package.json and re-run gulp tasks.

Additional context

n/a

Consider removing bootstrap-sass's build assets and package.json to resolve the ejs vulnerability in 3.3.4, since bootstrap is added to the theme manually and those build assets are not in use.

See title.

Older Pegasus stories pulled into the Related Stories sidebar section have a larger thumbnail size than the pulled in News stories or v5 Pegasus stories.

For example: https://www.ucf.edu/pegasus/powering-potential/
The 'Custom Solar Sculpture Built by UCF Students' story's thumbnail image size.

It's preferred that these stories thumbnails are the same size as the other Related Stories in the sidebar, if possible, ensuring that the older thumbnails are not cropped too much to where they are cutting out important parts of the image.

Add a "skip to main content" link that becomes visible on focus and is the first tabbable element on any page/story. The link should be an anchor pointing to <main>, allowing keyboard users to skip the site's header navigation.

Example: https://github.com/UCF/UCF-WordPress-Theme/blob/master/header.php#L7-L8

There are some style adjustments we could make for the Story post type that would help improve the spacing, readability and usage of classes throughout the stories:

• Headings in stories are adjusted to have a custom font face, size, and color in https://github.com/UCF/Pegasus-Theme/blob/master/versions/v6/functions.php#L35. The .h1, .h2, .h3, .h4, .h5, .h6, .display-1, .display-2, .display-3, .display-4 should be displayed the same/similarly to their respective heading/display tag, in order to discourage assigning text to headings and creating custom styles.
• Increase the margin/spacing above and below the image/image captions. The images are a little too close together and to other content as it is.
• Increase margin/spacing above headings. Headings throughout the story should have a little bit more breathing room in order to create a pause in reading.
• font-size-* classes should be relative to what the story's new font-size is, the current font-size with .font-size-sm applied is too small relative to the story text font size.

We should probably look at replacing the existing pulldown menu logic to use an Athena navbar + collapse buttons, and incorporate relevant aria attributes to improve the user experience for keyboard and screenreader users.

Additionally, we need to ensure each link in the nav bar has a visible focus state--currently, the Pegasus logo's outline is not visible.

Should work similar to how the Research Site related stories AMP setup is.

• Create ACF fields for choosing whether the Related Stories should be generated from the Pegasus site, Today site, or Manually Curated and the conditional fields for each of those options
• Make theme/template development adjustments for the newly created fields and functionality

Update includes/theme-help.php, includes/theme-options.php with updated theme information as necessary.

Also update images in static/img/theme-help/ as necessary.

The UCF Header is enqueued on all versions using the use-1200-breakpoint option. Versions that utilize Bootstrap 2 need the use-bootstrap-overrides option set instead, which fixes excess left- and right-hand padding on the bar at mobile sizes.

Determine which versions use Bootstrap 2, and implement this option for those versions in some way. Consider moving enqueueing of the header script out of the main functions/config.php and into version-specific functions/config.php files.

• two cols
• increase line-height
• font-size
• font-family

Should look similar to the current UCF Today AMP template. Ensure that there's a possibility to add a callout/spotlight in the left-hand col.

Update/remove any files, images, css, js in static/ as necessary. Make sure to ensure that previous version's stories, pages, etc still look & function correctly.

With the introduction of display_story_callout() to globally display story links/thumbnails, we lost the custom markup required for the lazy load js included in the theme to function properly.

We should consider either:

• Updating display_story_callout() to omit the image src attribute in favor of using data-original
• Or, de-queue jquery.lazyload.min.js in v6, and activate the lazysizes plugin like we use on other sites

Ensure that references to FA4 are updated/supported

Update /v6/templates/issue/ and /v6/templates/story/ files as necessary and any other related or referenced functionality/markup/styles.

https://github.com/UCF/Pegasus-Theme/blob/master/versions/v6/header.php#L67

This link needs some unique inner text, like "Toggle Menu".

This issue is present in all versions, but should be easy to address in all of them, as the markup is basically the same:

https://github.com/UCF/Pegasus-Theme/blob/master/versions/v5/header.php#L61
https://github.com/UCF/Pegasus-Theme/blob/master/versions/v4/header.php#L61
https://github.com/UCF/Pegasus-Theme/blob/master/versions/v3/header.php#L106
https://github.com/UCF/Pegasus-Theme/blob/master/versions/v2/header.php#L105
https://github.com/UCF/Pegasus-Theme/blob/master/versions/v1/header.php#L105

Consider adding in content sanitization in order to strip out empty tags and ensure that pasted in <i>s are corrected to <em>s, for example.

See https://github.com/UCF/Today-Utilities/blob/master/includes/today-utilities-admin.php#L278-L296

We also might want to consider adding in other parts of that function, such as the Outlook safelink replacement logic.

Make any WYSIWYG adjustments to support Athena and the Athena Shortcode Plugin. Also ensure compatibility with old Pegasus story versions.

Update SCSS styles in /v6/static/scss/ as necessary. Many of the styles might have already been updated with previous Athena updates in this project. This should be completed towards the end of the project to update any remaining styles and ensure that old version's stories and pages display correctly.

Update explicit update_option() calls in the theme with option_${option_name} filter hooks to eliminate unneeded db updates.