Comments (4)
easy thing is to use set -e
at the start. It does make the script stop whenever there's an error (that isn't inside a pipeline, etc). It does exit abruptly though without any message. We can switch it to bash
and then do something like this
https://github.com/UCL/STIR/blob/7b4c27470ad175a80f29e9aabe945b6831a4f159/scripts/estimate_scatter.sh#L104-L105
set -e # exit on error
trap "echo ERROR in $0" ERR
Obviously better is to do
if apply_normfactors3D $OutputFilename $factors ones.hs 1 1 $eff_iters
then
: #OK
else
echo "Error over here" >2;exit 1
fi
but it's much more verbose. In nearly all Bourne shells implementations you can shorten this to
if ! apply_normfactors3D $OutputFilename $factors ones.hs 1 1 $eff_iters
then
echo "Error over here" >2;exit 1
fi
but apparently it isn't 100% portable 😢 (although I cannot immediately find a link to that info anymore)
from stir-gate-connection.
Is there anything wrong with
apply_normfactors3D $OutputFilename $factors ones.hs 1 1 $eff_iters
if [ $? -eq 0 ]; then
echo "apply_normfactors3D OK"
else
echo "apply_normfactors3D FAIL"
exit 1
fi
besides it being verbose?
e: The first option seems to work nicely.
from stir-gate-connection.
sure, that's fine and even more verbose 😄
from stir-gate-connection.
Resolved with 3fef6c4
from stir-gate-connection.
Related Issues (20)
- EstimateSTIRGATENorm mistakenly adds 1s to the normalisation sinogram
- RandomsEstimate problems
- ComputePoissonDataCorrections script requires flip in z of attenuation map from GATE HOT 2
- Computation of the multiplicative factors
- Proposal for a general corrections script to compute all corrections for reconstruction HOT 2
- ComputePoissonDataCorrections will fail if not called from `VoxelisedSimulation` directory HOT 1
- Scripts are depenant on running from SGC VoxelisedSimulation directory HOT 5
- source this_SGC.sh from a different directory issue
- Example/Debugging unlisting scripts for demonstrating the exclusion of different types of events
- Limit unlisting to a particular number of events.
- Combining many ROOT files using `hadd` can exeed the (default) 100GB limit HOT 1
- Something wrong with the script ExampleSTIR-GATE.sh HOT 12
- Example GATE geometries may not be compatable with STIR 5.0.1 due to rotation/offset changes
- about norm factors of mMR HOT 2
- Example mMR geometry may be out of date?
- STIR ray tracing parameters restrict to cylindrical fov HOT 1
- Add a Citation.cff file
- the unit of reconstructed image HOT 3
- Mistakes in `ComputePoissonDataCorrections.sh` documentation HOT 1
- D690 Geometry Inconsistency HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stir-gate-connection.