error in norm-estimation script about stir-gate-connection HOT 2 CLOSED

@francescaleek found another problem if we want to have norm-factors compressed data (e.g. span>1). Both the measured_data and model_data have to be uncompressed due to limitations in find/apply*.

Only way that I see around this without STIR surgery is to keep outputting the efficiencies as above, and then manually using SSRB to get to the desired span. i.e. make sure that all data is span=1 as before and have the script as

apply_normfactors3D $eff_factors $factors ones.hs 1 $outer_iters $eff_iters 
  
 echo "inverting the eff_factors to get norm" 
 stir_math -s --including-first --power -1 $OutputFilename $eff_factors

Then say

span=2
SSRB span${span}_${eff_factors} ${eff_factors} $span 1 0
stir_math -s --including-first --power -1 span${span}_$OutputFilename span${span}_$eff_factors

However, this might not work for span=2. The STIR C++ (and python) code would be able to handle a "template" so we can work around this.

oh well.

from stir-gate-connection.

Oh dear... This may be a problem...

the first step should use ones.hs. At the moment it's "unnormalising" the model_data (good to compare to the measured data, but not good to get nrom factors!)

This seems to be a mistype then that got merged. The script creates ones.hs but never uses it.

Regarding the span, let me see if I can get this right. It seems that if span>1 is wanted, the unlisting of the measured_data must be span-1. The norm should computed with EstimateGATESTIRNorm.sh and then compressed to span-2

However, this might not work for span=2. The STIR C++ (and python) code would be able to handle a "template" so we can work around this.

Sorry, I dont understand why this might not work...

I will follow with a PR correcting the errror

from stir-gate-connection.