ucsd-ets / jupyterhub-saml-auth Goto Github PK

Hello!

I would like to thank you for you simple yet elegant 'wrapper' around OneLogin's SAML library ; it(s working like a charm.

I would like to propose (and will submit a MR soon) a simple addition : being able to extract the groups the user is in from the SAML attributes.
That way, we'll be able to perform group-based auth from the SAML response, which in my case is very handy (I suppose it could be useful to others too?)

The '/hub/acs' URI is mentioned in the existing README page for the env.var. - but it also should be mentioned to be used in settings.json.

The current README points to python3-saml for "anything else" that is not mentioned on these pages.

The referenced python3-saml docs however show "/?acs" as the assertionConsumerService url value.

Configuring it as such in the current setup gives a 405 "Method not allowed" on a POST to "/?acs".

Running jupyterhub 1.5.1, with jupyterhub-saml-auth 0.3.2 on the-littlest-jupyterhub 0.1

The correct assertionConsumerService url in settings.json should be '/hub/acs' - in which case SAML auth works fine.