ucsf-education / moodle-enrol-ucsfsis Goto Github PK

add ability to delete a scheduled sync job

solution: override can_delete_instance() method.

Step to reproduce:

1. Set up an SIS enrollment sync on a course with 'Assign role' set to 'Student'.
2. Save it.
3. Now, go back and edit this enrollment setting and change the 'Assign role' field to something other than 'Student'.
4. Check the 'Enrolled users' page, you will still see 'Student' role is being assigned to users.

solution: override can_show_hide_instance().

it's obsolete, let's get rid of it.

Attempting to disable an SIS enrollment instance from a course's enrollment methods page (click on the eyeball icon) causes Moodle to freeze. You can't get back into Moodle (clicking on any course link does nothing) .... it's frozen. Quitting the browser is the only recourse.

When you log back in, you can see the disable attempt did go through -- the SIS enrollment instance is disabled. If you try to re-enable it (clicking on the now-closed eyeball icon), Moodle freezes again. Quit the browser and log back in, and you see that the enrollment is now enabled.

Disabling/enabling other forms of enrollment in this way (manual, self, Ilios) works fine. The enrollment is disabled (or re-enabled) very quickly. This only seems to be a problem with SIS enrollment.

it's a non-standard component that's not officially "supported" in the Moodle Form API.
it also does not comply with the look and feel of form components in the Boost theme.

replace this.