ucsf-education / uctech-greeter Goto Github PK

probably not needed if foreman runs the app in "worker" mode.

https://devcenter.heroku.com/articles/procfile

This block of code is not covered by the tests.

https://github.com/ucsf-ckm/uctech-greeter/blob/cd12f60d5b3aa32f6208cccd45a14235afc00e7c/features/greeter.js#L11-L15

When running npm test:

****************************************************************************************
* WARNING: Your bot is operating without recommended security mechanisms in place.     *
* Initialize your Botkit controller with a clientSigningSecret paramter to enable      *
* verification that all incoming webhooks originate with Slack:                        *
*                                                                                      *
* var controller = new Botkit.slackbot({clientSigningSecret: <my secret from slack>}); *
*                                                                                      *
****************************************************************************************

The event fires, but new users do not receive new messages from the greeter upon account creation.

I've described this issue in detail here: http://stackoverflow.com/questions/38861714/how-can-i-post-a-welcome-message-to-a-newly-joined-user-via-a-slack-bot

a custom command will do.

/welcome-message

should print out the welcome text.

as the title says.

add a paragraph to the welcome message.

that would be botkit v4.

right now, the bot and the express app both reside in the index.js file.
separate these out.
revisit the worker vs web definitions in the Procfile.

follows #1

publish this thing to NPM while at it.

so instead of /welcome-message, perhaps have the bot respond on @greeterbot welcome, or the likes.

benefits:

• one app (bot) instead of two (bot and custom command express app)
• reduces # of integrations needed (only one for the bot, instead of bot plus one for each command)

downsides:

• the code to power it is less straightforward. we'd have to do some pattern matching on each posted message, instead of just responding to explicit commands.

it's been a while, do it.

$ npm outdated
Package        Current  Wanted  Latest  Location
app-root-path    2.2.1   2.2.1   3.0.0  uctech-greeter
botkit           0.5.8   0.5.8   4.6.2  uctech-greeter
dotenv           4.0.0   4.0.0   8.2.0  uctech-greeter
eslint          4.19.1  4.19.1   6.8.0  uctech-greeter

Saying something like @greeterbto: what are the rules? should respond with the code of conduct.

add a section about the custom command /welcome-message endpoint in the README file.

Replace dummy text in welcome.txt with actual contents.
https://github.com/stopfstedt/uctech-greeter/blob/master/welcome.txt

These basic formatting options can be applied.

Botkit appears to have been abandoned.

We're locked in to Node 14 due to some old upstream dependencies in one (or more) Botkit related building blocks.

Consider using https://www.npmjs.com/package/@slack/bolt as a replacement.