udacity / frontend-nanodegree-arcade-game Goto Github PK

View Code? Open in Web Editor NEW

287.0 46.0 3.6K 2.79 MB

License: Other

CSS 0.25% HTML 2.37% JavaScript 97.38%

frontend-nanodegree-arcade-game's Introduction

Classic Arcade Game Clone Project

Instructions
Contributing

Instructions

Use this rubric for self-checking your submission.

Make sure the functions you write are object-oriented - either class functions (like Player and Enemy) or class prototype functions such as Enemy.prototype.checkCollisions. Also make sure that the keyword this is used appropriately within your class and class prototype functions to refer to the object the function is called upon.

Your README.md file should be updated with instructions on both how to 1. Run and 2. Play your arcade game.

For detailed instructions on how to get started, check out this guide.

Contributing

This repository is the starter code for all Udacity students. Therefore, we most likely will not accept pull requests.

Archival Note

This repository is deprecated; therefore, we are going to archive it. However, learners will be able to fork it to their personal Github account but cannot submit PRs to this repository. If you have any issues or suggestions to make, feel free to:

Utilize the https://knowledge.udacity.com/ forum to seek help on content-specific issues.
Submit a support ticket along with the link to your forked repository if (learners are) blocked for other reasons. Here are the links for the retail consumers and enterprise learners.

frontend-nanodegree-arcade-game's People

Contributors

Stargazers

Watchers

Forkers

mxschumacher durant-udacity sfrapoport abhay-shankar gaurimjog bahalperin mengxi jmiguelsamper pchomphoosang jsnoble dawoonc sgwd glenncameronjr yomt kzf ronniebrown samleach shimonb89 resendedaniel subratrout totogo defectivecube corylstewart batmanimal l337 jdashley27 jseligsohn igor-ladkin rprovine yumikohey ceckleder schafeld bastiandantilus cch5ng kevdonk git-chris puneethrai troutzen gp-git cargopop ftchirou swatchophile ro-savage tralpha futhrevo pawelszy steamingenius yaskyj sentry71 maurotrochez jonshih jessicakagan gremlin12 michaelvasey soojino gkanch saksoy jaysmith502 apewiki mjkaiser aszwemin mackermedia aui3 happyspace paulchino georgejdli tinggao marionuevo abustamam jokobia droth820 haopei addugger irinalobova ingikim aaronmclean1 aaditgupta kchia hosuke mattkuo ivanarrizabalaga aaronbjohnson pnellesen mikelzuzu bermanmt muhanadra aricept stanica solo206 iohansson eelomar tenchjames mmux 6stringbeliever tbonzai grimesmea alexgwozda bplusv valial reinaldomendes

frontend-nanodegree-arcade-game's Issues

Engine is undefined

I wanted to give players the option to play again (after running into too many bugs and losing all of their lives), so I created a modal pop-up with a button that effectively calls init() from within Engine. However, Engine was coming back as undefined... to get around this, I am returning {'init': init} to be able to call Engine.init().

As other Udacity students may have problems with this, what would be a good way to handle this case going forward?

typographical errors || grammar/syntax errors

resources.js line 2

This is simple an image loading utility.

simply

resources.js lines 39–42

/* If this URL has been previously loaded it will exist within
 * our resourceCache array. Just return that image rather
 * re-loading the image.
 */

rather than

resources.js line 73

This is used by developer's to

developers

resources.js line 81–82

/* This function determines if all of the images that have been requested
 * for loading have in fact been completed loaded.

completely

engine.js lines 18–20

set the canvas elements height/width and add it to the DOM.

element's

engine.js line 86

This is called by the update function  and loops

one space

engine.js line 90

the data/properties related to  the object. Do your drawing in your

one space

engine.js line 144

It's purpose is

Its

engine.js line 180

so that developer's can use it

developers

not disposing callbacks in Resource after exec it

When invoking Resource.load([]) a second time to load assets for a new scene Engine.Init() runs because it is still in readyCallbacks Array.

a possible fix could be

if (isReady()) {
    while (readyCallbacks.length > 0) {
        var func = readyCallbacks.pop();
       func();
    }
}

resources.js line 37: Style Guide Correction

resources.js line 37
consider renaming _load() toload_() in accordance with Google Javascript Style Guide:
https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Naming#Naming

README: Project rubric doesn't exist

Project rubric doesn't exist. The link shows a blank page.

ReferenceError: allEnemies is not defined

THe page index.html does not show anything to start.
ReferenceError: allEnemies is not defined

Authentication failed...!!!

Hi,

I'm trying to push my code to the repository but i get this message:

"
Authentication failed. You may not have permission to access the repository or the repository may have been archived. Open options and verify that you're signed in with an account that has permission to access this repository.
"
I checked my username password, everything seems OK to me...
Any help?