Giter VIP home page Giter VIP logo

moviesapp's People

Contributors

pn1019 avatar

Stargazers

 avatar

Watchers

 avatar  avatar

moviesapp's Issues

Naming Conventions are bit Incosistent

As per the Reviewer,

Your naming convention for fields is a bit inconsistent here. This variable is prefixed with an "m", whereas most of the other ones are not. You should pick one of these conventions and use it consistently to improve your code's readability. Typically, people prefix with an "m" and use camelCasing; however, I've also seen others use straight camelCasing with no "m" prefix. The choice is yours!

Offline Support

As per the suggestion by udacity reviewer,says that:

You should use an empty view. An empty view is a view that appears in a gridview, listview, recyclerview, or equivalent when no data is present to display. For example, if the internet is disabled

Because you are using a recyclerview, you have to implement this yourself, as gridview, and listview already have this functionality built in. You can learn how to do this a couple of different ways here: http://stackoverflow.com/questions/28217436/how-to-show-an-empty-view-with-a-recyclerview
My personal suggestion is to extend recyclerview.

This helps user experience by showing why the application is behaving a certain way. In this case, it will alert the user the app won't work correctly without internet.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.