Giter VIP home page Giter VIP logo

Comments (4)

forrestv avatar forrestv commented on August 19, 2024

What exactly was the resolution for all this stuff? I thought what happened
was something along the lines of:

Forrest: There's no reason this stuff can't be written in Python.
Ralph/Jake: Great!

And I don't see how that meshes with closing all these issues.

On Fri, Oct 2, 2015 at 12:03 AM, Jake [email protected] wrote:

Closed #10 #10.


Reply to this email directly or view it on GitHub
#10 (comment).

from subjugator.

jpanikulam avatar jpanikulam commented on August 19, 2024

Cause was additional offline discussion:

  • What do we gain from reimplementing this?
    -- Ownership
  • Does the code do anything we need to own?
    -- No, it reads data and publishes it
  • Do people need to edit this often?
    -- No, it will probably never be touched again

So it is neither wise nor a prudent use of our time to re-do these, when we'd be making no functionality changes. => closing these as wontfix.

A counterpoint to this is that sensor failure alarms must be added. But those changes comprise a different issue group imo.

Do you agree with the above?

  • Jake

On Oct 2, 2015, at 12:49 AM, Forrest Voight [email protected] wrote:

What exactly was the resolution for all this stuff? I thought what happened
was something along the lines of:

Forrest: There's no reason this stuff can't be written in Python.
Ralph/Jake: Great!

And I don't see how that meshes with closing all these issues.

On Fri, Oct 2, 2015 at 12:03 AM, Jake [email protected] wrote:

Closed #10 #10.


Reply to this email directly or view it on GitHub
#10 (comment).


Reply to this email directly or view it on GitHub.

from subjugator.

forrestv avatar forrestv commented on August 19, 2024

I'd say that it's very important that at least one person understands the
magnetic hard/soft compensation algorithm and calibration algorithm. And
ooh, the calibration algorithm is actually commented! (Probably because it
absolutely needs it. :P)

Dynamic magnetic compensation wasn't used on Sub2015 because none of the
motors were very close to the IMU (since it was centered), but I'm not sure
if that still applies with the new navigation vessel.

As for the drivers, I suppose it's not very important to rewrite/understand
them, especially for the IMU and depth sensor, which are simple and will
both be replaced anyway.

The DVL, however, does have a lot of different settings and modes, so I
think it's important for someone to be familiar with it. For example, you
didn't know that it tracks the bottom rather than the water mass and
Zach/Jason didn't know that it's configured to output beam velocities
instead of a 3D velocity... Other things that probably aren't generally
known: It's currently configured for a maximum depth of 15 meters, so it
will (presumably) stop tracking if the distance from the DVL to the bottom
is ever greater than that. It has an RTC and a weird bug that's triggered
if the RTC runs for too long, so we set the time/date to "2012/03/04,
05:06:07" on every startup to avoid it. If outputs the distance to the
bottom on /dvl/range, which a lot of missions made use of.

FYI, the DVL manual is available here:
http://www.otronix.com/kr/data/p02/ExplorerDVL_Operation_Manual.pdf , which
is funny since I thought it was covered by an NDA.

So, none of that necessarily necessitates a rewrite, but writing something
yourself is the best way to ensure that you understand it...

On Fri, Oct 2, 2015 at 1:13 AM, Jake [email protected] wrote:

Cause was additional offline discussion:

  • What do we gain from reimplementing this?
    -- Ownership
  • Does the code do anything we need to own?
    -- No, it reads data and publishes it
  • Do people need to edit this often?
    -- No, it will probably never be touched again

So it is neither wise nor a prudent use of our time to re-do these, when
we'd be making no functionality changes. => closing these as wontfix.

A counterpoint to this is that sensor failure alarms must be added. But
those changes comprise a different issue group imo.

Do you agree with the above?

  • Jake

On Oct 2, 2015, at 12:49 AM, Forrest Voight [email protected]
wrote:

What exactly was the resolution for all this stuff? I thought what
happened
was something along the lines of:

Forrest: There's no reason this stuff can't be written in Python.
Ralph/Jake: Great!

And I don't see how that meshes with closing all these issues.

On Fri, Oct 2, 2015 at 12:03 AM, Jake [email protected] wrote:

Closed #10 #10.


Reply to this email directly or view it on GitHub
#10 (comment).


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#10 (comment).

from subjugator.

forrestv avatar forrestv commented on August 19, 2024

Anyway, as you want to get into the pool soon, perhaps it is wise to
postpone this for now. Just something to be aware of.

On Fri, Oct 2, 2015 at 2:10 AM, Forrest Voight [email protected]
wrote:

I'd say that it's very important that at least one person understands the
magnetic hard/soft compensation algorithm and calibration algorithm. And
ooh, the calibration algorithm is actually commented! (Probably because it
absolutely needs it. :P)

Dynamic magnetic compensation wasn't used on Sub2015 because none of the
motors were very close to the IMU (since it was centered), but I'm not sure
if that still applies with the new navigation vessel.

As for the drivers, I suppose it's not very important to
rewrite/understand them, especially for the IMU and depth sensor, which are
simple and will both be replaced anyway.

The DVL, however, does have a lot of different settings and modes, so I
think it's important for someone to be familiar with it. For example, you
didn't know that it tracks the bottom rather than the water mass and
Zach/Jason didn't know that it's configured to output beam velocities
instead of a 3D velocity... Other things that probably aren't generally
known: It's currently configured for a maximum depth of 15 meters, so it
will (presumably) stop tracking if the distance from the DVL to the bottom
is ever greater than that. It has an RTC and a weird bug that's triggered
if the RTC runs for too long, so we set the time/date to "2012/03/04,
05:06:07" on every startup to avoid it. If outputs the distance to the
bottom on /dvl/range, which a lot of missions made use of.

FYI, the DVL manual is available here:
http://www.otronix.com/kr/data/p02/ExplorerDVL_Operation_Manual.pdf ,
which is funny since I thought it was covered by an NDA.

So, none of that necessarily necessitates a rewrite, but writing something
yourself is the best way to ensure that you understand it...

On Fri, Oct 2, 2015 at 1:13 AM, Jake [email protected] wrote:

Cause was additional offline discussion:

  • What do we gain from reimplementing this?
    -- Ownership
  • Does the code do anything we need to own?
    -- No, it reads data and publishes it
  • Do people need to edit this often?
    -- No, it will probably never be touched again

So it is neither wise nor a prudent use of our time to re-do these, when
we'd be making no functionality changes. => closing these as wontfix.

A counterpoint to this is that sensor failure alarms must be added. But
those changes comprise a different issue group imo.

Do you agree with the above?

  • Jake

On Oct 2, 2015, at 12:49 AM, Forrest Voight [email protected]
wrote:

What exactly was the resolution for all this stuff? I thought what
happened
was something along the lines of:

Forrest: There's no reason this stuff can't be written in Python.
Ralph/Jake: Great!

And I don't see how that meshes with closing all these issues.

On Fri, Oct 2, 2015 at 12:03 AM, Jake [email protected] wrote:

Closed #10 #10.


Reply to this email directly or view it on GitHub
#10 (comment).


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#10 (comment).

from subjugator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.