ui-ninja / react-native-rating-element Goto Github PK

It seems that this library is missing a type definition file and there is none added so far in DefinitelyTyped repo, will that be added in the future? I'm pretty new to typescript myself, so I'm not really sure I can add one.

Instead of defining just an icon, let us define a type with ["icon", "custom"] (defaults to icon) and if we set the type to custom, we can use an custom image (for example a .png file). This way we would be able to setup something like this:

Thanks a lot!

Hi,
It works well with direction="column", but when direction is set to column-reverse, the views are not aligned and coloredIcons are not drawn from bottom to up.

<Rating
        rated={0.5}
        totalCount={1}
        ratingColor="#f1c644"
        ratingBackgroundColor="#d4d4d4"
        size={100}
        readonly
        icon="ios-star"
        direction="column" // direction="column-reverse"
      />

direction="column"	direction="column-reverse"

Running this

<Rating size={48} totalCount={1} rated={stern1} />

and clicking on it crashes the app because of

ERROR TypeError: onIconTap is not a function. (In 'onIconTap(position + 1)', 'onIconTap' is undefined)

There is never a check if this function exists and from reading the docs there is no need to define this function.

Please either check if the function exists (which should be the way to go anyways) or update the docs :) Thanks!

Add support for material community icons or font-awesome 5 for example

I would like to animate the rating once the user visits a page (to show his latest progress for example). Also i would like to add a little bounce effect when a user taps on a rating element.

Would be awesome to add this! Let's make this package the leading one when it comes to ratings.

Before raising issue, first thanks for creating this library. 😃

During usage of library, I found that when talkback is active,

• for readonly ratings its accessing child icons as well, instead I think it should read out something like "rated x out of x" on parent view
• for tappable icons, it is reading nothing.

Thanks!

I know it's by design, but why? I don't see any reason for it. Even if the Rating is readonly, i want to know where a user tapped (to toggle tooltips in my case).

If you want to keep it this way, at least note it in the docs.

Regards

Please add an option to display the rating icons vertical (going from bottom (0) to top (X))