umbrella-h / course_api_example Goto Github PK

Rails sets up development.sqlite and test.sqlite automatically when we start the app. (These files are included in .gitignore rules)

Besides, that's the reason why we don't have to setup database in CI-CD.

We can apply gem activerecord-nulldb-adapter to properly deal with this case in development and test environments.

In README and example dataset.

I sliced the app into application, domain, data access and db implementation layers, so it’s feasible to change to ActiveRecord and SQL database.

However, the implementation in FindUsersByCourse and FindCoursesByUser will lead to N+1 query problem.

Expected Behavior

# If Dataset::Base is not setup…

User::Client.new.find_user_by_id(id: 1)

# raise DataNotSetUp

Actual Behavior

# If Dataset::Base is not setup…

User::Client.new.find_user_by_id(id: 1)

# return nil

Probable Solution

In the called use_case, specifically rescue DataNotSetUp and wrap it in failure.

…maybe needs some meta programming.