Giter VIP home page Giter VIP logo

Comments (3)

alecdotninja avatar alecdotninja commented on May 27, 2024 1

@davidalejandroaguilar Thank you for being the trailblazer on this!

A PR to add documentation would be greatly appreciated. 😄

That said, I think you might be able to get away with something a little simpler:

  config.renderer_for_connection_proc = ->(websocket_connection) do
    ApplicationController.renderer.new(
      websocket_connection.env.slice(
        Rack::HTTP_COOKIE,
        Rack::RACK_SESSION,
        'warden'
      )
    )
  end

Does that not work?

from motion.

davidalejandroaguilar avatar davidalejandroaguilar commented on May 27, 2024 1

Ah, that also works. The websocket_connection object already has the warden environment, nice!

I'll close this issue now. I'll open a PR for this default config change then. Thanks!

from motion.

alecdotninja avatar alecdotninja commented on May 27, 2024

If supporting it is as simple as including this additional env option, Warden is common enough that I would also be open to a PR to update the default renderer_for_connection_proc to include it. I don't want to allow everything by default because I'm not sure what all is safe to use on a long-lived and hijacked connection, but whitelisting individual keys like this should be fine.

from motion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.