Giter VIP home page Giter VIP logo

flay-actionpack's People

Contributors

berkes avatar davidsiaw avatar unclegene avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

systho davidsiaw

flay-actionpack's Issues

`ActionView::Template::Handlers::ERB.call` has changed signature

While attempting to use this gem on a project I kept receiving a wrong number of arguments error, upon ivestigation I suspect the culprit to be: https://github.com/UncleGene/flay-actionpack/blob/master/lib/flay_actionpack.rb#L15

This is because the function being called has been updated to use a different signature: https://github.com/rails/rails/blob/348e609da369c4a32cdcab51a78edcd0ad2942c1/actionview/lib/action_view/template/handlers/erb.rb#L57

Merely adding the gem doesn't appear to be enough

I have a project where flay is failing on Rails ERb files.

So I added

gem 'flay-actionpack'

to Gemfile, but it still failed to parse ERb files.

Investigating with ruby -d, Bundler appears to be trying to load:

  • 'flay-actionpack'
  • 'flay/actionpack'

But the actual file is 'flay_actionpack.rb' so neither of those is going to work.

The code in Bundler responsible for this is: https://github.com/rubygems/bundler/blob/master/lib/bundler/runtime.rb#L65-L94

Clearly it must have worked at some point in the past, so my guess is that perhaps Bundler changed its mind on what separators it was going to permit?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.