Giter VIP home page Giter VIP logo

ez-consent's People

Contributors

dependabot[bot] avatar juliankuipers avatar undergroundwires avatar undergroundwires-bot avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

ez-consent's Issues

Cookie is set when 'read more' is clicked, is this inteded?

Hi,

First of all, thank you for this tool!

I have a question.

When a user clicks the 'read more' button the consent is automatically given as if the user has clicked the 'ok' button. Should this be the default behavior? Or should the user still click the 'ok' button to give it's consent after reading the privacy page? So clicking the 'read more' button does not actually set the cookie?

I hope to hear from you, thank you in advance!

Kind regards,

Julian

Feature: Set Cookie Expiry Time

hello - how do we set cookie expiry, depending on each country laws are different, for some countries it needs a be one year/365 days

Classes break BEM convention

It is mentioned in the README that internal CSS classes follow the BEM convention. However, in one aspect the convention is broken - some classes contain an element inside of an element, such as a "read more" class or "OK" class:

const cssClassNames = {
      root: 'cookie-consent',
      hide: 'cookie-consent__hide',
      buttons: {
        shared: 'cookie-consent__buttons-button',
        read_more: 'cookie-consent__buttons__read-more',
        ok: 'cookie-consent__buttons__close',
      },
};

According to BEM this should not happen.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.