Giter VIP home page Giter VIP logo

Comments (15)

mlinksva avatar mlinksva commented on August 24, 2024 2

@artob is it possible to deploy master to wherever https://unlicense.org is hosted (the footer says dreamhost...) so that this can be closed?

FWIW, GitHub Pages supports https for custom domains since last year in case serving the site from there would be easier (well, no deploy step). It would be trivial to convert to Jekyll I think. Again, just FWIW.

from unlicense.org.

Hexstream avatar Hexstream commented on August 24, 2024 1

That would further complicate license detection.

We already had the problem that the "optional" last line of the license turned out to be required when GitHub's license detection got stricter. The recommendation thus became to add back that last line for those who had omitted it. I think it would be a bit schizophrenic to now require that the last line be removed/absent. It's not clear to me that GitHub would accept to support 2 versions of the license, one with the last line and one without.

So I think the last line of the license should probably stay.

from unlicense.org.

mlinksva avatar mlinksva commented on August 24, 2024 1

I forgot that I wrote almost exactly the same as above in #55 (comment) 😆

It must not have sunk in to me at the time that the website had such a clear instruction.

I'll make a PR to the library that GitHub uses to detect licenses to enable it to detect Unlicense without the optional line, along the lines of licensee/licensee#253 (but simpler). No promise that the maintainer will merge it though!

from unlicense.org.

corollari avatar corollari commented on August 24, 2024

I fixed this problem in my redesign (#68) but this repo/website has been neglected for some time.

In my opinion the best course of action would be to directly remove that line from the license and let it just stand on it's own, without linking it directly with a website that can change in the future.

from unlicense.org.

mlinksva avatar mlinksva commented on August 24, 2024

What @Hexstream writes is true.

I would not recommend removing the line from the text published by unlicense.org but if in general that line ought be optional, https://github.com/spdx/license-list-XML/blob/master/src/Unlicense.xml ought wrap it with <optional>. GitHub doesn't currently use annotations in SPDX XML but I think there are some license detection/compliance tools that do.

from unlicense.org.

corollari avatar corollari commented on August 24, 2024

What were the reasons/arguments that lead to the decision of recommending to add the last line?

from unlicense.org.

Hexstream avatar Hexstream commented on August 24, 2024

Good question, see #61 (comment) for rationale.

from unlicense.org.

corollari avatar corollari commented on August 24, 2024

@Hexstream Sorry but I don't see from the discussion in the link you provided why was that decision made.

  • Why is it that suddenly github's detection required the existence of that line on licenses?
  • Why was it decided to include the line instead of removing it? It seems that an standard unlicense without such line would also get properly detected by Github.

from unlicense.org.

Hexstream avatar Hexstream commented on August 24, 2024

Sorry, it seems I had misunderstood your question.

I had the displeasure of stumbling upon the change one day.

See my comment here (starting at "So, we finally get to the point:") for details.

It would probably be best if GitHub respected the original intent of the license, which was that the last line was optional, but for some reason it does not.

from unlicense.org.

corollari avatar corollari commented on August 24, 2024

I've just put forward a PR with the changes suggested by @mlinksva.

from unlicense.org.

kunal6673 avatar kunal6673 commented on August 24, 2024

Remove my bug file

from unlicense.org.

Hexstream avatar Hexstream commented on August 24, 2024

The site is pending a big redesign, I think that's why it's not as well-maintained as it could be. It would be nice if this deploy could still be done in the meanwhile.

from unlicense.org.

corollari avatar corollari commented on August 24, 2024

The redesign has been mentioned for several months now but there seems to be no progress on it.

from unlicense.org.

corollari avatar corollari commented on August 24, 2024

Also, something relevant to the discussion may be github/choosealicense.com/pull/679. It was closed because the link is included in most versions of the unlicense on github.

from unlicense.org.

Hexstream avatar Hexstream commented on August 24, 2024

The redesign has been mentioned for several months now but there seems to be no progress on it.

I'm assuming that Arto Bendiken (pinged above) is busy with other projects.

from unlicense.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.